From e9fa7aeb1a32e22ff0749d67995e689028ca5a19 Mon Sep 17 00:00:00 2001 From: Ravishankar N Date: Tue, 8 Mar 2016 16:43:12 +0530 Subject: afr: misc performance improvements Backport of http://review.gluster.org/#/c/13595/ 1. In afr_getxattr_cbk, consider the errno value before blindly launching an inode refresh and a subsequent retry on other children. 2. We want to accuse small files only when we know for sure that there is no IO happening on that inode. Otherwise, the ia_sizes obtained in the post-inode-refresh replies may mismatch due to a race between inode-refresh and ongoing writes, causing spurious heal launches. Change-Id: I9858485d1061db67353ccf99c59530731649c847 BUG: 1309462 Signed-off-by: Ravishankar N Reviewed-on: http://review.gluster.org/13644 Smoke: Gluster Build System NetBSD-regression: NetBSD Build System Reviewed-by: Pranith Kumar Karampuri Reviewed-by: Krutika Dhananjay CentOS-regression: Gluster Build System --- xlators/features/locks/src/posix.c | 18 ++++++++++++++++++ 1 file changed, 18 insertions(+) (limited to 'xlators/features') diff --git a/xlators/features/locks/src/posix.c b/xlators/features/locks/src/posix.c index 3d79c570bb0..76c7c4ee7ce 100644 --- a/xlators/features/locks/src/posix.c +++ b/xlators/features/locks/src/posix.c @@ -2189,6 +2189,23 @@ pl_lookup (call_frame_t *frame, xlator_t *this, loc_t *loc, dict_t *xdata) return 0; } +int32_t +pl_fstat_cbk (call_frame_t *frame, void *cookie, xlator_t *this, int32_t op_ret, + int32_t op_errno, struct iatt *buf, dict_t *xdata) +{ + PL_STACK_UNWIND (fstat, xdata, frame, op_ret, op_errno, buf, xdata); + return 0; +} + +int32_t +pl_fstat (call_frame_t *frame, xlator_t *this, fd_t *fd, dict_t *xdata) +{ + PL_LOCAL_GET_REQUESTS (frame, this, xdata, fd, NULL); + STACK_WIND (frame, pl_fstat_cbk, FIRST_CHILD(this), + FIRST_CHILD(this)->fops->fstat, fd, xdata); + return 0; +} + int pl_readdirp_cbk (call_frame_t *frame, void *cookie, xlator_t *this, int op_ret, int op_errno, gf_dirent_t *entries, dict_t *xdata) @@ -2776,6 +2793,7 @@ pl_fentrylk (call_frame_t *frame, xlator_t *this, struct xlator_fops fops = { .lookup = pl_lookup, .create = pl_create, + .fstat = pl_fstat, .truncate = pl_truncate, .ftruncate = pl_ftruncate, .open = pl_open, -- cgit