From c0e66dddcd8964871e0d574f927684ee7e3c4904 Mon Sep 17 00:00:00 2001 From: Varsha Rao Date: Thu, 28 Jun 2018 14:28:27 +0530 Subject: xlators/meta: Fix resource_leak Free priv to fix the resource_leak coverity issue. Change-Id: Id116bd2f72332d2f665c25c9ae27241286ac570f updates: bz#789278 Signed-off-by: Varsha Rao --- xlators/meta/src/meta.c | 19 ++++++++++++------- 1 file changed, 12 insertions(+), 7 deletions(-) (limited to 'xlators/meta') diff --git a/xlators/meta/src/meta.c b/xlators/meta/src/meta.c index 7ea01ab147b..4c4d671f59d 100644 --- a/xlators/meta/src/meta.c +++ b/xlators/meta/src/meta.c @@ -226,17 +226,22 @@ mem_acct_init (xlator_t *this) int init (xlator_t *this) { - meta_priv_t *priv = NULL; + meta_priv_t *priv = NULL; + int ret = -1; - priv = GF_CALLOC (sizeof(*priv), 1, gf_meta_mt_priv_t); - if (!priv) - return -1; + priv = GF_CALLOC (sizeof(*priv), 1, gf_meta_mt_priv_t); + if (!priv) + return ret; - GF_OPTION_INIT ("meta-dir-name", priv->meta_dir_name, str, out); + GF_OPTION_INIT ("meta-dir-name", priv->meta_dir_name, str, out); - this->private = priv; + this->private = priv; + ret = 0; out: - return 0; + if (ret) + GF_FREE (priv); + + return ret; } -- cgit