From 4f6749aa308152dc6350632991a6ae11b8467fb1 Mon Sep 17 00:00:00 2001 From: rishubhjain Date: Sat, 30 Mar 2019 15:46:38 +0530 Subject: GlusterD: Resolves the issue of referencing memory after it has been freed Setting the pointer to NULL after GF_FREE() and checking the pointer value before calling GF_FREE() to avoid referencing memory after its has been freed CID: 1398622 Change-Id: Iba0d8879abccf5923a69132a207d53bb94551417 updates: bz#789278 Signed-off-by: rishubhjain --- xlators/mgmt/glusterd/src/glusterd-utils.c | 4 ---- 1 file changed, 4 deletions(-) (limited to 'xlators/mgmt/glusterd') diff --git a/xlators/mgmt/glusterd/src/glusterd-utils.c b/xlators/mgmt/glusterd/src/glusterd-utils.c index 3570b018eeb..565f8b7dc3b 100644 --- a/xlators/mgmt/glusterd/src/glusterd-utils.c +++ b/xlators/mgmt/glusterd/src/glusterd-utils.c @@ -13173,8 +13173,6 @@ glusterd_get_default_val_for_volopt(dict_t *ctx, gf_boolean_t all_opts, "Failed to " "set %s in dictionary", vme->key); - if (get_value_vme) - GF_FREE(def_val); goto out; } sprintf(dict_key, "value%d", count); @@ -13184,8 +13182,6 @@ glusterd_get_default_val_for_volopt(dict_t *ctx, gf_boolean_t all_opts, "Failed to " "set %s for key %s in dictionary", def_val, vme->key); - if (get_value_vme) - GF_FREE(def_val); goto out; } if (get_value_vme) -- cgit