From 59401e705b9432345f3b449b50cfa4095ce2169a Mon Sep 17 00:00:00 2001 From: Oshank Kumar Date: Tue, 24 Jul 2018 16:26:18 +0530 Subject: glusterd: Deadcode Coverity issue This patch will fix coverity issue 74 from [1]. we are updating ret value line number 5011, and immediately checking whether ret is having non zero value at line number 5013.If ret is 0, then only we continue to execute and we can reach line number 5036. By the time we reach 5036, ret value is always 0. So this block of code is redundant here and removing it. [1] https://download.gluster.org/pub/gluster/glusterfs/static-analysis/master/glusterfs-coverity/2018-07-23-5fa004f3/html/ Updates: bz#789278 Change-Id: Ia6e8ba2936e350f0d29a9151ab786622f5e750db Signed-off-by: Oshank Kumar --- xlators/mgmt/glusterd/src/glusterd-utils.c | 2 -- 1 file changed, 2 deletions(-) (limited to 'xlators/mgmt/glusterd') diff --git a/xlators/mgmt/glusterd/src/glusterd-utils.c b/xlators/mgmt/glusterd/src/glusterd-utils.c index 6be40ef8c02..dc8e1bdfd80 100644 --- a/xlators/mgmt/glusterd/src/glusterd-utils.c +++ b/xlators/mgmt/glusterd/src/glusterd-utils.c @@ -5033,8 +5033,6 @@ glusterd_compare_friend_data (dict_t *peer_data, int32_t *status, glusterd_launch_synctask (glusterd_import_friend_volumes_synctask, peer_data_copy); - if (ret) - goto out; } out: -- cgit