From 571cbcf56ef865d64ebdb1621c791fe467501e52 Mon Sep 17 00:00:00 2001 From: Mohammed Rafi KC Date: Mon, 9 Nov 2015 16:43:21 +0530 Subject: glusterd: brick failed to start brick volfiles are generated in post validate, if it is running version higher than GLUSTER_3_7_5, else will be running in syncop. If the code fall back to syncop, and volume is stopped then we were returning the operation with out generating volfiles. Change-Id: I3b16ee29de19c5d34e45d77d6b7e4b665c2a4653 BUG: 1282322 Signed-off-by: Mohammed Rafi KC Reviewed-on: http://review.gluster.org/12552 Tested-by: NetBSD Build System Tested-by: Gluster Build System Reviewed-by: Atin Mukherjee --- xlators/mgmt/glusterd/src/glusterd-brick-ops.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) (limited to 'xlators/mgmt') diff --git a/xlators/mgmt/glusterd/src/glusterd-brick-ops.c b/xlators/mgmt/glusterd/src/glusterd-brick-ops.c index 31c07e6b230..efd70581f46 100644 --- a/xlators/mgmt/glusterd/src/glusterd-brick-ops.c +++ b/xlators/mgmt/glusterd/src/glusterd-brick-ops.c @@ -1337,7 +1337,7 @@ glusterd_op_perform_add_bricks (glusterd_volinfo_t *volinfo, int32_t count, ret = 0; if (GLUSTERD_STATUS_STARTED != volinfo->status) - goto out; + goto generate_volfiles; ret = generate_brick_volfiles (volinfo); if (ret) @@ -1413,6 +1413,8 @@ glusterd_op_perform_add_bricks (glusterd_volinfo_t *volinfo, int32_t count, _glusterd_restart_gsync_session, ¶m); } volinfo->caps = caps; + +generate_volfiles: if (conf->op_version <= GD_OP_VERSION_3_7_5) { ret = glusterd_create_volfiles_and_notify_services (volinfo); } else { -- cgit