From 0e23ce3fbcf1f138105476cf3b86342268e259d9 Mon Sep 17 00:00:00 2001 From: Vijay Bellur Date: Fri, 3 Apr 2015 14:14:35 +0530 Subject: performance/md-cache: set right error check in {f}getxattr_cbk() Currently mdc_{f}getxattr_cbk() check(s) for a non-zero value to determine if any cache update has to be performed. Right from posix xlator, op_ret has a positive value upon success and -1 upon failure. This patch sets right the check in getxattr callbacks so that xattr cache update happens for successful calls. Change-Id: Ifa5ec38bdf7e3dc095de9a56d91559b13cd9e8b6 BUG: 1208784 Signed-off-by: Vijay Bellur Reviewed-on: http://review.gluster.org/10127 Tested-by: Gluster Build System Reviewed-by: Raghavendra Talur --- xlators/performance/md-cache/src/md-cache.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) (limited to 'xlators/performance') diff --git a/xlators/performance/md-cache/src/md-cache.c b/xlators/performance/md-cache/src/md-cache.c index d7090475a43..51c07339fdf 100644 --- a/xlators/performance/md-cache/src/md-cache.c +++ b/xlators/performance/md-cache/src/md-cache.c @@ -1764,7 +1764,7 @@ mdc_getxattr_cbk (call_frame_t *frame, void *cookie, xlator_t *this, { mdc_local_t *local = NULL; - if (op_ret != 0) + if (op_ret < 0) goto out; local = frame->local; @@ -1826,7 +1826,7 @@ mdc_fgetxattr_cbk (call_frame_t *frame, void *cookie, xlator_t *this, { mdc_local_t *local = NULL; - if (op_ret != 0) + if (op_ret < 0) goto out; local = frame->local; -- cgit