From 20ef211cfa5b5fcc437484a879fdc5d4c66bbaf5 Mon Sep 17 00:00:00 2001 From: ShyamsundarR Date: Thu, 29 Nov 2018 14:08:06 -0500 Subject: libglusterfs: Move devel headers under glusterfs directory libglusterfs devel package headers are referenced in code using include semantics for a program, this while it works can be better especially when dealing with out of tree xlator builds or in general out of tree devel package usage. Towards this, the following changes are done, - moved all devel headers under a glusterfs directory - Included these headers using system header notation <> in all code outside of libglusterfs - Included these headers using own program notation "" within libglusterfs This change although big, is just moving around the headers and making it correct when including these headers from other sources. This helps us correctly include libglusterfs includes without namespace conflicts. Change-Id: Id2a98854e671a7ee5d73be44da5ba1a74252423b Updates: bz#1193929 Signed-off-by: ShyamsundarR --- xlators/playground/template/src/template.c | 2 +- xlators/playground/template/src/template.h | 14 +++++++------- 2 files changed, 8 insertions(+), 8 deletions(-) (limited to 'xlators/playground') diff --git a/xlators/playground/template/src/template.c b/xlators/playground/template/src/template.c index e96374e0302..2f25d2363a6 100644 --- a/xlators/playground/template/src/template.c +++ b/xlators/playground/template/src/template.c @@ -8,7 +8,7 @@ cases as published by the Free Software Foundation. */ #include "template.h" -#include "statedump.h" +#include static int32_t template_mem_acct_init(xlator_t *this) diff --git a/xlators/playground/template/src/template.h b/xlators/playground/template/src/template.h index 0abe2245296..c53dc1c7010 100644 --- a/xlators/playground/template/src/template.h +++ b/xlators/playground/template/src/template.h @@ -10,11 +10,11 @@ #ifndef __TEMPLATE_H__ #define __TEMPLATE_H__ -#include "glusterfs.h" -#include "logging.h" -#include "dict.h" -#include "xlator.h" -#include "defaults.h" +#include +#include +#include +#include +#include struct template_private { /* Add all the relevant fields you need here */ @@ -24,7 +24,7 @@ struct template_private { typedef struct template_private template_private_t; /* Below section goes to template-mem-types.h */ -#include "mem-types.h" +#include enum gf_template_mem_types_ { gf_template_mt_private_t = gf_common_mt_end + 1, @@ -36,7 +36,7 @@ enum gf_template_mem_types_ { NOTE: make sure you have added your component (in this case, TEMPLATE) in `libglusterfs/src/glfs-message-id.h`. */ -#include "glfs-message-id.h" +#include GLFS_MSGID(TEMPLATE, TEMPLATE_MSG_NO_MEMORY, TEMPLATE_MSG_NO_GRAPH); -- cgit