From 076143f52e47a2a733a02cfb05a7d780553b147d Mon Sep 17 00:00:00 2001 From: "Kaleb S. KEITHLEY" Date: Wed, 25 Mar 2015 10:18:22 -0400 Subject: protocol: Log ENODATA & ENOATTR logs at DEBUG loglevel in removexattr_cbk Prevents messages of the following type from being seen by default in the log files: [2014-09-19 07:57:39.877806] W [client-rpc-fops.c:1232:client3_3_removexattr_cbk] 0--client-0: remote operation failed: No data available [2014-09-19 07:57:39.877963] W [client-rpc-fops.c:1232:client3_3_removexattr_cbk] 0--client-1: remote operation failed: No data available Backport of http://review.gluster.org/#/c/8781/, see BZ 1144527 Change-Id: I814e12c56f5b95fcc24a6f0d46c7240d7abd16e4 BUG: 1205715 Signed-off-by: Kaleb S. KEITHLEY Reviewed-on: http://review.gluster.org/9996 Tested-by: Gluster Build System Reviewed-by: Niels de Vos --- xlators/protocol/client/src/client-rpc-fops.c | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-) (limited to 'xlators/protocol/client/src/client-rpc-fops.c') diff --git a/xlators/protocol/client/src/client-rpc-fops.c b/xlators/protocol/client/src/client-rpc-fops.c index f524c1a373a..053886c428c 100644 --- a/xlators/protocol/client/src/client-rpc-fops.c +++ b/xlators/protocol/client/src/client-rpc-fops.c @@ -1201,8 +1201,9 @@ client3_3_removexattr_cbk (struct rpc_req *req, struct iovec *iov, int count, call_frame_t *frame = NULL; gf_common_rsp rsp = {0,}; int ret = 0; - xlator_t *this = NULL; - dict_t *xdata = NULL; + xlator_t *this = NULL; + dict_t *xdata = NULL; + gf_loglevel_t loglevel = GF_LOG_WARNING; this = THIS; @@ -1228,7 +1229,10 @@ client3_3_removexattr_cbk (struct rpc_req *req, struct iovec *iov, int count, out: if (rsp.op_ret == -1) { - gf_log (this->name, GF_LOG_WARNING, "remote operation failed: %s", + if (ENODATA == rsp.op_errno || ENOATTR == rsp.op_errno) + loglevel = GF_LOG_DEBUG; + + gf_log (this->name, loglevel, "remote operation failed: %s", strerror (gf_error_to_errno (rsp.op_errno))); } -- cgit