From 33b5ce10ef7b5c6db6e73f6070fd4579c2765c94 Mon Sep 17 00:00:00 2001 From: Amar Tumballi Date: Tue, 4 Aug 2009 17:51:58 +0000 Subject: logging related bug fix in server_lookup() When 'dict_unserialize' failed, the log message was trying to print 'state->loc.path' and 'state->ino', which gets filled in later stages in flow. Caused segmentation fault when there was a failure. Signed-off-by: Anand V. Avati BUG: 189 (segfault in server-lookup) URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=189 --- xlators/protocol/server/src/server-protocol.c | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) (limited to 'xlators/protocol/server') diff --git a/xlators/protocol/server/src/server-protocol.c b/xlators/protocol/server/src/server-protocol.c index 00964698b7e..2516756b2c4 100644 --- a/xlators/protocol/server/src/server-protocol.c +++ b/xlators/protocol/server/src/server-protocol.c @@ -3442,10 +3442,9 @@ server_lookup (call_frame_t *frame, xlator_t *bound_xl, &xattr_req); if (ret < 0) { gf_log (bound_xl->name, GF_LOG_ERROR, - "%"PRId64": %s (%"PRId64"): failed to " - "unserialize request buffer to dictionary", - frame->root->unique, state->loc.path, - state->ino); + "%"PRId64": failed to unserialize " + "request buffer to dictionary", + frame->root->unique); free (req_dictbuf); goto fail; } else{ -- cgit