From 0a20e56d07de3e467e09da885a6b71cdc165de17 Mon Sep 17 00:00:00 2001 From: Mohammed Rafi KC Date: Mon, 29 May 2017 16:00:24 +0530 Subject: protocol/server: make listen backlog value as configurable problem: When we call listen from protocol/server, we are giving a hard coded valie of 10 if it is not manually given. With multiplexing, especially when glusterd restarts all clients may try to connect to the server at a time. Which will result in overflowing the queue, and kernel will complain about the errors. Solution: This patch will introduce a volume set command to make backlog value as a configurable. This patch also changes the default values for backlog from 10 to 128. This changes is only applicable for sockets listening from protocol. Example: gluster volume set transport.listen-backlog 1024 Note: 1 Brick has to be restarted to get this value in effect 2 This changes won't be reflected in glusterd, or other xlators which calls listen. If you need, you have to add this option to the volfile. Change-Id: I0c5a2bbf28b5db612f9979e7560e05dd82b41477 BUG: 1456405 Signed-off-by: Mohammed Rafi KC Reviewed-on: https://review.gluster.org/17411 Smoke: Gluster Build System NetBSD-regression: NetBSD Build System CentOS-regression: Gluster Build System Reviewed-by: Raghavendra G Reviewed-by: Raghavendra Talur Reviewed-by: Atin Mukherjee Reviewed-by: Niels de Vos Reviewed-by: Jeff Darcy --- xlators/protocol/server/src/server.c | 4 ++++ 1 file changed, 4 insertions(+) (limited to 'xlators/protocol') diff --git a/xlators/protocol/server/src/server.c b/xlators/protocol/server/src/server.c index 130a55372a6..4d89fe89b2c 100644 --- a/xlators/protocol/server/src/server.c +++ b/xlators/protocol/server/src/server.c @@ -1606,6 +1606,10 @@ struct volume_options options[] = { "socket*([ \t]),*([ \t])rdma"}, .type = GF_OPTION_TYPE_STR }, + { .key = {"transport.listen-backlog"}, + .type = GF_OPTION_TYPE_INT, + .default_value = "10", + }, { .key = {"volume-filename.*"}, .type = GF_OPTION_TYPE_PATH, }, -- cgit