From 04582fa313a4782d7898afb56a0747a5dcca3a92 Mon Sep 17 00:00:00 2001 From: Michael Scherer Date: Wed, 22 Feb 2017 16:31:30 +0100 Subject: Remove unused conditionnal The code is using a got to jump 1 line further, which is a no-op. Found by coverty scan Change-Id: Ic8698e2f86ebd9472b3104b09920ab7946c3b4fc BUG: 789278 Signed-off-by: Michael Scherer Reviewed-on: https://review.gluster.org/16714 Smoke: Gluster Build System Reviewed-by: Shyamsundar Ranganathan Tested-by: Michael Scherer NetBSD-regression: NetBSD Build System CentOS-regression: Gluster Build System --- xlators/system/posix-acl/src/posix-acl.c | 15 --------------- 1 file changed, 15 deletions(-) (limited to 'xlators/system') diff --git a/xlators/system/posix-acl/src/posix-acl.c b/xlators/system/posix-acl/src/posix-acl.c index dbe0e716e2b..5883bcbf050 100644 --- a/xlators/system/posix-acl/src/posix-acl.c +++ b/xlators/system/posix-acl/src/posix-acl.c @@ -1534,9 +1534,6 @@ posix_acl_unlink_cbk (call_frame_t *frame, void *cookie, xlator_t *this, int op_ret, int op_errno, struct iatt *preparent, struct iatt *postparent, dict_t *xdata) { - if (op_ret != 0) - goto unwind; -unwind: STACK_UNWIND_STRICT (unlink, frame, op_ret, op_errno, preparent, postparent, xdata); return 0; @@ -1570,9 +1567,6 @@ posix_acl_rmdir_cbk (call_frame_t *frame, void *cookie, xlator_t *this, int op_ret, int op_errno, struct iatt *preparent, struct iatt *postparent, dict_t *xdata) { - if (op_ret != 0) - goto unwind; -unwind: STACK_UNWIND_STRICT (rmdir, frame, op_ret, op_errno, preparent, postparent, xdata); return 0; @@ -1607,9 +1601,6 @@ posix_acl_rename_cbk (call_frame_t *frame, void *cookie, xlator_t *this, struct iatt *prenewparent, struct iatt *postnewparent, dict_t *xdata) { - if (op_ret != 0) - goto unwind; -unwind: STACK_UNWIND_STRICT (rename, frame, op_ret, op_errno, buf, preoldparent, postoldparent, prenewparent, postnewparent, xdata); @@ -1650,9 +1641,6 @@ posix_acl_link_cbk (call_frame_t *frame, void *cookie, xlator_t *this, int op_ret, int op_errno, inode_t *inode, struct iatt *buf, struct iatt *preparent, struct iatt *postparent, dict_t *xdata) { - if (op_ret != 0) - goto unwind; -unwind: STACK_UNWIND_STRICT (link, frame, op_ret, op_errno, inode, buf, preparent, postparent, xdata); return 0; @@ -1698,9 +1686,6 @@ posix_acl_readdir_cbk (call_frame_t *frame, void *cookie, xlator_t *this, int op_ret, int op_errno, gf_dirent_t *entries, dict_t *xdata) { - if (op_ret != 0) - goto unwind; -unwind: STACK_UNWIND_STRICT (readdir, frame, op_ret, op_errno, entries, xdata); return 0; } -- cgit