From 01e42f25ebdc44847e8b1dce02f7fd486b40dbc2 Mon Sep 17 00:00:00 2001 From: Raghavendra Bhat Date: Tue, 23 Jun 2015 00:25:38 +0530 Subject: Revert "quota/marker: fix mem-leak, free contribution node" This reverts commit 8ab6608accb62d6320d1fc1fbe651fcafd376270. This patch is resulting in memory corruption: http://build.gluster.org/job/rackspace-regression-2GB-triggered/11193/consoleFull contribution object might be being used by some other transaction when we free it. The correct way to handle this is to have a reference based scheme to manage the contribution object. Change-Id: Idf9993ed8268029073a3e2d699865587f20d9aea BUG: 1207735 Signed-off-by: Raghavendra Bhat Reviewed-on: http://review.gluster.org/11362 Reviewed-by: Raghavendra G Tested-by: Raghavendra G --- xlators/features/marker/src/marker-quota.c | 2 -- 1 file changed, 2 deletions(-) (limited to 'xlators') diff --git a/xlators/features/marker/src/marker-quota.c b/xlators/features/marker/src/marker-quota.c index 7c67ec6dc7c..c33d8a46707 100644 --- a/xlators/features/marker/src/marker-quota.c +++ b/xlators/features/marker/src/marker-quota.c @@ -2606,8 +2606,6 @@ mq_remove_contri (xlator_t *this, loc_t *loc, inode_contribution_t *contri) } UNLOCK (&contri->lock); - QUOTA_FREE_CONTRIBUTION_NODE (contri); - ret = 0; out: -- cgit