From 1534a696daf25ddea67bd2bc8e2ba1993eb366c6 Mon Sep 17 00:00:00 2001 From: Pavan Sondur Date: Wed, 7 Oct 2009 13:12:36 +0000 Subject: Initialize local before any call to STACK_WIND to prevent a crash Signed-off-by: Anand V. Avati BUG: 304 (Write behind crashes when a chmod is issued) URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=304 --- xlators/performance/write-behind/src/write-behind.c | 19 ++++++++++--------- 1 file changed, 10 insertions(+), 9 deletions(-) (limited to 'xlators') diff --git a/xlators/performance/write-behind/src/write-behind.c b/xlators/performance/write-behind/src/write-behind.c index 0d449b4ac1e..47ed2ecf4aa 100644 --- a/xlators/performance/write-behind/src/write-behind.c +++ b/xlators/performance/write-behind/src/write-behind.c @@ -1124,6 +1124,16 @@ wb_setattr (call_frame_t *frame, xlator_t *this, loc_t *loc, wb_request_t *request = NULL; int32_t ret = -1, op_errno = EINVAL; + local = CALLOC (1, sizeof (*local)); + if (local == NULL) { + op_errno = ENOMEM; + goto unwind; + } + + local->file = file; + + frame->local = local; + if (!(valid & (GF_SET_ATTR_ATIME | GF_SET_ATTR_MTIME))) { STACK_WIND (frame, wb_setattr_cbk, @@ -1149,15 +1159,6 @@ wb_setattr (call_frame_t *frame, xlator_t *this, loc_t *loc, } - local = CALLOC (1, sizeof (*local)); - if (local == NULL) { - op_errno = ENOMEM; - goto unwind; - } - - local->file = file; - - frame->local = local; if (file) { stub = fop_setattr_stub (frame, wb_setattr_helper, loc, stbuf, valid); -- cgit