From b6693de93a6f430bae4bfa9f4e58cf061664249b Mon Sep 17 00:00:00 2001
From: Saravanakumar Arumugam <sarumuga@redhat.com>
Date: Wed, 25 Feb 2015 11:43:14 +0530
Subject: glusterd/snapshot: Fix memory leak while using scandir

scandir allocates memory for dirent entries.
Ensure to free them up once they are used.

Noticed this while looking for a sample scandir implementation.

Change-Id: Iff5f76e93e698d3f454f273d9dd7d9a15cf63953
BUG: 1218562
Signed-off-by: Saravanakumar Arumugam <sarumuga@redhat.com>
Reviewed-on: http://review.gluster.org/9739
Reviewed-by: Sachin Pandit <spandit@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Rajesh Joseph <rjoseph@redhat.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
Reviewed-on: http://review.gluster.org/10559
Reviewed-by: Avra Sengupta <asengupt@redhat.com>
Tested-by: NetBSD Build System
---
 xlators/mgmt/glusterd/src/glusterd-snapshot.c | 8 ++++++++
 1 file changed, 8 insertions(+)

(limited to 'xlators')

diff --git a/xlators/mgmt/glusterd/src/glusterd-snapshot.c b/xlators/mgmt/glusterd/src/glusterd-snapshot.c
index dbb9e934839..fec7494c341 100644
--- a/xlators/mgmt/glusterd/src/glusterd-snapshot.c
+++ b/xlators/mgmt/glusterd/src/glusterd-snapshot.c
@@ -567,6 +567,14 @@ glusterd_copy_geo_rep_session_files (char *session,
                 }
         }
 out:
+        /* files are malloc'd by scandir, free them */
+        if (file_count > 0) {
+                while (file_count--) {
+                        free(files[file_count]);
+                }
+                free(files);
+        }
+
         if (reg_exp)
                 GF_FREE (reg_exp);
 
-- 
cgit