From d84242276b2f8ee7151c7784992dffb651816ccf Mon Sep 17 00:00:00 2001 From: Avra Sengupta Date: Mon, 9 Nov 2015 13:37:53 +0530 Subject: snapshot/clone : Fix tier pause failure for snapshot clone Backport of http://review.gluster.org/#/c/12548 On a tiered volume, snapshot clone fails while trying to pause tier, as we pass volname(snap) to the brick_op_phase module, which tries to look for the snap volume amongst regular volumes, and obviously doesn't find it and fail. Well as snapshot volumes are read only volume, and will not have tiering daemon acting upon them, there is really no need to pause tiereing while taking clone of snapshot volumes. Hence removing the code to pause and resume tiering during clone create. Change-Id: I2266aba589a830a13a806c0d8a56fd8855143ccd BUG: 1287538 Signed-off-by: Avra Sengupta Reviewed-on: http://review.gluster.org/12846 Tested-by: NetBSD Build System Tested-by: Gluster Build System Reviewed-by: Rajesh Joseph --- xlators/mgmt/glusterd/src/glusterd-snapshot.c | 13 ------------- 1 file changed, 13 deletions(-) (limited to 'xlators') diff --git a/xlators/mgmt/glusterd/src/glusterd-snapshot.c b/xlators/mgmt/glusterd/src/glusterd-snapshot.c index ba645a31d3c..2549afc3324 100644 --- a/xlators/mgmt/glusterd/src/glusterd-snapshot.c +++ b/xlators/mgmt/glusterd/src/glusterd-snapshot.c @@ -2390,12 +2390,6 @@ glusterd_snapshot_clone_prevalidate (dict_t *dict, char **op_errstr, goto out; } - ret = glusterd_snapshot_pause_tier (this, snap_vol); - if (ret) { - gf_msg (this->name, GF_LOG_ERROR, 0, - GD_MSG_SNAP_PAUSE_TIER_FAIL, - "Failed to pause tier in clone prevalidate."); - } out: if (ret && err_str[0] != '\0') { @@ -7983,13 +7977,6 @@ glusterd_snapshot_clone_postvalidate (dict_t *dict, int32_t op_ret, } snap_vol->snapshot = NULL; - ret = glusterd_snapshot_resume_tier (this, dict); - if (ret) { - gf_msg (this->name, GF_LOG_ERROR, 0, - GD_MSG_SNAP_RESUME_TIER_FAIL, - "Failed to resume tier in clone postvalidate."); - } - out: return ret; } -- cgit