1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
699
700
701
702
703
704
705
706
707
708
709
710
711
712
713
714
715
716
717
718
719
720
721
722
723
724
725
726
727
728
729
730
731
732
733
734
735
736
737
738
739
740
741
742
743
744
745
746
747
748
749
750
751
752
753
754
755
756
757
758
759
760
761
762
763
764
765
766
767
768
769
770
771
772
773
774
|
[1mdiff --git a/setup.py b/setup.py[m
[1mindex d195d34..b5b5ca2 100644[m
[1m--- a/setup.py[m
[1m+++ b/setup.py[m
[36m@@ -1,5 +1,6 @@[m
#!/usr/bin/python[m
# Copyright (c) 2010-2012 OpenStack, LLC.[m
[32m+[m[32m# Copyright (c) 2011 Red Hat, Inc.[m
#[m
# Licensed under the Apache License, Version 2.0 (the "License");[m
# you may not use this file except in compliance with the License.[m
[36m@@ -94,6 +95,7 @@[m [msetup([m
'tempurl=swift.common.middleware.tempurl:filter_factory',[m
'formpost=swift.common.middleware.formpost:filter_factory',[m
'name_check=swift.common.middleware.name_check:filter_factory',[m
[32m+[m[32m 'gluster=swift.common.middleware.gluster:filter_factory',[m
],[m
},[m
)[m
[1mdiff --git a/swift/account/server.py b/swift/account/server.py[m
[1mindex 800b3c0..99f5de3 100644[m
[1m--- a/swift/account/server.py[m
[1m+++ b/swift/account/server.py[m
[36m@@ -1,4 +1,5 @@[m
# Copyright (c) 2010-2012 OpenStack, LLC.[m
[32m+[m[32m# Copyright (c) 2011 Red Hat, Inc.[m
#[m
# Licensed under the Apache License, Version 2.0 (the "License");[m
# you may not use this file except in compliance with the License.[m
[36m@@ -31,7 +32,7 @@[m [mimport simplejson[m
[m
from swift.common.db import AccountBroker[m
from swift.common.utils import get_logger, get_param, hash_path, \[m
[31m- normalize_timestamp, split_path, storage_directory[m
[32m+[m[32m normalize_timestamp, split_path, storage_directory, plugin_enabled[m
from swift.common.constraints import ACCOUNT_LISTING_LIMIT, \[m
check_mount, check_float, check_utf8[m
from swift.common.db_replicator import ReplicatorRpc[m
[36m@@ -39,6 +40,8 @@[m [mfrom swift.common.db_replicator import ReplicatorRpc[m
[m
DATADIR = 'accounts'[m
[m
[32m+[m[32mif plugin_enabled():[m
[32m+[m[32m from swift.plugins.DiskDir import DiskAccount[m
[m
class AccountController(object):[m
"""WSGI controller for the account server."""[m
[36m@@ -52,8 +55,12 @@[m [mclass AccountController(object):[m
self.mount_check, logger=self.logger)[m
self.auto_create_account_prefix = \[m
conf.get('auto_create_account_prefix') or '.'[m
[32m+[m[32m self.fs_object = None[m
[m
def _get_account_broker(self, drive, part, account):[m
[32m+[m[32m if self.fs_object:[m
[32m+[m[32m return DiskAccount(self.root, account, self.fs_object);[m
[32m+[m
hsh = hash_path(account)[m
db_dir = storage_directory(DATADIR, part, hsh)[m
db_path = os.path.join(self.root, drive, db_dir, hsh + '.db')[m
[36m@@ -121,9 +128,15 @@[m [mclass AccountController(object):[m
if broker.is_deleted():[m
return HTTPConflict(request=req)[m
metadata = {}[m
[31m- metadata.update((key, (value, timestamp))[m
[31m- for key, value in req.headers.iteritems()[m
[31m- if key.lower().startswith('x-account-meta-'))[m
[32m+[m[32m if not self.fs_object:[m
[32m+[m[32m metadata.update((key, (value, timestamp))[m
[32m+[m[32m for key, value in req.headers.iteritems()[m
[32m+[m[32m if key.lower().startswith('x-account-meta-'))[m
[32m+[m[32m else:[m
[32m+[m[32m metadata.update((key, value)[m
[32m+[m[32m for key, value in req.headers.iteritems()[m
[32m+[m[32m if key.lower().startswith('x-account-meta-'))[m
[32m+[m
if metadata:[m
broker.update_metadata(metadata)[m
if created:[m
[36m@@ -153,6 +166,9 @@[m [mclass AccountController(object):[m
broker.stale_reads_ok = True[m
if broker.is_deleted():[m
return HTTPNotFound(request=req)[m
[32m+[m[32m if self.fs_object:[m
[32m+[m[32m broker.list_containers_iter(None, None,None,[m
[32m+[m[32m None, None)[m
info = broker.get_info()[m
headers = {[m
'X-Account-Container-Count': info['container_count'],[m
[36m@@ -164,9 +180,16 @@[m [mclass AccountController(object):[m
container_ts = broker.get_container_timestamp(container)[m
if container_ts is not None:[m
headers['X-Container-Timestamp'] = container_ts[m
[31m- headers.update((key, value)[m
[31m- for key, (value, timestamp) in broker.metadata.iteritems()[m
[31m- if value != '')[m
[32m+[m[32m if not self.fs_object:[m
[32m+[m[32m headers.update((key, value)[m
[32m+[m[32m for key, (value, timestamp) in broker.metadata.iteritems()[m
[32m+[m[32m if value != '')[m
[32m+[m[32m else:[m
[32m+[m[32m headers.update((key, value)[m
[32m+[m[32m for key, value in broker.metadata.iteritems()[m
[32m+[m[32m if value != '')[m
[32m+[m
[32m+[m
return HTTPNoContent(request=req, headers=headers)[m
[m
def GET(self, req):[m
[36m@@ -190,9 +213,15 @@[m [mclass AccountController(object):[m
'X-Account-Bytes-Used': info['bytes_used'],[m
'X-Timestamp': info['created_at'],[m
'X-PUT-Timestamp': info['put_timestamp']}[m
[31m- resp_headers.update((key, value)[m
[31m- for key, (value, timestamp) in broker.metadata.iteritems()[m
[31m- if value != '')[m
[32m+[m[32m if not self.fs_object:[m
[32m+[m[32m resp_headers.update((key, value)[m
[32m+[m[32m for key, (value, timestamp) in broker.metadata.iteritems()[m
[32m+[m[32m if value != '')[m
[32m+[m[32m else:[m
[32m+[m[32m resp_headers.update((key, value)[m
[32m+[m[32m for key, value in broker.metadata.iteritems()[m
[32m+[m[32m if value != '')[m
[32m+[m
try:[m
prefix = get_param(req, 'prefix')[m
delimiter = get_param(req, 'delimiter')[m
[36m@@ -224,6 +253,7 @@[m [mclass AccountController(object):[m
content_type='text/plain', request=req)[m
account_list = broker.list_containers_iter(limit, marker, end_marker,[m
prefix, delimiter)[m
[32m+[m
if out_content_type == 'application/json':[m
json_pattern = ['"name":%s', '"count":%s', '"bytes":%s'][m
json_pattern = '{' + ','.join(json_pattern) + '}'[m
[36m@@ -298,15 +328,29 @@[m [mclass AccountController(object):[m
return HTTPNotFound(request=req)[m
timestamp = normalize_timestamp(req.headers['x-timestamp'])[m
metadata = {}[m
[31m- metadata.update((key, (value, timestamp))[m
[31m- for key, value in req.headers.iteritems()[m
[31m- if key.lower().startswith('x-account-meta-'))[m
[32m+[m[32m if not self.fs_object:[m
[32m+[m[32m metadata.update((key, (value, timestamp))[m
[32m+[m[32m for key, value in req.headers.iteritems()[m
[32m+[m[32m if key.lower().startswith('x-account-meta-'))[m
[32m+[m[32m else:[m
[32m+[m[32m metadata.update((key, value)[m
[32m+[m[32m for key, value in req.headers.iteritems()[m
[32m+[m[32m if key.lower().startswith('x-account-meta-'))[m
if metadata:[m
broker.update_metadata(metadata)[m
return HTTPNoContent(request=req)[m
[m
[32m+[m[32m def plugin(self, env):[m
[32m+[m[32m if env.get('Gluster_enabled', False):[m
[32m+[m[32m self.fs_object = env.get('fs_object')[m
[32m+[m[32m self.root = env.get('root')[m
[32m+[m[32m self.mount_check = False[m
[32m+[m[32m else:[m
[32m+[m[32m self.fs_object = None[m
[32m+[m
def __call__(self, env, start_response):[m
start_time = time.time()[m
[32m+[m[32m self.plugin(env)[m
req = Request(env)[m
self.logger.txn_id = req.headers.get('x-trans-id', None)[m
if not check_utf8(req.path_info):[m
[1mdiff --git a/swift/common/middleware/gluster.py b/swift/common/middleware/gluster.py[m
[1mnew file mode 100644[m
[1mindex 0000000..341285d[m
[1m--- /dev/null[m
[1m+++ b/swift/common/middleware/gluster.py[m
[36m@@ -0,0 +1,55 @@[m
[32m+[m[32m# Copyright (c) 2011 Red Hat, Inc.[m
[32m+[m[32m#[m
[32m+[m[32m# Licensed under the Apache License, Version 2.0 (the "License");[m
[32m+[m[32m# you may not use this file except in compliance with the License.[m
[32m+[m[32m# You may obtain a copy of the License at[m
[32m+[m[32m#[m
[32m+[m[32m# http://www.apache.org/licenses/LICENSE-2.0[m
[32m+[m[32m#[m
[32m+[m[32m# Unless required by applicable law or agreed to in writing, software[m
[32m+[m[32m# distributed under the License is distributed on an "AS IS" BASIS,[m
[32m+[m[32m# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or[m
[32m+[m[32m# implied.[m
[32m+[m[32m# See the License for the specific language governing permissions and[m
[32m+[m[32m# limitations under the License.[m
[32m+[m
[32m+[m[32mfrom swift.common.utils import get_logger, plugin_enabled[m
[32m+[m[32mfrom swift import plugins[m
[32m+[m[32mfrom ConfigParser import ConfigParser[m
[32m+[m
[32m+[m[32mclass Gluster_plugin(object):[m
[32m+[m[32m """[m
[32m+[m[32m Update the environment with keys that reflect Gluster_plugin enabled[m
[32m+[m[32m """[m
[32m+[m
[32m+[m[32m def __init__(self, app, conf):[m
[32m+[m[32m self.app = app[m
[32m+[m[32m self.conf = conf[m
[32m+[m[32m self.fs_name = 'Glusterfs'[m
[32m+[m[32m self.logger = get_logger(conf, log_route='gluster')[m
[32m+[m
[32m+[m[32m def __call__(self, env, start_response):[m
[32m+[m[32m if not plugin_enabled():[m
[32m+[m[32m return self.app(env, start_response)[m
[32m+[m[32m env['Gluster_enabled'] =True[m
[32m+[m[32m fs_object = getattr(plugins, self.fs_name, False)[m
[32m+[m[32m if not fs_object:[m
[32m+[m[32m raise Exception('%s plugin not found', self.fs_name)[m
[32m+[m
[32m+[m[32m env['fs_object'] = fs_object()[m
[32m+[m[32m fs_conf = ConfigParser()[m
[32m+[m[32m if fs_conf.read('/etc/swift/fs.conf'):[m
[32m+[m[32m try:[m
[32m+[m[32m env['root'] = fs_conf.get ('DEFAULT', 'mount_path')[m
[32m+[m[32m except NoSectionError, NoOptionError:[m
[32m+[m[32m self.logger.exception(_('ERROR mount_path not present'))[m
[32m+[m[32m return self.app(env, start_response)[m
[32m+[m
[32m+[m[32mdef filter_factory(global_conf, **local_conf):[m
[32m+[m[32m """Returns a WSGI filter app for use with paste.deploy."""[m
[32m+[m[32m conf = global_conf.copy()[m
[32m+[m[32m conf.update(local_conf)[m
[32m+[m
[32m+[m[32m def gluster_filter(app):[m
[32m+[m[32m return Gluster_plugin(app, conf)[m
[32m+[m[32m return gluster_filter[m
[1mdiff --git a/swift/common/utils.py b/swift/common/utils.py[m
[1mindex 47edce8..afc356c 100644[m
[1m--- a/swift/common/utils.py[m
[1m+++ b/swift/common/utils.py[m
[36m@@ -1,4 +1,5 @@[m
# Copyright (c) 2010-2012 OpenStack, LLC.[m
[32m+[m[32m# Copyright (c) 2011 Red Hat, Inc.[m
#[m
# Licensed under the Apache License, Version 2.0 (the "License");[m
# you may not use this file except in compliance with the License.[m
[36m@@ -1138,3 +1139,12 @@[m [mdef streq_const_time(s1, s2):[m
for (a, b) in zip(s1, s2):[m
result |= ord(a) ^ ord(b)[m
return result == 0[m
[32m+[m
[32m+[m[32mdef plugin_enabled():[m
[32m+[m[32m swift_conf = ConfigParser()[m
[32m+[m[32m swift_conf.read(os.path.join('/etc/swift', 'swift.conf'))[m
[32m+[m[32m try:[m
[32m+[m[32m return swift_conf.get('DEFAULT', 'Enable_plugin', 'no') in TRUE_VALUES[m
[32m+[m[32m except NoOptionError, NoSectionError:[m
[32m+[m[32m return False[m
[41m+[m
[1mdiff --git a/swift/container/server.py b/swift/container/server.py[m
[1mindex 8a18cfd..741c81a 100644[m
[1m--- a/swift/container/server.py[m
[1m+++ b/swift/container/server.py[m
[36m@@ -1,4 +1,5 @@[m
# Copyright (c) 2010-2012 OpenStack, LLC.[m
[32m+[m[32m# Copyright (c) 2011 Red Hat, Inc.[m
#[m
# Licensed under the Apache License, Version 2.0 (the "License");[m
# you may not use this file except in compliance with the License.[m
[36m@@ -31,7 +32,8 @@[m [mfrom webob.exc import HTTPAccepted, HTTPBadRequest, HTTPConflict, \[m
[m
from swift.common.db import ContainerBroker[m
from swift.common.utils import get_logger, get_param, hash_path, \[m
[31m- normalize_timestamp, storage_directory, split_path, validate_sync_to[m
[32m+[m[32m normalize_timestamp, storage_directory, split_path, validate_sync_to, \[m
[32m+[m[32m plugin_enabled[m
from swift.common.constraints import CONTAINER_LISTING_LIMIT, \[m
check_mount, check_float, check_utf8[m
from swift.common.bufferedhttp import http_connect[m
[36m@@ -40,6 +42,9 @@[m [mfrom swift.common.db_replicator import ReplicatorRpc[m
[m
DATADIR = 'containers'[m
[m
[32m+[m[32mif plugin_enabled():[m
[32m+[m[32m from swift.plugins.DiskDir import DiskDir[m
[32m+[m
[m
class ContainerController(object):[m
"""WSGI Controller for the container server."""[m
[36m@@ -62,6 +67,7 @@[m [mclass ContainerController(object):[m
ContainerBroker, self.mount_check, logger=self.logger)[m
self.auto_create_account_prefix = \[m
conf.get('auto_create_account_prefix') or '.'[m
[32m+[m[32m self.fs_object = None[m
[m
def _get_container_broker(self, drive, part, account, container):[m
"""[m
[36m@@ -73,6 +79,11 @@[m [mclass ContainerController(object):[m
:param container: container name[m
:returns: ContainerBroker object[m
"""[m
[32m+[m[32m if self.fs_object:[m
[32m+[m[32m return DiskDir(self.root, drive, part, account,[m
[32m+[m[32m container, self.logger,[m
[32m+[m[32m fs_object = self.fs_object)[m
[32m+[m
hsh = hash_path(account, container)[m
db_dir = storage_directory(DATADIR, part, hsh)[m
db_path = os.path.join(self.root, drive, db_dir, hsh + '.db')[m
[36m@@ -211,10 +222,18 @@[m [mclass ContainerController(object):[m
if broker.is_deleted():[m
return HTTPConflict(request=req)[m
metadata = {}[m
[31m- metadata.update((key, (value, timestamp))[m
[31m- for key, value in req.headers.iteritems()[m
[31m- if key.lower() in self.save_headers or[m
[31m- key.lower().startswith('x-container-meta-'))[m
[32m+[m[32m #Note: check the structure of req.headers[m
[32m+[m[32m if not self.fs_object:[m
[32m+[m[32m metadata.update((key, (value, timestamp))[m
[32m+[m[32m for key, value in req.headers.iteritems()[m
[32m+[m[32m if key.lower() in self.save_headers or[m
[32m+[m[32m key.lower().startswith('x-container-meta-'))[m
[32m+[m[32m else:[m
[32m+[m[32m metadata.update((key, value)[m
[32m+[m[32m for key, value in req.headers.iteritems()[m
[32m+[m[32m if key.lower() in self.save_headers or[m
[32m+[m[32m key.lower().startswith('x-container-meta-'))[m
[32m+[m
if metadata:[m
if 'X-Container-Sync-To' in metadata:[m
if 'X-Container-Sync-To' not in broker.metadata or \[m
[36m@@ -222,6 +241,7 @@[m [mclass ContainerController(object):[m
broker.metadata['X-Container-Sync-To'][0]:[m
broker.set_x_container_sync_points(-1, -1)[m
broker.update_metadata(metadata)[m
[32m+[m
resp = self.account_update(req, account, container, broker)[m
if resp:[m
return resp[m
[36m@@ -252,10 +272,17 @@[m [mclass ContainerController(object):[m
'X-Timestamp': info['created_at'],[m
'X-PUT-Timestamp': info['put_timestamp'],[m
}[m
[31m- headers.update((key, value)[m
[31m- for key, (value, timestamp) in broker.metadata.iteritems()[m
[31m- if value != '' and (key.lower() in self.save_headers or[m
[31m- key.lower().startswith('x-container-meta-')))[m
[32m+[m[32m if not self.fs_object:[m
[32m+[m[32m headers.update((key, value)[m
[32m+[m[32m for key, (value, timestamp) in broker.metadata.iteritems()[m
[32m+[m[32m if value != '' and (key.lower() in self.save_headers or[m
[32m+[m[32m key.lower().startswith('x-container-meta-')))[m
[32m+[m[32m else:[m
[32m+[m[32m headers.update((key, value)[m
[32m+[m[32m for key, value in broker.metadata.iteritems()[m
[32m+[m[32m if value != '' and (key.lower() in self.save_headers or[m
[32m+[m[32m key.lower().startswith('x-container-meta-')))[m
[32m+[m
return HTTPNoContent(request=req, headers=headers)[m
[m
def GET(self, req):[m
[36m@@ -268,6 +295,7 @@[m [mclass ContainerController(object):[m
request=req)[m
if self.mount_check and not check_mount(self.root, drive):[m
return Response(status='507 %s is not mounted' % drive)[m
[32m+[m
broker = self._get_container_broker(drive, part, account, container)[m
broker.pending_timeout = 0.1[m
broker.stale_reads_ok = True[m
[36m@@ -280,10 +308,17 @@[m [mclass ContainerController(object):[m
'X-Timestamp': info['created_at'],[m
'X-PUT-Timestamp': info['put_timestamp'],[m
}[m
[31m- resp_headers.update((key, value)[m
[31m- for key, (value, timestamp) in broker.metadata.iteritems()[m
[31m- if value != '' and (key.lower() in self.save_headers or[m
[31m- key.lower().startswith('x-container-meta-')))[m
[32m+[m[32m if not self.fs_object:[m
[32m+[m[32m resp_headers.update((key, value)[m
[32m+[m[32m for key, (value, timestamp) in broker.metadata.iteritems()[m
[32m+[m[32m if value != '' and (key.lower() in self.save_headers or[m
[32m+[m[32m key.lower().startswith('x-container-meta-')))[m
[32m+[m[32m else:[m
[32m+[m[32m resp_headers.update((key, value)[m
[32m+[m[32m for key, value in broker.metadata.iteritems()[m
[32m+[m[32m if value != '' and (key.lower() in self.save_headers or[m
[32m+[m[32m key.lower().startswith('x-container-meta-')))[m
[32m+[m
try:[m
path = get_param(req, 'path')[m
prefix = get_param(req, 'prefix')[m
[36m@@ -414,10 +449,17 @@[m [mclass ContainerController(object):[m
return HTTPNotFound(request=req)[m
timestamp = normalize_timestamp(req.headers['x-timestamp'])[m
metadata = {}[m
[31m- metadata.update((key, (value, timestamp))[m
[31m- for key, value in req.headers.iteritems()[m
[31m- if key.lower() in self.save_headers or[m
[31m- key.lower().startswith('x-container-meta-'))[m
[32m+[m[32m if not self.fs_object:[m
[32m+[m[32m metadata.update((key, (value, timestamp))[m
[32m+[m[32m for key, value in req.headers.iteritems()[m
[32m+[m[32m if key.lower() in self.save_headers or[m
[32m+[m[32m key.lower().startswith('x-container-meta-'))[m
[32m+[m[32m else:[m
[32m+[m[32m metadata.update((key, value)[m
[32m+[m[32m for key, value in req.headers.iteritems()[m
[32m+[m[32m if key.lower() in self.save_headers or[m
[32m+[m[32m key.lower().startswith('x-container-meta-'))[m
[32m+[m
if metadata:[m
if 'X-Container-Sync-To' in metadata:[m
if 'X-Container-Sync-To' not in broker.metadata or \[m
[36m@@ -427,8 +469,19 @@[m [mclass ContainerController(object):[m
broker.update_metadata(metadata)[m
return HTTPNoContent(request=req)[m
[m
[32m+[m[32m def plugin(self, env):[m
[32m+[m[32m if env.get('Gluster_enabled', False):[m
[32m+[m[32m self.fs_object = env.get('fs_object')[m
[32m+[m[32m if not self.fs_object:[m
[32m+[m[32m raise NoneTypeError[m
[32m+[m[32m self.root = env.get('root')[m
[32m+[m[32m self.mount_check = False[m
[32m+[m[32m else:[m
[32m+[m[32m self.fs_object = None[m
[32m+[m
def __call__(self, env, start_response):[m
start_time = time.time()[m
[32m+[m[32m self.plugin(env)[m
req = Request(env)[m
self.logger.txn_id = req.headers.get('x-trans-id', None)[m
if not check_utf8(req.path_info):[m
[1mdiff --git a/swift/obj/server.py b/swift/obj/server.py[m
[1mindex 9cca16b..37730ff 100644[m
[1m--- a/swift/obj/server.py[m
[1m+++ b/swift/obj/server.py[m
[36m@@ -1,4 +1,5 @@[m
# Copyright (c) 2010-2012 OpenStack, LLC.[m
[32m+[m[32m# Copyright (c) 2011 Red Hat, Inc.[m
#[m
# Licensed under the Apache License, Version 2.0 (the "License");[m
# you may not use this file except in compliance with the License.[m
[36m@@ -26,6 +27,7 @@[m [mfrom hashlib import md5[m
from tempfile import mkstemp[m
from urllib import unquote[m
from contextlib import contextmanager[m
[32m+[m[32mfrom ConfigParser import ConfigParser[m
[m
from webob import Request, Response, UTC[m
from webob.exc import HTTPAccepted, HTTPBadRequest, HTTPCreated, \[m
[36m@@ -37,16 +39,23 @@[m [mfrom eventlet import sleep, Timeout, tpool[m
[m
from swift.common.utils import mkdirs, normalize_timestamp, \[m
storage_directory, hash_path, renamer, fallocate, \[m
[31m- split_path, drop_buffer_cache, get_logger, write_pickle[m
[32m+[m[32m split_path, drop_buffer_cache, get_logger, write_pickle, \[m
[32m+[m[32m plugin_enabled[m
from swift.common.bufferedhttp import http_connect[m
[31m-from swift.common.constraints import check_object_creation, check_mount, \[m
[31m- check_float, check_utf8[m
[32m+[m[32mif plugin_enabled():[m
[32m+[m[32m from swift.plugins.constraints import check_object_creation[m
[32m+[m[32m from swift.plugins.utils import X_TYPE, X_OBJECT_TYPE, FILE, DIR, MARKER_DIR, \[m
[32m+[m[32m OBJECT, DIR_TYPE, FILE_TYPE[m
[32m+[m[32melse:[m
[32m+[m[32m from swift.common.constraints import check_object_creation[m
[32m+[m
[32m+[m[32mfrom swift.common.constraints import check_mount, check_float, check_utf8[m
[32m+[m
from swift.common.exceptions import ConnectionTimeout, DiskFileError, \[m
DiskFileNotExist[m
from swift.obj.replicator import tpooled_get_hashes, invalidate_hash, \[m
quarantine_renamer[m
[m
[31m-[m
DATADIR = 'objects'[m
ASYNCDIR = 'async_pending'[m
PICKLE_PROTOCOL = 2[m
[36m@@ -339,6 +348,9 @@[m [mclass DiskFile(object):[m
raise[m
raise DiskFileNotExist('Data File does not exist.')[m
[m
[32m+[m[32mif plugin_enabled():[m
[32m+[m[32m from swift.plugins.DiskFile import Gluster_DiskFile[m
[32m+[m
[m
class ObjectController(object):[m
"""Implements the WSGI application for the Swift Object Server."""[m
[36m@@ -377,6 +389,17 @@[m [mclass ObjectController(object):[m
'expiring_objects'[m
self.expiring_objects_container_divisor = \[m
int(conf.get('expiring_objects_container_divisor') or 86400)[m
[32m+[m[32m self.fs_object = None[m
[32m+[m
[32m+[m[32m def get_DiskFile_obj(self, path, device, partition, account, container, obj,[m
[32m+[m[32m logger, keep_data_fp=False, disk_chunk_size=65536):[m
[32m+[m[32m if self.fs_object:[m
[32m+[m[32m return Gluster_DiskFile(path, device, partition, account, container,[m
[32m+[m[32m obj, logger, keep_data_fp,[m
[32m+[m[32m disk_chunk_size, fs_object = self.fs_object);[m
[32m+[m[32m else:[m
[32m+[m[32m return DiskFile(path, device, partition, account, container,[m
[32m+[m[32m obj, logger, keep_data_fp, disk_chunk_size)[m
[m
def async_update(self, op, account, container, obj, host, partition,[m
contdevice, headers_out, objdevice):[m
[36m@@ -493,7 +516,7 @@[m [mclass ObjectController(object):[m
content_type='text/plain')[m
if self.mount_check and not check_mount(self.devices, device):[m
return Response(status='507 %s is not mounted' % device)[m
[31m- file = DiskFile(self.devices, device, partition, account, container,[m
[32m+[m[32m file = self.get_DiskFile_obj(self.devices, device, partition, account, container,[m
obj, self.logger, disk_chunk_size=self.disk_chunk_size)[m
[m
if 'X-Delete-At' in file.metadata and \[m
[36m@@ -548,7 +571,7 @@[m [mclass ObjectController(object):[m
if new_delete_at and new_delete_at < time.time():[m
return HTTPBadRequest(body='X-Delete-At in past', request=request,[m
content_type='text/plain')[m
[31m- file = DiskFile(self.devices, device, partition, account, container,[m
[32m+[m[32m file = self.get_DiskFile_obj(self.devices, device, partition, account, container,[m
obj, self.logger, disk_chunk_size=self.disk_chunk_size)[m
orig_timestamp = file.metadata.get('X-Timestamp')[m
upload_expiration = time.time() + self.max_upload_time[m
[36m@@ -580,12 +603,29 @@[m [mclass ObjectController(object):[m
if 'etag' in request.headers and \[m
request.headers['etag'].lower() != etag:[m
return HTTPUnprocessableEntity(request=request)[m
[31m- metadata = {[m
[31m- 'X-Timestamp': request.headers['x-timestamp'],[m
[31m- 'Content-Type': request.headers['content-type'],[m
[31m- 'ETag': etag,[m
[31m- 'Content-Length': str(os.fstat(fd).st_size),[m
[31m- }[m
[32m+[m[32m content_type = request.headers['content-type'][m
[32m+[m[32m if self.fs_object and not content_type:[m
[32m+[m[32m content_type = FILE_TYPE[m
[32m+[m[32m if not self.fs_object:[m
[32m+[m[32m metadata = {[m
[32m+[m[32m 'X-Timestamp': request.headers['x-timestamp'],[m
[32m+[m[32m 'Content-Type': request.headers['content-type'],[m
[32m+[m[32m 'ETag': etag,[m
[32m+[m[32m 'Content-Length': str(os.fstat(fd).st_size),[m
[32m+[m[32m }[m
[32m+[m[32m else:[m
[32m+[m[32m metadata = {[m
[32m+[m[32m 'X-Timestamp': request.headers['x-timestamp'],[m
[32m+[m[32m 'Content-Type': request.headers['content-type'],[m
[32m+[m[32m 'ETag': etag,[m
[32m+[m[32m 'Content-Length': str(os.fstat(fd).st_size),[m
[32m+[m[32m X_TYPE: OBJECT,[m
[32m+[m[32m X_OBJECT_TYPE: FILE,[m
[32m+[m[32m }[m
[32m+[m
[32m+[m[32m if self.fs_object and \[m
[32m+[m[32m request.headers['content-type'].lower() == DIR_TYPE:[m
[32m+[m[32m metadata.update({X_OBJECT_TYPE: MARKER_DIR})[m
metadata.update(val for val in request.headers.iteritems()[m
if val[0].lower().startswith('x-object-meta-') and[m
len(val[0]) > 14)[m
[36m@@ -626,9 +666,9 @@[m [mclass ObjectController(object):[m
content_type='text/plain')[m
if self.mount_check and not check_mount(self.devices, device):[m
return Response(status='507 %s is not mounted' % device)[m
[31m- file = DiskFile(self.devices, device, partition, account, container,[m
[31m- obj, self.logger, keep_data_fp=True,[m
[31m- disk_chunk_size=self.disk_chunk_size)[m
[32m+[m[32m file = self.get_DiskFile_obj(self.devices, device, partition, account, container,[m
[32m+[m[32m obj, self.logger, keep_data_fp=True,[m
[32m+[m[32m disk_chunk_size=self.disk_chunk_size)[m
if file.is_deleted() or ('X-Delete-At' in file.metadata and[m
int(file.metadata['X-Delete-At']) <= time.time()):[m
if request.headers.get('if-match') == '*':[m
[36m@@ -702,7 +742,7 @@[m [mclass ObjectController(object):[m
return resp[m
if self.mount_check and not check_mount(self.devices, device):[m
return Response(status='507 %s is not mounted' % device)[m
[31m- file = DiskFile(self.devices, device, partition, account, container,[m
[32m+[m[32m file = self.get_DiskFile_obj(self.devices, device, partition, account, container,[m
obj, self.logger, disk_chunk_size=self.disk_chunk_size)[m
if file.is_deleted() or ('X-Delete-At' in file.metadata and[m
int(file.metadata['X-Delete-At']) <= time.time()):[m
[36m@@ -744,7 +784,7 @@[m [mclass ObjectController(object):[m
if self.mount_check and not check_mount(self.devices, device):[m
return Response(status='507 %s is not mounted' % device)[m
response_class = HTTPNoContent[m
[31m- file = DiskFile(self.devices, device, partition, account, container,[m
[32m+[m[32m file = self.get_DiskFile_obj(self.devices, device, partition, account, container,[m
obj, self.logger, disk_chunk_size=self.disk_chunk_size)[m
if 'x-if-delete-at' in request.headers and \[m
int(request.headers['x-if-delete-at']) != \[m
[36m@@ -797,9 +837,18 @@[m [mclass ObjectController(object):[m
raise hashes[m
return Response(body=pickle.dumps(hashes))[m
[m
[32m+[m[32m def plugin(self, env):[m
[32m+[m[32m if env.get('Gluster_enabled', False):[m
[32m+[m[32m self.fs_object = env.get('fs_object')[m
[32m+[m[32m self.devices = env.get('root')[m
[32m+[m[32m self.mount_check = False[m
[32m+[m[32m else:[m
[32m+[m[32m self.fs_object = None[m
[32m+[m
def __call__(self, env, start_response):[m
"""WSGI Application entry point for the Swift Object Server."""[m
start_time = time.time()[m
[32m+[m[32m self.plugin(env)[m
req = Request(env)[m
self.logger.txn_id = req.headers.get('x-trans-id', None)[m
if not check_utf8(req.path_info):[m
[1mdiff --git a/swift/proxy/server.py b/swift/proxy/server.py[m
[1mindex 17613b8..af1ef25 100644[m
[1m--- a/swift/proxy/server.py[m
[1m+++ b/swift/proxy/server.py[m
[36m@@ -1,4 +1,5 @@[m
# Copyright (c) 2010-2012 OpenStack, LLC.[m
[32m+[m[32m# Copyright (c) 2011 Red Hat, Inc.[m
#[m
# Licensed under the Apache License, Version 2.0 (the "License");[m
# you may not use this file except in compliance with the License.[m
[36m@@ -53,8 +54,20 @@[m [mfrom webob import Request, Response[m
[m
from swift.common.ring import Ring[m
from swift.common.utils import cache_from_env, ContextPool, get_logger, \[m
[31m- get_remote_client, normalize_timestamp, split_path, TRUE_VALUES[m
[32m+[m[32m get_remote_client, normalize_timestamp, split_path, TRUE_VALUES, \[m
[32m+[m[32m plugin_enabled[m
from swift.common.bufferedhttp import http_connect[m
[32m+[m
[32m+[m[32mif plugin_enabled():[m
[32m+[m[32m from swift.plugins.constraints import check_object_creation, \[m
[32m+[m[32m MAX_ACCOUNT_NAME_LENGTH, MAX_CONTAINER_NAME_LENGTH, MAX_FILE_SIZE[m
[32m+[m[32melse:[m
[32m+[m[32m from swift.common.constraints import check_object_creation, \[m
[32m+[m[32m MAX_ACCOUNT_NAME_LENGTH, MAX_CONTAINER_NAME_LENGTH, MAX_FILE_SIZE[m
[32m+[m
[32m+[m[32mfrom swift.common.constraints import check_metadata, check_utf8, \[m
[32m+[m[32m CONTAINER_LISTING_LIMIT[m
[32m+[m
from swift.common.constraints import check_metadata, check_object_creation, \[m
check_utf8, CONTAINER_LISTING_LIMIT, MAX_ACCOUNT_NAME_LENGTH, \[m
MAX_CONTAINER_NAME_LENGTH, MAX_FILE_SIZE[m
[1mdiff --git a/test/__init__.py b/test/__init__.py[m
[1mindex ef2ce31..363a051 100644[m
[1m--- a/test/__init__.py[m
[1m+++ b/test/__init__.py[m
[36m@@ -6,8 +6,16 @@[m [mimport sys[m
import os[m
from ConfigParser import MissingSectionHeaderError[m
from StringIO import StringIO[m
[31m-[m
from swift.common.utils import readconf[m
[32m+[m[32mfrom swift.common.utils import plugin_enabled[m
[32m+[m[32mif plugin_enabled():[m
[32m+[m[32m from swift.plugins.constraints import MAX_OBJECT_NAME_LENGTH, \[m
[32m+[m[32m MAX_CONTAINER_NAME_LENGTH, MAX_ACCOUNT_NAME_LENGTH, \[m
[32m+[m[32m MAX_FILE_SIZE[m
[32m+[m[32melse:[m
[32m+[m[32m from swift.common.constraints import MAX_OBJECT_NAME_LENGTH, \[m
[32m+[m[32m MAX_CONTAINER_NAME_LENGTH, MAX_ACCOUNT_NAME_LENGTH, \[m
[32m+[m[32m MAX_FILE_SIZE[m
[m
setattr(__builtin__, '_', lambda x: x)[m
[m
[1mdiff --git a/test/functional/tests.py b/test/functional/tests.py[m
[1mindex b25b4fd..8d12f58 100644[m
[1m--- a/test/functional/tests.py[m
[1m+++ b/test/functional/tests.py[m
[36m@@ -31,6 +31,16 @@[m [mimport urllib[m
from test import get_config[m
from swift import Account, AuthenticationFailed, Connection, Container, \[m
File, ResponseError[m
[32m+[m[32mfrom test import plugin_enabled[m
[32m+[m[32mif plugin_enabled():[m
[32m+[m[32m from test import MAX_OBJECT_NAME_LENGTH, \[m
[32m+[m[32m MAX_CONTAINER_NAME_LENGTH, MAX_ACCOUNT_NAME_LENGTH, \[m
[32m+[m[32m MAX_FILE_SIZE[m
[32m+[m[32melse:[m
[32m+[m[32m from test import MAX_OBJECT_NAME_LENGTH, \[m
[32m+[m[32m MAX_CONTAINER_NAME_LENGTH, MAX_ACCOUNT_NAME_LENGTH, \[m
[32m+[m[32m MAX_FILE_SIZE[m
[32m+[m
[m
config = get_config()[m
[m
[36m@@ -361,7 +371,7 @@[m [mclass TestContainer(Base):[m
set_up = False[m
[m
def testContainerNameLimit(self):[m
[31m- limit = 256[m
[32m+[m[32m limit = MAX_CONTAINER_NAME_LENGTH[m
[m
for l in (limit-100, limit-10, limit-1, limit,[m
limit+1, limit+10, limit+100):[m
[36m@@ -949,7 +959,7 @@[m [mclass TestFile(Base):[m
self.assert_status(404)[m
[m
def testNameLimit(self):[m
[31m- limit = 1024[m
[32m+[m[32m limit = MAX_OBJECT_NAME_LENGTH[m
[m
for l in (1, 10, limit/2, limit-1, limit, limit+1, limit*2):[m
file = self.env.container.file('a'*l)[m
[36m@@ -1093,7 +1103,7 @@[m [mclass TestFile(Base):[m
self.assert_(file.read(hdrs={'Range': r}) == data[0:1000])[m
[m
def testFileSizeLimit(self):[m
[31m- limit = 5*2**30 + 2[m
[32m+[m[32m limit = MAX_FILE_SIZE[m
tsecs = 3[m
[m
for i in (limit-100, limit-10, limit-1, limit, limit+1, limit+10,[m
[1mdiff --git a/test/unit/obj/test_server.py b/test/unit/obj/test_server.py[m
[1mindex 075700e..5b6f32d 100644[m
[1m--- a/test/unit/obj/test_server.py[m
[1m+++ b/test/unit/obj/test_server.py[m
[36m@@ -1355,7 +1355,7 @@[m [mclass TestObjectController(unittest.TestCase):[m
[m
def test_max_object_name_length(self):[m
timestamp = normalize_timestamp(time())[m
[31m- req = Request.blank('/sda1/p/a/c/' + ('1' * 1024),[m
[32m+[m[32m req = Request.blank('/sda1/p/a/c/' + ('1' * MAX_OBJECT_NAME_LENGTH),[m
environ={'REQUEST_METHOD': 'PUT'},[m
headers={'X-Timestamp': timestamp,[m
'Content-Length': '4',[m
[1mdiff --git a/test/unit/proxy/test_server.py b/test/unit/proxy/test_server.py[m
[1mindex 364370e..c17fe59 100644[m
[1m--- a/test/unit/proxy/test_server.py[m
[1m+++ b/test/unit/proxy/test_server.py[m
[36m@@ -21,7 +21,6 @@[m [mimport os[m
import sys[m
import unittest[m
from nose import SkipTest[m
[31m-from ConfigParser import ConfigParser[m
from contextlib import contextmanager[m
from cStringIO import StringIO[m
from gzip import GzipFile[m
[36m@@ -44,8 +43,18 @@[m [mfrom swift.account import server as account_server[m
from swift.container import server as container_server[m
from swift.obj import server as object_server[m
from swift.common import ring[m
[31m-from swift.common.constraints import MAX_META_NAME_LENGTH, \[m
[31m- MAX_META_VALUE_LENGTH, MAX_META_COUNT, MAX_META_OVERALL_SIZE, MAX_FILE_SIZE[m
[32m+[m[32mfrom swift.common.utils import plugin_enabled[m
[32m+[m[32mif plugin_enabled():[m
[32m+[m[32m from swift.plugins.constraints import MAX_META_NAME_LENGTH, \[m
[32m+[m[32m MAX_META_VALUE_LENGTH, MAX_META_COUNT, MAX_META_OVERALL_SIZE, \[m
[32m+[m[32m MAX_FILE_SIZE, MAX_ACCOUNT_NAME_LENGTH, MAX_CONTAINER_NAME_LENGTH, \[m
[32m+[m[32m MAX_OBJECT_NAME_LENGTH[m
[32m+[m[32melse:[m
[32m+[m[32m from swift.plugins.constraints import MAX_META_NAME_LENGTH, \[m
[32m+[m[32m MAX_META_VALUE_LENGTH, MAX_META_COUNT, MAX_META_OVERALL_SIZE, \[m
[32m+[m[32m MAX_FILE_SIZE, MAX_ACCOUNT_NAME_LENGTH, MAX_CONTAINER_NAME_LENGTH, \[m
[32m+[m[32m MAX_OBJECT_NAME_LENGTH[m
[32m+[m
from swift.common.utils import mkdirs, normalize_timestamp, NullLogger[m
from swift.common.wsgi import monkey_patch_mimetools[m
[m
[36m@@ -3207,7 +3216,8 @@[m [mclass TestContainerController(unittest.TestCase):[m
def test_PUT_max_container_name_length(self):[m
with save_globals():[m
controller = proxy_server.ContainerController(self.app, 'account',[m
[31m- '1' * 256)[m
[32m+[m[32m '1' *[m
[32m+[m[32m MAX_CONTAINER_NAME_LENGTH,)[m
self.assert_status_map(controller.PUT,[m
(200, 200, 200, 201, 201, 201), 201,[m
missing_container=True)[m
[36m@@ -3813,7 +3823,8 @@[m [mclass TestAccountController(unittest.TestCase):[m
def test_PUT_max_account_name_length(self):[m
with save_globals():[m
self.app.allow_account_management = True[m
[31m- controller = proxy_server.AccountController(self.app, '1' * 256)[m
[32m+[m[32m controller = proxy_server.AccountController(self.app, '1' *[m
[32m+[m[32m MAX_ACCOUNT_NAME_LENGTH)[m
self.assert_status_map(controller.PUT, (201, 201, 201), 201)[m
controller = proxy_server.AccountController(self.app, '2' * 257)[m
self.assert_status_map(controller.PUT, (201, 201, 201), 400)[m
|