blob: 0f8243ca731c0c28f4aafed4a50bdf34a3a84739 (
plain)
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
|
#!/bin/bash
syscalls=$'access\nchmod\nchown\nclose\nclosedir\ncreat64\n\
fallocate64\nfchmod\nfchown\nfdatasync\nfgetxattr\nflistxattr\n\
fremovexattr\nfsetxattr\nfsync\nftruncate64\n__fxstat64\n\
__fxstatat64\nlchown\nlgetxattr\nlinkat\nllistxattr\nlremovexattr\n\
lseek64\nlsetxattr\n__lxstat64\nmkdir\nmkdirat\nopenat64\nopendir\n\
pread64\npwrite64\npreadv64\npwritev64\nread\nreaddir64\nreadlink\n\
readv\nrename\nrmdir\n statvfs64\nsymlink\n\truncate64\nunlink\n\
utimeswrite\nwritev\n\__xmknod\n__xstat64'
syscalls32=$'creat\nfallocate\nftruncate\n__fxstat\n__fxstatat\n\
lseek\n__lxstat\nopenat\nreaddir\nstatvfs\ntruncate\nstat\n\
preadv\npwritev\npread\npwrite'
glibccalls=$'tmpfile'
exclude_files=$'/libglusterfs/src/.libs/libglusterfs_la-syscall.o\n\
/libglusterfs/src/.libs/libglusterfs_la-gen_uuid.o\n\
/contrib/fuse-util/fusermount.o\n\
/contrib/fuse-util/mount_util.o\n\
/contrib/fuse-util/mount-common.o\n\
/xlators/mount/fuse/src/.libs/mount.o\n\
/xlators/mount/fuse/src/.libs/mount-common.o\n\
/xlators/features/qemu-block/src/.libs/block.o\n\
/xlators/features/qemu-block/src/.libs/cutils.o\n\
/xlators/features/qemu-block/src/.libs/oslib-posix.o'
function main()
{
for exclude_file in ${exclude_files}; do
if [[ ${1} = *${exclude_file} ]]; then
exit 0
fi
done
local retval=0
local t
t=$(nm "${1}" | grep " U " | sed -e "s/ //g" -e "s/ U //g")
for symy in ${t}; do
for symx in ${syscalls}; do
if [[ ${symx} = "${symy}" ]]; then
case ${symx} in
"creat64") sym="creat";;
"fallocate64") sym="fallocate";;
"ftruncate64") sym="ftruncate";;
"lseek64") sym="lseek";;
"preadv64") sym="preadv";;
"pwritev64") sym="pwritev";;
"pread64") sym="pread";;
"pwrite64") sym="pwrite";;
"openat64") sym="openat";;
"readdir64") sym="readdir";;
"truncate64") sym="truncate";;
"__statvfs64") sym="statvfs";;
"__fxstat64") sym="fstat";;
"__fxstatat64") sym="fstatat";;
"__lxstat64") sym="lstat";;
"__xmknod") sym="mknod";;
"__xstat64") sym="stat";;
*) sym=${symx};;
esac
echo "${1} should call sys_${sym}, not ${sym}" >&2
retval=1
fi
done
for symx in ${syscalls32}; do
if [[ ${symx} = "${symy}" ]]; then
echo "${1} was not compiled with -D_FILE_OFFSET_BITS=64" >&2
retval=1
fi
done
symy_glibc=$(echo "${symy}" | sed -e "s/@@GLIBC.*//g")
# Eliminate false positives, check if we have a GLIBC symbol in 'y'
if [[ ${symy} != "${symy_glibc}" ]]; then
for symx in ${glibccalls}; do
if [[ ${symx} = "${symy_glibc}" ]]; then
case ${symx} in
"tmpfile") alt="mkstemp";;
*) alt="none";;
esac
if [[ ${alt} = "none" ]]; then
echo "${1} should not call ${symy_glibc}";
else
echo "${1} should use ${alt} instead of ${symy_glibc}" >&2;
fi
retval=1
fi
done
fi
done
if [ ${retval} = 1 ]; then
touch ./.symbol-check-errors
fi
exit ${retval}
}
main "$@"
|
