From 23e5ecbdbb4b37c6c6666ff6b2d6d057c266fd15 Mon Sep 17 00:00:00 2001 From: Yaniv Kaul Date: Thu, 5 Jul 2018 23:01:11 +0300 Subject: Tests: ensure volume deletion works when intended. It could have failed without anyone noticing. Added 'xfail' - do we expect to fail in deletion (and changed tests accordingly) On the way, ensure stdout and stderr are logged in case of such failures. Change-Id: Ibdf7a43cadb0393707a6c68c19a664453a971eb1 Signed-off-by: Yaniv Kaul --- tests/functional/glusterd/test_peer_probe.py | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) (limited to 'tests/functional/glusterd/test_peer_probe.py') diff --git a/tests/functional/glusterd/test_peer_probe.py b/tests/functional/glusterd/test_peer_probe.py index a3fe5240d..242681343 100644 --- a/tests/functional/glusterd/test_peer_probe.py +++ b/tests/functional/glusterd/test_peer_probe.py @@ -226,10 +226,11 @@ class TestPeerProbe(GlusterBaseClass): g.log.info("Volume %s start with force is success", self.volname) # Volume delete should fail without stopping volume - ret = volume_delete(self.servers[2], self.volname) - self.assertFalse(ret, ("Unexpected Error: Volume deleted " - "successfully without stopping" - "volume %s", self.volname)) + self.assertTrue( + volume_delete(self.servers[2], self.volname, xfail=True), + "Unexpected Error: Volume deleted " + "successfully without stopping volume" + ) g.log.info("Expected: volume delete should fail without " "stopping volume: %s", self.volname) -- cgit