From 53ba8efce4dafc55204ff673455d6e89d02dc330 Mon Sep 17 00:00:00 2001 From: Selvasundaram Date: Thu, 21 Jul 2011 18:33:22 +0530 Subject: Server alert bug fix --- .../com/gluster/storage/management/gui/AlertsManager.java | 13 ++++++++++--- 1 file changed, 10 insertions(+), 3 deletions(-) diff --git a/src/com.gluster.storage.management.gui/src/com/gluster/storage/management/gui/AlertsManager.java b/src/com.gluster.storage.management.gui/src/com/gluster/storage/management/gui/AlertsManager.java index ed700d53..8af61058 100644 --- a/src/com.gluster.storage.management.gui/src/com/gluster/storage/management/gui/AlertsManager.java +++ b/src/com.gluster.storage.management.gui/src/com/gluster/storage/management/gui/AlertsManager.java @@ -101,7 +101,10 @@ public class AlertsManager { private List getServerAlerts() { List serverAlerts = new ArrayList(); - serverAlerts.add(getOfflineServerAlerts()); // Single alert for offline servers + Alert offlineServerAlert = getOfflineServerAlerts(); + if (offlineServerAlert != null) { + serverAlerts.add(offlineServerAlert); // Single alert for offline servers + } for (GlusterServer server : cluster.getServers()) { // To check off line servers @@ -140,8 +143,12 @@ public class AlertsManager { offlineServers.add(server.getName()); } } - return new Alert(ALERT_TYPES.OFFLINE_SERVERS_ALERT, "Server", - Alert.ALERT_TYPE_STR[ALERT_TYPES.OFFLINE_SERVERS_ALERT.ordinal()] + "(s) " + offlineServers.toString()); + if (offlineServers.size() > 0) { + return new Alert(ALERT_TYPES.OFFLINE_SERVERS_ALERT, "Server", + Alert.ALERT_TYPE_STR[ALERT_TYPES.OFFLINE_SERVERS_ALERT.ordinal()] + "(s) " + + offlineServers.toString()); + } + return null; } private List getLowDiskAlerts(GlusterServer server) { -- cgit