From de61fdab795233fd60ad68856cd706aaa885364d Mon Sep 17 00:00:00 2001
From: Selvasundaram <selvam@gluster.com>
Date: Thu, 11 Aug 2011 20:50:38 +0530
Subject: Gluster online server parsing issue fix Cifs stop issue fix Multiple
 selection of volume start / stop operation fail issue fix

---
 .../gluster/storage/management/console/actions/StartVolumeAction.java | 2 +-
 .../gluster/storage/management/console/actions/StopVolumeAction.java  | 4 ++--
 .../storage/management/console/dialogs/CreateVolumeWizard.java        | 2 +-
 3 files changed, 4 insertions(+), 4 deletions(-)

(limited to 'src/com.gluster.storage.management.console')

diff --git a/src/com.gluster.storage.management.console/src/com/gluster/storage/management/console/actions/StartVolumeAction.java b/src/com.gluster.storage.management.console/src/com/gluster/storage/management/console/actions/StartVolumeAction.java
index 2c254e59..c86b66cf 100644
--- a/src/com.gluster.storage.management.console/src/com/gluster/storage/management/console/actions/StartVolumeAction.java
+++ b/src/com.gluster.storage.management.console/src/com/gluster/storage/management/console/actions/StartVolumeAction.java
@@ -55,7 +55,7 @@ public class StartVolumeAction extends AbstractActionDelegate {
 		List<String> failedVolumes = new ArrayList<String>();
 		String errorMessage = "";
 		
-		for (Volume volume : selectedVolumes) {
+		for (Volume volume : selectedVolumes.toArray(new Volume[0])) {
 			if (volume.getStatus() == VOLUME_STATUS.ONLINE) { 
 				continue; // skip if already started
 			}
diff --git a/src/com.gluster.storage.management.console/src/com/gluster/storage/management/console/actions/StopVolumeAction.java b/src/com.gluster.storage.management.console/src/com/gluster/storage/management/console/actions/StopVolumeAction.java
index f02d090e..6e5b4d30 100644
--- a/src/com.gluster.storage.management.console/src/com/gluster/storage/management/console/actions/StopVolumeAction.java
+++ b/src/com.gluster.storage.management.console/src/com/gluster/storage/management/console/actions/StopVolumeAction.java
@@ -65,7 +65,7 @@ public class StopVolumeAction extends AbstractActionDelegate {
 		List<String> failedVolumes = new ArrayList<String>();
 		String errorMessage = "";
 
-		for (Volume volume : volumes) {
+		for (Volume volume : volumes.toArray(new Volume[0])) {
 			if (volume.getStatus() == VOLUME_STATUS.OFFLINE) {
 				continue; // skip if already stopped
 			}
@@ -138,7 +138,7 @@ public class StopVolumeAction extends AbstractActionDelegate {
 		for (Volume volume : volumes) {
 			if (volume.getStatus() == VOLUME_STATUS.ONLINE) {
 				action.setEnabled(true);
-				break;// If find an online volume, enable the action
+				break; // If find an online volume, enable the action
 			}
 		}
 	}
diff --git a/src/com.gluster.storage.management.console/src/com/gluster/storage/management/console/dialogs/CreateVolumeWizard.java b/src/com.gluster.storage.management.console/src/com/gluster/storage/management/console/dialogs/CreateVolumeWizard.java
index a7b7d251..bfb29ee1 100644
--- a/src/com.gluster.storage.management.console/src/com/gluster/storage/management/console/dialogs/CreateVolumeWizard.java
+++ b/src/com.gluster.storage.management.console/src/com/gluster/storage/management/console/dialogs/CreateVolumeWizard.java
@@ -111,7 +111,7 @@ public class CreateVolumeWizard extends Wizard {
 			
 			if (error) {
 				MessageDialog.openWarning(getShell(), title, message1);
-			} else {
+			} else if (message1.trim().length() > 0) {
 				MessageDialog.openInformation(getShell(), title, message1);
 			}
 		} else { // Start volume is not checked
-- 
cgit