From 024c8f2cc9298ccfcb3faf50b52da1724eb5f475 Mon Sep 17 00:00:00 2001 From: Tim Date: Tue, 23 Aug 2011 16:21:06 +0530 Subject: Fixed file did not closed properly error and logged the IOError in remove_server_volume_cifs_config.py --- .../src/gateway/remove_server_volume_cifs_config.py | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-) (limited to 'src') diff --git a/src/com.gluster.storage.management.gateway.scripts/src/gateway/remove_server_volume_cifs_config.py b/src/com.gluster.storage.management.gateway.scripts/src/gateway/remove_server_volume_cifs_config.py index 55230113..e90b6a57 100755 --- a/src/com.gluster.storage.management.gateway.scripts/src/gateway/remove_server_volume_cifs_config.py +++ b/src/com.gluster.storage.management.gateway.scripts/src/gateway/remove_server_volume_cifs_config.py @@ -55,9 +55,10 @@ def main(): try: fp = open(tempFileName, "w") fp.write("%s\n" % serverName) - except IOError: - Utils.log("Failed to write server name to file %s" % tempFileName) - sys.stderr.write("Failed to write server name to file\n") + fp.close() + except IOError, e: + Utils.log("Failed to write server name to file %s: %s" % (tempFileName, str(e))) + sys.stderr.write("Failed to write server name to file %s: %s\n" % (tempFileName, str(e))) sys.exit(3) status = True @@ -70,8 +71,8 @@ def main(): try: os.remove(tempFileName) except OSError, e: - Utils.log("Failed to remove temporary file %s" % tempFileName) - sys.stderr.write("Failed to remove temporary file %s\n" % tempFileName) + Utils.log("Failed to remove temporary file %s: %s" % (tempFileName, str(e))) + sys.stderr.write("Failed to remove temporary file %s: %s\n" % (tempFileName, str(e))) pass if status: -- cgit