From 798cce01d42bcbaa8745e6a54acf01e9aa868953 Mon Sep 17 00:00:00 2001 From: Shireesh Anjal Date: Thu, 21 Jul 2011 21:23:19 +0530 Subject: Added some new icons --- .../storage/management/core/model/Device.java | 6 +- .../storage/management/core/model/Disk.java | 5 + .../management/core/model/GlusterServer.java | 4 + .../storage/management/core/model/Server.java | 8 +- .../icons/tango/32x32/add-server.png | Bin 0 -> 2137 bytes .../icons/tango/32x32/remove-volume.png | Bin 0 -> 1449 bytes .../icons/tango/32x32/remove-volume.svg | 1699 -------------------- .../icons/tango/48x48/add-server.svg | 126 ++ src/com.gluster.storage.management.gui/plugin.xml | 8 +- .../gluster/storage/management/gui/IImageKeys.java | 6 +- .../gui/dialogs/ClusterSelectionDialog.java | 2 +- .../management/gui/views/ClusterSummaryView.java | 34 +- .../gui/views/GlusterServerSummaryView.java | 9 +- 13 files changed, 187 insertions(+), 1720 deletions(-) create mode 100644 src/com.gluster.storage.management.gui/icons/tango/32x32/add-server.png create mode 100644 src/com.gluster.storage.management.gui/icons/tango/32x32/remove-volume.png delete mode 100644 src/com.gluster.storage.management.gui/icons/tango/32x32/remove-volume.svg create mode 100644 src/com.gluster.storage.management.gui/icons/tango/48x48/add-server.svg (limited to 'src') diff --git a/src/com.gluster.storage.management.core/src/com/gluster/storage/management/core/model/Device.java b/src/com.gluster.storage.management.core/src/com/gluster/storage/management/core/model/Device.java index 4a00ac5a..f6f8450e 100644 --- a/src/com.gluster.storage.management.core/src/com/gluster/storage/management/core/model/Device.java +++ b/src/com.gluster.storage.management.core/src/com/gluster/storage/management/core/model/Device.java @@ -185,6 +185,10 @@ public class Device extends Entity { @Override public boolean equals(Object obj) { + if(this == obj) { + return true; + } + if(!(obj instanceof Device)) { return false; } @@ -201,7 +205,7 @@ public class Device extends Entity { if (getName().equals(device.getName()) && getServerName().equals(device.getServerName()) && oldMountPoint.equals(newMountPoint) && getStatus() == device.getStatus() - && getSpace() == device.getSpace() && getSpaceInUse() == device.getSpaceInUse() + && getSpace().equals(device.getSpace()) && getSpaceInUse().equals(device.getSpaceInUse()) && oldFsType.equals(newFsType) && oldFsVersion.equals(newFsVersion) && getType() == device.getType()) { return true; diff --git a/src/com.gluster.storage.management.core/src/com/gluster/storage/management/core/model/Disk.java b/src/com.gluster.storage.management.core/src/com/gluster/storage/management/core/model/Disk.java index f06ca258..1fb870e5 100644 --- a/src/com.gluster.storage.management.core/src/com/gluster/storage/management/core/model/Disk.java +++ b/src/com.gluster.storage.management.core/src/com/gluster/storage/management/core/model/Disk.java @@ -107,9 +107,14 @@ public class Disk extends Device { @Override public boolean equals(Object obj) { + if(this == obj) { + return true; + } + if(!(obj instanceof Disk)) { return false; } + Disk disk = (Disk)obj; if (!(super.equals(obj) && getDescription().equals(disk.getDescription()) && getDiskInterface().equals( diff --git a/src/com.gluster.storage.management.core/src/com/gluster/storage/management/core/model/GlusterServer.java b/src/com.gluster.storage.management.core/src/com/gluster/storage/management/core/model/GlusterServer.java index 025db809..5928f3af 100644 --- a/src/com.gluster.storage.management.core/src/com/gluster/storage/management/core/model/GlusterServer.java +++ b/src/com.gluster.storage.management.core/src/com/gluster/storage/management/core/model/GlusterServer.java @@ -81,6 +81,10 @@ public class GlusterServer extends Server { @Override public boolean equals(Object obj) { + if(this == obj) { + return true; + } + if(!(obj instanceof GlusterServer)) { return false; } diff --git a/src/com.gluster.storage.management.core/src/com/gluster/storage/management/core/model/Server.java b/src/com.gluster.storage.management.core/src/com/gluster/storage/management/core/model/Server.java index 39696665..5697530e 100644 --- a/src/com.gluster.storage.management.core/src/com/gluster/storage/management/core/model/Server.java +++ b/src/com.gluster.storage.management.core/src/com/gluster/storage/management/core/model/Server.java @@ -160,7 +160,9 @@ public class Server extends Entity { String ipAddresses = ""; for (NetworkInterface networkInterface : getNetworkInterfaces()) { String ipAddr = networkInterface.getIpAddress(); - ipAddresses += (ipAddresses.isEmpty() ? ipAddr : ", " + ipAddr); + if(!ipAddr.equals("127.0.0.1")) { + ipAddresses += (ipAddresses.isEmpty() ? ipAddr : ", " + ipAddr); + } } return ipAddresses; } @@ -190,6 +192,10 @@ public class Server extends Entity { @Override public boolean equals(Object obj) { + if(this == obj) { + return true; + } + if(!(obj instanceof Server)) { return false; } diff --git a/src/com.gluster.storage.management.gui/icons/tango/32x32/add-server.png b/src/com.gluster.storage.management.gui/icons/tango/32x32/add-server.png new file mode 100644 index 00000000..29a512f2 Binary files /dev/null and b/src/com.gluster.storage.management.gui/icons/tango/32x32/add-server.png differ diff --git a/src/com.gluster.storage.management.gui/icons/tango/32x32/remove-volume.png b/src/com.gluster.storage.management.gui/icons/tango/32x32/remove-volume.png new file mode 100644 index 00000000..68de86a3 Binary files /dev/null and b/src/com.gluster.storage.management.gui/icons/tango/32x32/remove-volume.png differ diff --git a/src/com.gluster.storage.management.gui/icons/tango/32x32/remove-volume.svg b/src/com.gluster.storage.management.gui/icons/tango/32x32/remove-volume.svg deleted file mode 100644 index 0a0a6cf5..00000000 --- a/src/com.gluster.storage.management.gui/icons/tango/32x32/remove-volume.svg +++ /dev/null @@ -1,1699 +0,0 @@ - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - image/svg+xml - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - diff --git a/src/com.gluster.storage.management.gui/icons/tango/48x48/add-server.svg b/src/com.gluster.storage.management.gui/icons/tango/48x48/add-server.svg new file mode 100644 index 00000000..233ee823 --- /dev/null +++ b/src/com.gluster.storage.management.gui/icons/tango/48x48/add-server.svg @@ -0,0 +1,126 @@ + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + image/svg+xml + + + 2005-03-08 + + + Jakub Steiner + + + + + workstation + computer + node + client + + + + http://jimmac.musichall.cz/ + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + \ No newline at end of file diff --git a/src/com.gluster.storage.management.gui/plugin.xml b/src/com.gluster.storage.management.gui/plugin.xml index db5605f3..f1ac0e73 100644 --- a/src/com.gluster.storage.management.gui/plugin.xml +++ b/src/com.gluster.storage.management.gui/plugin.xml @@ -406,7 +406,7 @@ allowLabelUpdate="false" class="com.gluster.storage.management.gui.actions.DeleteVolumeAction" definitionId="com.gluster.storage.management.gui.commands.DeleteVolume" - icon="icons/tango/32x32/remove-volume.svg" + icon="icons/tango/32x32/remove-volume.png" id="com.gluster.storage.management.gui.actions.DeleteVolumeAction" label="&Delete Volume(s)" menubarPath="com.gluster.storage.management.gui.actionsets.volumes/volumes" @@ -514,7 +514,7 @@ allowLabelUpdate="false" class="com.gluster.storage.management.gui.actions.DeleteVolumeAction" definitionId="com.gluster.storage.management.gui.commands.DeleteVolume" - icon="icons/tango/32x32/remove-volume.svg" + icon="icons/tango/32x32/remove-volume.png" id="com.gluster.storage.management.gui.actions.DeleteVolumeAction" label="&Delete Volume" menubarPath="com.gluster.storage.management.gui.menu.volume/volume" @@ -793,7 +793,7 @@ allowLabelUpdate="false" class="com.gluster.storage.management.gui.actions.AddServerAction" definitionId="com.gluster.storage.management.gui.commands.AddServer" - icon="icons/server-add.png" + icon="icons/tango/32x32/add-server.png" id="com.gluster.storage.management.gui.actions.AddServerAction" label="&Add Server(s)" menubarPath="com.gluster.storage.management.gui.menu.discoveredservers/discoveredservers" @@ -851,7 +851,7 @@ allowLabelUpdate="false" class="com.gluster.storage.management.gui.actions.AddServerAction" definitionId="com.gluster.storage.management.gui.commands.AddServer" - icon="icons/server-add.png" + icon="icons/tango/32x32/add-server.png" id="com.gluster.storage.management.gui.actions.AddServerAction" label="&Add Server(s)" menubarPath="com.gluster.storage.management.gui.menu.discoveredserver/discoveredserver" diff --git a/src/com.gluster.storage.management.gui/src/com/gluster/storage/management/gui/IImageKeys.java b/src/com.gluster.storage.management.gui/src/com/gluster/storage/management/gui/IImageKeys.java index 49e2871b..72f9bd0b 100644 --- a/src/com.gluster.storage.management.gui/src/com/gluster/storage/management/gui/IImageKeys.java +++ b/src/com.gluster.storage.management.gui/src/com/gluster/storage/management/gui/IImageKeys.java @@ -38,9 +38,9 @@ public interface IImageKeys { public static final String SERVER_OFFLINE = "icons/tango/16x16/offline-server.png"; public static final String CREATE_VOLUME_BIG = "icons/tango/48x48/create-volume.svg"; - public static final String REMOVE_VOLUME = "icons/tango/32x32/remove-volume.svg"; - public static final String ADD_SERVER = "icons/server-add.png"; - public static final String ADD_SERVER_BIG = "icons/tango/48x48/server.png"; + public static final String REMOVE_VOLUME = "icons/tango/32x32/remove-volume.png"; + public static final String ADD_SERVER = "icons/tango/32x32/add-server.png"; + public static final String ADD_SERVER_BIG = "icons/tango/48x48/add-server.svg"; public static final String REMOVE_SERVER = "icons/server-remove.png"; public static final String HELP = "icons/question.png"; public static final String STATUS_OFFLINE = "icons/status-offline.png"; diff --git a/src/com.gluster.storage.management.gui/src/com/gluster/storage/management/gui/dialogs/ClusterSelectionDialog.java b/src/com.gluster.storage.management.gui/src/com/gluster/storage/management/gui/dialogs/ClusterSelectionDialog.java index 82df0c46..37381172 100644 --- a/src/com.gluster.storage.management.gui/src/com/gluster/storage/management/gui/dialogs/ClusterSelectionDialog.java +++ b/src/com.gluster.storage.management.gui/src/com/gluster/storage/management/gui/dialogs/ClusterSelectionDialog.java @@ -159,7 +159,7 @@ public class ClusterSelectionDialog extends Dialog { @Override protected Control createDialogArea(Composite parent) { - parent.setBackgroundImage(guiHelper.getImage(IImageKeys.DIALOG_SPLASH_IMAGE)); + //parent.setBackgroundImage(guiHelper.getImage(IImageKeys.DIALOG_SPLASH_IMAGE)); // Makes sure that child composites inherit the same background parent.setBackgroundMode(SWT.INHERIT_FORCE); diff --git a/src/com.gluster.storage.management.gui/src/com/gluster/storage/management/gui/views/ClusterSummaryView.java b/src/com.gluster.storage.management.gui/src/com/gluster/storage/management/gui/views/ClusterSummaryView.java index 3f344d8b..e06f3386 100644 --- a/src/com.gluster.storage.management.gui/src/com/gluster/storage/management/gui/views/ClusterSummaryView.java +++ b/src/com.gluster.storage.management.gui/src/com/gluster/storage/management/gui/views/ClusterSummaryView.java @@ -20,7 +20,6 @@ */ package com.gluster.storage.management.gui.views; -import java.util.ArrayList; import java.util.List; import org.eclipse.birt.chart.util.CDateTime; @@ -28,18 +27,19 @@ import org.eclipse.swt.SWT; import org.eclipse.swt.custom.CLabel; import org.eclipse.swt.graphics.Image; import org.eclipse.swt.layout.GridData; +import org.eclipse.swt.layout.GridLayout; import org.eclipse.swt.widgets.Composite; import org.eclipse.swt.widgets.Display; import org.eclipse.swt.widgets.Label; import org.eclipse.ui.forms.events.HyperlinkAdapter; import org.eclipse.ui.forms.events.HyperlinkEvent; import org.eclipse.ui.forms.widgets.FormToolkit; +import org.eclipse.ui.forms.widgets.Hyperlink; import org.eclipse.ui.forms.widgets.ImageHyperlink; import org.eclipse.ui.forms.widgets.ScrolledForm; import org.eclipse.ui.handlers.IHandlerService; import org.eclipse.ui.part.ViewPart; -import com.gluster.storage.management.client.GlusterServersClient; import com.gluster.storage.management.core.model.Alert; import com.gluster.storage.management.core.model.Cluster; import com.gluster.storage.management.core.model.EntityGroup; @@ -47,8 +47,6 @@ import com.gluster.storage.management.core.model.GlusterDataModel; import com.gluster.storage.management.core.model.GlusterServer; import com.gluster.storage.management.core.model.GlusterServer.SERVER_STATUS; import com.gluster.storage.management.core.model.Server; -import com.gluster.storage.management.core.model.ServerStats; -import com.gluster.storage.management.core.model.ServerStatsRow; import com.gluster.storage.management.core.model.TaskInfo; import com.gluster.storage.management.core.utils.NumberUtil; import com.gluster.storage.management.gui.GlusterDataModelManager; @@ -68,6 +66,7 @@ public class ClusterSummaryView extends ViewPart { private ScrolledForm form; private Cluster cluster; private GlusterDataModel model = GlusterDataModelManager.getInstance().getModel(); + private static final int CHART_WIDTH = 350; /* * (non-Javadoc) @@ -133,11 +132,30 @@ public class ClusterSummaryView extends ViewPart { chartViewerComposite.setLayoutData(data); } + private Composite createChartLinks(Composite section, int columnCount) { + GridLayout layout = new org.eclipse.swt.layout.GridLayout(columnCount, false); + layout.marginBottom = 0; + layout.marginTop = 0; + layout.marginLeft = (CHART_WIDTH - (50*columnCount)) / 2; + Composite graphComposite = toolkit.createComposite(section, SWT.NONE); + graphComposite.setLayout(layout); + GridData data = new GridData(SWT.FILL, SWT.FILL, false, false); + data.widthHint = CHART_WIDTH; + graphComposite.setLayoutData(data); + + Label label1 = toolkit.createLabel(graphComposite, "1 day"); + Hyperlink link1 = toolkit.createHyperlink(graphComposite, "1 week", SWT.NONE); + Hyperlink link2 = toolkit.createHyperlink(graphComposite, "1 month", SWT.NONE); + Hyperlink link3 = toolkit.createHyperlink(graphComposite, "1 year", SWT.NONE); + + return graphComposite; + } + private void createLineChart(Composite section, Calendar timestamps[], Double values[], String unit) { ChartViewerComposite chartViewerComposite = new ChartViewerComposite(section, SWT.NONE, timestamps, values, unit); GridData data = new GridData(SWT.FILL, SWT.FILL, false, false); - data.widthHint = 400; - data.heightHint = 300; + data.widthHint = CHART_WIDTH; + data.heightHint = 250; data.verticalAlignment = SWT.CENTER; chartViewerComposite.setLayoutData(data); } @@ -254,10 +272,11 @@ public class ClusterSummaryView extends ViewPart { Double[] values = new Double[] { 10d, 11.23d, 17.92d, 18.69d, 78.62d, 89.11d, 92.43d, 89.31d, 57.39d, 18.46d, 10.44d, 16.28d, 13.51d, 17.53d, 12.21, 20d, 21.43d, 16.45d, 14.86d, 15.27d }; createLineChart(section, timestamps, values, "%"); + createChartLinks(section, 4); } private void createNetworkUsageSection() { - Composite section = guiHelper.createSection(form, toolkit, "Network Usage", null, 1, false); + Composite section = guiHelper.createSection(form, toolkit, "Network Usage (Aggregated)", null, 1, false); //toolkit.createLabel(section, "Historical Network Usage graph will be displayed here."); Calendar[] timestamps = new Calendar[] { new CDateTime(1000l*1310468100), new CDateTime(1000l*1310468400), new CDateTime(1000l*1310468700), @@ -274,6 +293,7 @@ public class ClusterSummaryView extends ViewPart { // new Date(1310473800) }; Double[] values = new Double[] { 32d, 31.23d, 27.92d, 48.69d, 58.62d, 49.11d, 72.43d, 69.31d, 87.39d, 78.46d, 60.44d, 56.28d, 33.51d, 27.53d, 12.21, 10d, 21.43d, 36.45d, 34.86d, 35.27d }; createLineChart(section, timestamps, values, "KiB/s"); + createChartLinks(section, 4); } private void createRunningTasksSection() { diff --git a/src/com.gluster.storage.management.gui/src/com/gluster/storage/management/gui/views/GlusterServerSummaryView.java b/src/com.gluster.storage.management.gui/src/com/gluster/storage/management/gui/views/GlusterServerSummaryView.java index bae6b9e3..fbf787e3 100644 --- a/src/com.gluster.storage.management.gui/src/com/gluster/storage/management/gui/views/GlusterServerSummaryView.java +++ b/src/com.gluster.storage.management.gui/src/com/gluster/storage/management/gui/views/GlusterServerSummaryView.java @@ -113,7 +113,7 @@ public class GlusterServerSummaryView extends ViewPart { private void createLineChart(Composite section, Calendar timestamps[], Double values[], String unit) { ChartViewerComposite chartViewerComposite = new ChartViewerComposite(section, SWT.NONE, timestamps, values, unit); GridData data = new GridData(SWT.FILL, SWT.FILL, false, false); -// data.widthHint = CHART_WIDTH; + data.widthHint = CHART_WIDTH; data.heightHint = 250; // data.verticalAlignment = SWT.CENTER; // data.grabExcessVerticalSpace = false; @@ -134,7 +134,7 @@ public class GlusterServerSummaryView extends ViewPart { //Double[] values = new Double[] { 10d, 11.23d, 17.92d, 18.69d, 78.62d, 89.11d, 92.43d, 20.31d, 19.63d, 18.46d, 10.44d, 16.28d, 13.51d, 17.53d, 12.21, 20d, 40d, 10d, 90d, 40d }; Double[] values = new Double[] { 35d, 34.23d, 37.92d, 28.69d, 38.62d, 39.11d, 38.46d, 30.44d, 36.28d, 72.43d, 79.31d, 77.39d, 33.51d, 37.53d, 32.21, 30d, 31.43d, 36.45d, 34.86d, 35.27d }; createLineChart(section, timestamps, values, "%"); - Composite graphComposite = createChartLinks(section, 4); + createChartLinks(section, 4); } private void createNetworkUsageSection() { @@ -151,9 +151,10 @@ public class GlusterServerSummaryView extends ViewPart { createLineChart(section, timestamps, values, "Kib/s"); Composite graphComposite = createChartLinks(section, 5); + CCombo interfaceCombo = new CCombo(graphComposite, SWT.DROP_DOWN | SWT.READ_ONLY | SWT.BORDER | SWT.FLAT); interfaceCombo.setItems(new String[] {"eth0"}); - interfaceCombo.select(0); + interfaceCombo.select(0); } @@ -181,7 +182,7 @@ public class GlusterServerSummaryView extends ViewPart { // } // // createLineChart(section, timestamps.toArray(new Calendar[0]), data.toArray(new Double[0])); - Composite graphComposite = createChartLinks(section, 4); + createChartLinks(section, 4); } private Composite createChartLinks(Composite section, int columnCount) { -- cgit