diff options
author | Peter Portante <peter.portante@redhat.com> | 2013-05-23 19:51:24 -0400 |
---|---|---|
committer | Luis Pabon <lpabon@redhat.com> | 2013-05-24 12:16:43 -0700 |
commit | 833d7fc7dfe077b39eade72a5496a40181b20a0c (patch) | |
tree | 1ac9a25c69bb90376f43ed7ef1e7973ab4eb1682 | |
parent | b29164198523591a69b234e869b7a1b94bd4f08e (diff) |
Add coverage for gluster.swift module (PkgInfo).
Change-Id: I614efb853989ab455721bbf28309cec746343f50
Signed-off-by: Peter Portante <peter.portante@redhat.com>
Reviewed-on: http://review.gluster.org/5081
Reviewed-by: Luis Pabon <lpabon@redhat.com>
Tested-by: Luis Pabon <lpabon@redhat.com>
-rw-r--r-- | gluster/swift/__init__.py | 6 | ||||
-rw-r--r-- | test/unit/test_swift.py | 53 |
2 files changed, 57 insertions, 2 deletions
diff --git a/gluster/swift/__init__.py b/gluster/swift/__init__.py index fa360b6..f2c2403 100644 --- a/gluster/swift/__init__.py +++ b/gluster/swift/__init__.py @@ -8,8 +8,10 @@ class PkgInfo(object): self.final = final def save_config(self, filename): - """Crates a file with the package configuration - which can be sourced by a bash script""" + """ + Creates a file with the package configuration which can be sourced by + a bash script. + """ with open(filename, 'w') as fd: fd.write("PKG_NAME=%s\n" % self.name) fd.write("PKG_VERSION=%s\n" % self.canonical_version) diff --git a/test/unit/test_swift.py b/test/unit/test_swift.py new file mode 100644 index 0000000..5c78a8b --- /dev/null +++ b/test/unit/test_swift.py @@ -0,0 +1,53 @@ +# Copyright (c) 2013 Red Hat, Inc. +# +# Licensed under the Apache License, Version 2.0 (the "License"); +# you may not use this file except in compliance with the License. +# You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or +# implied. +# See the License for the specific language governing permissions and +# limitations under the License. + +""" Tests for gluster.swift """ + +import os +import unittest +import shutil +import tempfile + +import gluster.swift as gs + + +class TestPkgInfo(unittest.TestCase): + """ + Tests for gluster.swift PkgInfo class. + """ + + def test_constructor(self): + pi = gs.PkgInfo('a', 'b', 'c') + assert pi.canonical_version == 'a' + assert pi.name == 'b' + assert pi.final == 'c' + + def test_pretty_version(self): + pi = gs.PkgInfo('a', 'b', False) + assert pi.pretty_version == 'a-dev' + pi = gs.PkgInfo('a', 'b', True) + assert pi.pretty_version == 'a' + + def test_save_config(self): + pi = gs.PkgInfo('a', 'b', 'c') + td = tempfile.mkdtemp() + try: + sc = os.path.join(td, 'saved_config.txt') + pi.save_config(sc) + exp = 'PKG_NAME=b\nPKG_VERSION=a\n' + contents = file(sc, 'r').read() + assert contents == exp + finally: + shutil.rmtree(td) |