path: root/libglusterfs/src/gf-dirent.c
diff options
authorShehjar Tikoo <>2009-06-03 01:05:34 +0000
committerAnand V. Avati <>2009-06-08 06:31:55 -0700
commit4c0b91a5a045e3f03a049320d26542ab9fec4745 (patch)
treefc99963edbcf4da8d3b07f1915f39cf6754fb385 /libglusterfs/src/gf-dirent.c
parent08d46effee3b5e07b89a3a04251714383cf02eec (diff)
libglusterfs: Add empty and NULL dirents list checks
These checks are needed in case a higher layer intends to delink the dirent list and passes a NULL pointer to fop_readdir_cbk_stub for the entries parameter. Consequently, the gf_dirent_free must guard against an empty list because the stub that is passed to it mgiht have an empty dirent list. Signed-off-by: Anand V. Avati <>
Diffstat (limited to 'libglusterfs/src/gf-dirent.c')
1 files changed, 6 insertions, 0 deletions
diff --git a/libglusterfs/src/gf-dirent.c b/libglusterfs/src/gf-dirent.c
index 2023c1983..b321dfc10 100644
--- a/libglusterfs/src/gf-dirent.c
+++ b/libglusterfs/src/gf-dirent.c
@@ -76,6 +76,12 @@ gf_dirent_free (gf_dirent_t *entries)
gf_dirent_t *entry = NULL;
gf_dirent_t *tmp = NULL;
+ if (!entries)
+ return;
+ if (list_empty (&entries->list))
+ return;
list_for_each_entry_safe (entry, tmp, &entries->list, list) {
list_del (&entry->list);
FREE (entry);