diff options
| author | Vikas Gorur <vikas@zresearch.com> | 2009-02-26 17:51:47 +0530 |
|---|---|---|
| committer | Anand V. Avati <avati@amp.gluster.com> | 2009-02-26 18:03:18 +0530 |
| commit | c445012fa990be5dbc0ccbace04187484ccd92f3 (patch) | |
| tree | f05154080893cfc2a8bd1e77b555b429c6c4a2fc /xlators/cluster/afr/src/afr.c | |
| parent | 523d23b94c21cf5cfdfd087409371d9d2dcf25a4 (diff) | |
protect fd_ctx get/set in afr_transaction and afr.c with locks
Signed-off-by: Anand V. Avati <avati@amp.gluster.com>
Diffstat (limited to 'xlators/cluster/afr/src/afr.c')
| -rw-r--r-- | xlators/cluster/afr/src/afr.c | 15 |
1 files changed, 13 insertions, 2 deletions
diff --git a/xlators/cluster/afr/src/afr.c b/xlators/cluster/afr/src/afr.c index 1be016a39..e627da1fb 100644 --- a/xlators/cluster/afr/src/afr.c +++ b/xlators/cluster/afr/src/afr.c @@ -816,6 +816,8 @@ afr_flush (call_frame_t *frame, xlator_t *this, fd_t *fd) int op_ret = -1; int op_errno = 0; + int transaction_needed = 0; + VALIDATE_OR_GOTO (frame, out); VALIDATE_OR_GOTO (this, out); VALIDATE_OR_GOTO (this->private, out); @@ -832,9 +834,18 @@ afr_flush (call_frame_t *frame, xlator_t *this, fd_t *fd) frame->local = local; - if (__is_fd_ctx_set (this, fd)) { - fd_ctx_del (fd, this, NULL); + LOCK (&fd->inode->lock); + { + if (__is_fd_ctx_set (this, fd)) { + transaction_needed = 1; + fd_ctx_del (fd, this, NULL); + } else { + transaction_needed = 0; + } + } + UNLOCK (&fd->inode->lock); + if (transaction_needed) { local->op = GF_FOP_FLUSH; local->transaction.fop = afr_flush_wind; local->transaction.done = afr_flush_done; |