diff options
| author | Pranith Kumar K <pranithk@gluster.com> | 2012-07-28 12:18:50 +0530 |
|---|---|---|
| committer | Anand Avati <avati@redhat.com> | 2012-07-29 13:40:19 -0700 |
| commit | c9b96e26a3bab09a4146b2bec57a57c69b9aa8b7 (patch) | |
| tree | 5a387328a0f84a0a833bf02724fa38c09927a104 /xlators/features/locks/src/common.h | |
| parent | c2859a6039ecb74a4b88989326fa538d1d5b06c2 (diff) | |
features/locks: Fix statedump code
RCA:
Taking blocking mutex/spin locks lead to dead locks
because of the locking order in statedumps. Also we
were asked to remove gf_logs if possible to avoid extra
cost in signal handlers.
Fix:
changed blocking mutes/spin locks to their non-blocking variants.
Removed gf_logs in locks xlator statedump code-path.
Tests:
State-dump success cases are working fine.
Triggered try-lock failures by putting statedumps in a while loop.
In parallel did chown of the same file in a while loop.
Change-Id: I81539a62f8216f267f57bb703ef132c85bfd557d
BUG: 843781
Signed-off-by: Pranith Kumar K <pranithk@gluster.com>
Reviewed-on: http://review.gluster.com/3747
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
Diffstat (limited to 'xlators/features/locks/src/common.h')
| -rw-r--r-- | xlators/features/locks/src/common.h | 4 |
1 files changed, 4 insertions, 0 deletions
diff --git a/xlators/features/locks/src/common.h b/xlators/features/locks/src/common.h index 2cf9aa380..97faa5b92 100644 --- a/xlators/features/locks/src/common.h +++ b/xlators/features/locks/src/common.h @@ -88,9 +88,13 @@ grant_blocked_entry_locks (xlator_t *this, pl_inode_t *pl_inode, void pl_update_refkeeper (xlator_t *this, inode_t *inode); int32_t +__get_inodelk_count (xlator_t *this, pl_inode_t *pl_inode); +int32_t get_inodelk_count (xlator_t *this, inode_t *inode); int32_t +__get_entrylk_count (xlator_t *this, pl_inode_t *pl_inode); +int32_t get_entrylk_count (xlator_t *this, inode_t *inode); void pl_trace_in (xlator_t *this, call_frame_t *frame, fd_t *fd, loc_t *loc, |