diff options
| author | Pranith Kumar K <pkarampu@redhat.com> | 2013-01-24 00:31:54 +0530 |
|---|---|---|
| committer | Anand Avati <avati@redhat.com> | 2013-01-23 22:10:43 -0800 |
| commit | 8dc7707c1b32465551d5d5553057e04748945fda (patch) | |
| tree | 33421bc10f0fbe01eb9b76d15706a9ec6e2d5155 | |
| parent | 4faeedc99284ce4e6b86bec39309b949fb5423ac (diff) | |
debug/io-stats: Handle open failures gracefully
Change-Id: I85b22db5cc456b3e8c9f26c8254f08a796fc2b28
BUG: 903336
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
Reviewed-on: http://review.gluster.org/4418
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
| -rw-r--r-- | tests/bugs/bug-903336.t | 13 | ||||
| -rw-r--r-- | xlators/debug/io-stats/src/io-stats.c | 1 |
2 files changed, 13 insertions, 1 deletions
diff --git a/tests/bugs/bug-903336.t b/tests/bugs/bug-903336.t new file mode 100644 index 00000000..c1f91312 --- /dev/null +++ b/tests/bugs/bug-903336.t @@ -0,0 +1,13 @@ +#!/bin/bash + +. $(dirname $0)/../include.rc + +cleanup; + +TEST glusterd +TEST pidof glusterd +TEST $CLI volume create $V0 $H0:$B0/${V0} +TEST $CLI volume start $V0 +TEST glusterfs --volfile-id=/$V0 --volfile-server=$H0 $M0 --attribute-timeout=0 --entry-timeout=0 +TEST setfattr -n trusted.io-stats-dump -v /tmp $M0 +cleanup diff --git a/xlators/debug/io-stats/src/io-stats.c b/xlators/debug/io-stats/src/io-stats.c index 556c7224..5d5151cf 100644 --- a/xlators/debug/io-stats/src/io-stats.c +++ b/xlators/debug/io-stats/src/io-stats.c @@ -2166,7 +2166,6 @@ conditional_dump (dict_t *dict, char *key, data_t *value, void *data) return -1; } logfp = fopen (filename, "w+"); - GF_ASSERT (logfp); if (!logfp) { gf_log (this->name, GF_LOG_ERROR, "failed to open %s " "for writing", filename); |