summaryrefslogtreecommitdiffstats
path: root/cli/src/cli-rpc-ops.c
diff options
context:
space:
mode:
Diffstat (limited to 'cli/src/cli-rpc-ops.c')
-rw-r--r--cli/src/cli-rpc-ops.c9
1 files changed, 4 insertions, 5 deletions
diff --git a/cli/src/cli-rpc-ops.c b/cli/src/cli-rpc-ops.c
index 3edcd0d6..af228381 100644
--- a/cli/src/cli-rpc-ops.c
+++ b/cli/src/cli-rpc-ops.c
@@ -2593,8 +2593,8 @@ cli_quotad_getlimit_cbk (struct rpc_req *req, struct iovec *iov,
"unserialize req-buffer to dictionary");
goto out;
}
+ print_quota_list_from_quotad (frame, dict);
}
- print_quota_list_from_quotad (frame, dict);
out:
cli_cmd_broadcast_response (ret);
@@ -2633,9 +2633,6 @@ cli_quotad_getlimit (call_frame_t *frame, xlator_t *this, void *data)
(xdrproc_t) xdr_gf_cli_req);
out:
- if (ret) {
- frame->local = NULL;
- }
gf_log ("cli", GF_LOG_DEBUG, "Returning %d", ret);
return ret;
@@ -2717,7 +2714,7 @@ gf_cli_quota_cbk (struct rpc_req *req, struct iovec *iov,
ret = dict_get_str (dict, "volname", &volname);
if (ret)
- gf_log (frame->this->name, GF_LOG_TRACE,
+ gf_log (frame->this->name, GF_LOG_ERROR,
"failed to get volname");
ret = dict_get_str (dict, "default-soft-limit", &default_sl);
@@ -2725,6 +2722,8 @@ gf_cli_quota_cbk (struct rpc_req *req, struct iovec *iov,
gf_log (frame->this->name, GF_LOG_TRACE, "failed to get "
"default soft limit");
+ // default-soft-limit is part of rsp_dict only iff we sent
+ // GLUSTER_CLI_QUOTA with type being GF_QUOTA_OPTION_TYPE_LIST
if (default_sl) {
default_sl_dup = gf_strdup (default_sl);
if (!default_sl_dup) {