summaryrefslogtreecommitdiffstats
path: root/xlators
diff options
context:
space:
mode:
authorShehjar Tikoo <shehjart@gluster.com>2010-04-22 06:12:00 +0000
committerAnand V. Avati <avati@dev.gluster.com>2010-04-23 06:33:03 -0700
commitcade6a8f2305800750bf7d9a6907e02f8b06f0b6 (patch)
tree1e3815452063914c1c2e058d80e7f91f9cc3f310 /xlators
parent8626e201a5bceb623bb77a82fd5437ba3668cf19 (diff)
stat-prefetch: Remove checks for loc->parent
..because loc->parent can be NULL for the root inode. Having this check makes sp return EINVAL on perfectly valid fops. Signed-off-by: Shehjar Tikoo <shehjart@gluster.com> Signed-off-by: Anand V. Avati <avati@dev.gluster.com> BUG: 845 (NFS BETA Test - Test Case 1: 4dist-repl-chown1m) URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=845
Diffstat (limited to 'xlators')
-rw-r--r--xlators/performance/stat-prefetch/src/stat-prefetch.c32
1 files changed, 0 insertions, 32 deletions
diff --git a/xlators/performance/stat-prefetch/src/stat-prefetch.c b/xlators/performance/stat-prefetch/src/stat-prefetch.c
index e7dd8958f..87cc6ddc3 100644
--- a/xlators/performance/stat-prefetch/src/stat-prefetch.c
+++ b/xlators/performance/stat-prefetch/src/stat-prefetch.c
@@ -1438,8 +1438,6 @@ sp_create (call_frame_t *frame, xlator_t *this, loc_t *loc, int32_t flags,
GF_VALIDATE_OR_GOTO_WITH_ERROR (this->name, loc, out, op_errno,
EINVAL);
- GF_VALIDATE_OR_GOTO_WITH_ERROR (this->name, loc->parent, out,
- op_errno, EINVAL);
GF_VALIDATE_OR_GOTO_WITH_ERROR (this->name, loc->path, out, op_errno,
EINVAL);
GF_VALIDATE_OR_GOTO_WITH_ERROR (this->name, loc->name, out, op_errno,
@@ -1628,8 +1626,6 @@ sp_mkdir (call_frame_t *frame, xlator_t *this, loc_t *loc, mode_t mode)
GF_VALIDATE_OR_GOTO_WITH_ERROR (this->name, loc, out, op_errno,
EINVAL);
- GF_VALIDATE_OR_GOTO_WITH_ERROR (this->name, loc->parent, out,
- op_errno, EINVAL);
GF_VALIDATE_OR_GOTO_WITH_ERROR (this->name, loc->path, out, op_errno,
EINVAL);
GF_VALIDATE_OR_GOTO_WITH_ERROR (this->name, loc->name, out, op_errno,
@@ -1691,8 +1687,6 @@ sp_mknod (call_frame_t *frame, xlator_t *this, loc_t *loc, mode_t mode,
GF_VALIDATE_OR_GOTO_WITH_ERROR (this->name, loc, out, op_errno,
EINVAL);
- GF_VALIDATE_OR_GOTO_WITH_ERROR (this->name, loc->parent, out,
- op_errno, EINVAL);
GF_VALIDATE_OR_GOTO_WITH_ERROR (this->name, loc->path, out, op_errno,
EINVAL);
GF_VALIDATE_OR_GOTO_WITH_ERROR (this->name, loc->name, out, op_errno,
@@ -1754,8 +1748,6 @@ sp_symlink (call_frame_t *frame, xlator_t *this, const char *linkpath,
GF_VALIDATE_OR_GOTO_WITH_ERROR (this->name, loc, out, op_errno,
EINVAL);
- GF_VALIDATE_OR_GOTO_WITH_ERROR (this->name, loc->parent, out,
- op_errno, EINVAL);
GF_VALIDATE_OR_GOTO_WITH_ERROR (this->name, loc->path, out, op_errno,
EINVAL);
GF_VALIDATE_OR_GOTO_WITH_ERROR (this->name, loc->name, out, op_errno,
@@ -1869,8 +1861,6 @@ sp_link (call_frame_t *frame, xlator_t *this, loc_t *oldloc, loc_t *newloc)
GF_VALIDATE_OR_GOTO_WITH_ERROR (this->name, newloc, out, op_errno,
EINVAL);
- GF_VALIDATE_OR_GOTO_WITH_ERROR (this->name, newloc->parent, out,
- op_errno, EINVAL);
GF_VALIDATE_OR_GOTO_WITH_ERROR (this->name, newloc->path, out,
op_errno, EINVAL);
GF_VALIDATE_OR_GOTO_WITH_ERROR (this->name, newloc->name, out,
@@ -1878,8 +1868,6 @@ sp_link (call_frame_t *frame, xlator_t *this, loc_t *oldloc, loc_t *newloc)
GF_VALIDATE_OR_GOTO_WITH_ERROR (this->name, newloc->inode, out,
op_errno, EINVAL);
- GF_VALIDATE_OR_GOTO_WITH_ERROR (this->name, oldloc->parent, out,
- op_errno, EINVAL);
GF_VALIDATE_OR_GOTO_WITH_ERROR (this->name, oldloc->name, out,
op_errno, EINVAL);
@@ -1975,8 +1963,6 @@ sp_truncate (call_frame_t *frame, xlator_t *this, loc_t *loc, off_t offset)
GF_VALIDATE_OR_GOTO_WITH_ERROR (this->name, loc, out, op_errno,
EINVAL);
- GF_VALIDATE_OR_GOTO_WITH_ERROR (this->name, loc->parent, out,
- op_errno, EINVAL);
GF_VALIDATE_OR_GOTO_WITH_ERROR (this->name, loc->name, out, op_errno,
EINVAL);
@@ -2111,8 +2097,6 @@ sp_setattr (call_frame_t *frame, xlator_t *this,
GF_VALIDATE_OR_GOTO_WITH_ERROR (this->name, loc, out, op_errno,
EINVAL);
- GF_VALIDATE_OR_GOTO_WITH_ERROR (this->name, loc->parent, out,
- op_errno, EINVAL);
GF_VALIDATE_OR_GOTO_WITH_ERROR (this->name, loc->name, out, op_errno,
EINVAL);
@@ -2210,8 +2194,6 @@ sp_readlink (call_frame_t *frame, xlator_t *this, loc_t *loc, size_t size)
GF_VALIDATE_OR_GOTO_WITH_ERROR (this->name, loc, out, op_errno,
EINVAL);
- GF_VALIDATE_OR_GOTO_WITH_ERROR (this->name, loc->parent, out,
- op_errno, EINVAL);
GF_VALIDATE_OR_GOTO_WITH_ERROR (this->name, loc->name, out,
op_errno, EINVAL);
@@ -2319,8 +2301,6 @@ sp_unlink (call_frame_t *frame, xlator_t *this, loc_t *loc)
GF_VALIDATE_OR_GOTO_WITH_ERROR (this->name, loc, out, op_errno,
EINVAL);
- GF_VALIDATE_OR_GOTO_WITH_ERROR (this->name, loc->parent, out,
- op_errno, EINVAL);
GF_VALIDATE_OR_GOTO_WITH_ERROR (this->name, loc->name, out, op_errno,
EINVAL);
@@ -2441,8 +2421,6 @@ sp_rmdir (call_frame_t *frame, xlator_t *this, loc_t *loc)
EINVAL);
GF_VALIDATE_OR_GOTO_WITH_ERROR (this->name, loc->inode, out,
op_errno, EINVAL);
- GF_VALIDATE_OR_GOTO_WITH_ERROR (this->name, loc->parent, out,
- op_errno, EINVAL);
sp_remove_caches_from_all_fds_opened (this, loc->inode);
@@ -2720,8 +2698,6 @@ sp_rename (call_frame_t *frame, xlator_t *this, loc_t *oldloc,loc_t *newloc)
op_errno, EINVAL);
GF_VALIDATE_OR_GOTO_WITH_ERROR (this->name, oldloc->name, out,
op_errno, EINVAL);
- GF_VALIDATE_OR_GOTO_WITH_ERROR (this->name, oldloc->parent, out,
- op_errno, EINVAL);
GF_VALIDATE_OR_GOTO_WITH_ERROR (this->name, oldloc->inode, out,
op_errno, EINVAL);
@@ -2893,8 +2869,6 @@ sp_setxattr (call_frame_t *frame, xlator_t *this, loc_t *loc, dict_t *dict,
GF_VALIDATE_OR_GOTO_WITH_ERROR (this->name, loc, out, op_errno,
EINVAL);
- GF_VALIDATE_OR_GOTO_WITH_ERROR (this->name, loc->parent, out,
- op_errno, EINVAL);
GF_VALIDATE_OR_GOTO_WITH_ERROR (this->name, loc->name, out, op_errno,
EINVAL);
@@ -2984,8 +2958,6 @@ sp_removexattr (call_frame_t *frame, xlator_t *this, loc_t *loc,
GF_VALIDATE_OR_GOTO_WITH_ERROR (this->name, loc, out, op_errno,
EINVAL);
- GF_VALIDATE_OR_GOTO_WITH_ERROR (this->name, loc->parent, out,
- op_errno, EINVAL);
GF_VALIDATE_OR_GOTO_WITH_ERROR (this->name, loc->name, out, op_errno,
EINVAL);
@@ -3172,8 +3144,6 @@ sp_checksum (call_frame_t *frame, xlator_t *this, loc_t *loc, int32_t flag)
GF_VALIDATE_OR_GOTO_WITH_ERROR (this->name, loc, out, op_errno,
EINVAL);
- GF_VALIDATE_OR_GOTO_WITH_ERROR (this->name, loc->parent, out,
- op_errno, EINVAL);
GF_VALIDATE_OR_GOTO_WITH_ERROR (this->name, loc->name, out,
op_errno, EINVAL);
@@ -3271,8 +3241,6 @@ sp_xattrop (call_frame_t *frame, xlator_t *this, loc_t *loc,
GF_VALIDATE_OR_GOTO_WITH_ERROR (this->name, loc, out, op_errno,
EINVAL);
- GF_VALIDATE_OR_GOTO_WITH_ERROR (this->name, loc->parent, out,
- op_errno, EINVAL);
GF_VALIDATE_OR_GOTO_WITH_ERROR (this->name, loc->name, out, op_errno,
EINVAL);