| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
| |
Change-Id: I69f32920dc48c6c52b579c792f28951bb38db344
Signed-off-by: Sachin Pandit <spandit@redhat.com>
Reviewed-on: http://review.gluster.org/7385
Reviewed-by: Raghavendra Bhat <raghavendra@redhat.com>
Reviewed-by: Rajesh Joseph <rjoseph@redhat.com>
Tested-by: Rajesh Joseph <rjoseph@redhat.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
In the events of a volume's brick being down, or a node being
down, making snap ops like create, delete, restore, and
status crash consistent.
Marking snap status of snap bricks which were not snapshotted
because the volume brick was down as -1, and not starting those
snap bricks till the snapshot is taken.
During delete bypassing lvm snapshot remove for snap bricks
whose snap status is -1
During restore bypass replacing xattrs on the snapshot bricks
whose snap status is -1. Also bumping restored volume's version
so as to handle nodes being down. On handshake of a restored
volume, passing brick's snap_status as well.
During snapshot status of the non-snapshotted brick details
display "N/A". If a node is down, the entry itself will not
be displayed.
Change-Id: Id042efd7507829995270da0b2b2a6282a08a053d
Signed-off-by: Avra Sengupta <asengupt@redhat.com>
Reviewed-on: http://review.gluster.org/7241
Reviewed-by: Vijaikumar Mallikarjuna <vmallika@redhat.com>
Reviewed-by: Rajesh Joseph <rjoseph@redhat.com>
Tested-by: Rajesh Joseph <rjoseph@redhat.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Syntax :
gluster snapshot config [volname] [snap-max-hard-limit <value>]
[snap-max-soft-limit <value>]
1)If volume name is not specified, then the value is set system wide.
2)If volume name is specified, then the value is set to that particular volume.
*NOTE : snap-max-soft-limit cannot be specified to individual volumes.
case 1) When system limit is greater than volume limit.
Sample output :
Snapshot System Configuration:
snap-max-hard-limit : 200
snap-max-soft-limit : 50%
Snapshot Volume Configuration:
Volume : vol2
snap-max-hard-limit : 100
Effective snap-max-hard-limit : 100
Effective snap-max-soft-limit : 50 (50%)
Volume : vol1
snap-max-hard-limit : 150
Effective snap-max-hard-limit : 150
Effective snap-max-soft-limit : 75 (50%)
case 2) When system limit is lesser than volume limit.
Sample output :
Snapshot System Configuration:
snap-max-hard-limit : 50
snap-max-soft-limit : 50%
Snapshot Volume Configuration:
Volume : vol2
snap-max-hard-limit : 100
Effective snap-max-hard-limit : 50
Effective snap-max-soft-limit : 25 (50%)
Volume : vol1
snap-max-hard-limit : 150
Effective snap-max-hard-limit : 50
Effective snap-max-soft-limit : 25 (50%)
Change-Id: I97b5daefec7205bb9ab7b5b51d38f504cc5ee940
BUG: 1075034
Signed-off-by: Sachin Pandit <spandit@redhat.com>
Reviewed-on: http://review.gluster.org/7303
Reviewed-by: Rajesh Joseph <rjoseph@redhat.com>
Tested-by: Rajesh Joseph <rjoseph@redhat.com>
|
|
|
|
|
|
|
|
|
| |
Change-Id: Id3da2a7aac84027aeff050f6dd9a3484719362bc
BUG: 1073780
Signed-off-by: Vijaikumar M <vmallika@redhat.com>
Reviewed-on: http://review.gluster.org/7204
Reviewed-by: Rajesh Joseph <rjoseph@redhat.com>
Tested-by: Rajesh Joseph <rjoseph@redhat.com>
|
|
|
|
|
|
|
|
|
|
|
|
| |
more than 255 characters
Change-Id: Iaab6889a86ab39fa73eebf30dc08af98d5a774bc
BUG: 1078166
Signed-off-by: Vijaikumar M <vmallika@redhat.com>
Reviewed-on: http://review.gluster.org/7296
Reviewed-by: Avra Sengupta <asengupt@redhat.com>
Reviewed-by: Rajesh Joseph <rjoseph@redhat.com>
Tested-by: Rajesh Joseph <rjoseph@redhat.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
1) Create with Description key and without actual description will display proper message.
2) Create with snapname containing special character will fail (volname convention is followed).
3) Create with Multiple Description will fail with proper message.
Change-Id: I9173a0ffe2bf77c10a4e383268bd8d99906217a0
BUG: 1040978
Signed-off-by: Sachin Pandit <spandit@redhat.com>
Reviewed-on: http://review.gluster.org/7324
Reviewed-by: Vijaikumar Mallikarjuna <vmallika@redhat.com>
Reviewed-by: Rajesh Joseph <rjoseph@redhat.com>
Tested-by: Rajesh Joseph <rjoseph@redhat.com>
|
|
|
|
|
|
|
|
|
| |
Change-Id: Ib3c239eadbcfc787f4f7d0734839c8425e93020a
BUG: 1076356
Signed-off-by: Sachin Pandit <spandit@redhat.com>
Reviewed-on: http://review.gluster.org/7275
Reviewed-by: Rajesh Joseph <rjoseph@redhat.com>
Tested-by: Rajesh Joseph <rjoseph@redhat.com>
|
|
|
|
|
|
|
|
|
| |
Change-Id: I27e50921a2e030ae50b1fd28ee7ab0be65b313fd
BUG: 1075454
Signed-off-by: Sachin Pandit <spandit@redhat.com>
Reviewed-on: http://review.gluster.org/7228
Reviewed-by: Rajesh Joseph <rjoseph@redhat.com>
Tested-by: Rajesh Joseph <rjoseph@redhat.com>
|
|
|
|
|
|
|
|
|
|
| |
Change-Id: Ib7fd1ca766997bce86062e5c10c5acf7e5edae60
BUG: 1075512
Signed-off-by: Sachin Pandit <spandit@redhat.com>
Reviewed-on: http://review.gluster.org/7236
Reviewed-by: Vijaikumar Mallikarjuna <vmallika@redhat.com>
Reviewed-by: Rajesh Joseph <rjoseph@redhat.com>
Tested-by: Rajesh Joseph <rjoseph@redhat.com>
|
|
|
|
|
|
|
|
| |
Change-Id: Iaee04f5209e278d83c086e32c4cafd6c571370cd
Signed-off-by: Vijaikumar M <vmallika@redhat.com>
Reviewed-on: http://review.gluster.org/7242
Reviewed-by: Rajesh Joseph <rjoseph@redhat.com>
Tested-by: Rajesh Joseph <rjoseph@redhat.com>
|
|
|
|
|
|
|
|
|
|
| |
Change-Id: Ic468e2e64bdfc0f7d79453524a1b2ebc9b445906
BUG: 1075446
Signed-off-by: Sachin Pandit <spandit@redhat.com>
Reviewed-on: http://review.gluster.org/7225
Reviewed-by: Raghavendra Bhat <raghavendra@redhat.com>
Reviewed-by: Rajesh Joseph <rjoseph@redhat.com>
Tested-by: Rajesh Joseph <rjoseph@redhat.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Snapshot status command is used to display the status of
available snapshot.
The status command will display the Brick path, Volume Group,
Brick pid, Whether brick is online, Percentage of data filled,
Logical Volume size.
The syntax for using snapshot status is :
gluster snapshot status [(snapname | volume <volname>)]
Change-Id: I621911c305e20ca83d958ff1f8762bef1f2f12f0
Signed-off-by: Sachin Pandit <spandit@redhat.com>
Reviewed-on: http://review.gluster.org/7134
Reviewed-by: Vijaikumar Mallikarjuna <vmallika@redhat.com>
Reviewed-by: Rajesh Joseph <rjoseph@redhat.com>
Tested-by: Rajesh Joseph <rjoseph@redhat.com>
|
|
|
|
|
|
|
|
|
| |
Change-Id: Ifa090b158ca23402fb6afa4f3b65fad1446f350d
Signed-off-by: Sachin Pandit <spandit@redhat.com>
Reviewed-on: http://review.gluster.org/7212
Reviewed-by: Vijaikumar Mallikarjuna <vmallika@redhat.com>
Reviewed-by: Rajesh Joseph <rjoseph@redhat.com>
Tested-by: Rajesh Joseph <rjoseph@redhat.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Also populated the error message in case of snapshot create, list, info and delete failure.
When snapshot list, info or delete is issued, if the entered snapname/volname does not exist then populate error string along with logging.
Change-Id: I632d25110bc63ff0e4ac98b27e2f410f7ccbb990
Signed-off-by: Sachin Pandit <spandit@redhat.com>
Reviewed-on: http://review.gluster.org/7203
Reviewed-by: Vijaikumar Mallikarjuna <vmallika@redhat.com>
Reviewed-by: Rajesh Joseph <rjoseph@redhat.com>
Tested-by: Rajesh Joseph <rjoseph@redhat.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This Patch includes cli change and few backend changes.
Syntax :
gluster snapshot restore <snap-name>
** Also removed unwanted snapshot remove parsing code.
Change-Id: Ie32590ccd4080da9409fd16c543866c14fae28f5
Signed-off-by: Sachin Pandit <spandit@redhat.com>
Reviewed-on: http://review.gluster.org/7191
Reviewed-by: Vijaikumar Mallikarjuna <vmallika@redhat.com>
Reviewed-by: Rajesh Joseph <rjoseph@redhat.com>
Tested-by: Rajesh Joseph <rjoseph@redhat.com>
|
|
|
|
|
|
|
|
|
|
|
|
| |
Created framework to process single volume lock, single snap lock,
multiple volume locks, multiple snap locks, and multiple snap and
volume locks requests.
Change-Id: I3f87bdec0bf142d6a1fd3f9d9f5012cc44eaf4bd
Signed-off-by: Avra Sengupta <asengupt@redhat.com>
Reviewed-on: http://review.gluster.org/7189
Reviewed-by: Rajesh Joseph <rjoseph@redhat.com>
Tested-by: Rajesh Joseph <rjoseph@redhat.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
With the snap driven approach, While creating the snapshot, We have to
mention the snap-name first and then the volumes to be associated with
that. Corresponding changes has been made in glusterd.
While deleting the snapshot, we have to mention only the snapname.
Corresponding changes has been made in glusterd.
CLI changes for the same can be found here:
http://review.gluster.org/#/c/6947/
Change-Id: I8bd8f471da5b728165da5f331faad3dde3486823
Signed-off-by: Vijaikumar M <vmallika@redhat.com>
Reviewed-on: http://review.gluster.org/7123
Reviewed-by: Avra Sengupta <asengupt@redhat.com>
Reviewed-by: Rajesh Joseph <rjoseph@redhat.com>
Tested-by: Rajesh Joseph <rjoseph@redhat.com>
|
|
|
|
|
|
|
|
|
|
|
| |
Syntax:
gluster snapshot delete <snapname>
Change-Id: I5de7b9a79eeba12e4f0b8abfbe96a2db738f25c0
Signed-off-by: Sachin Pandit <spandit@redhat.com>
Reviewed-on: http://review.gluster.org/7144
Reviewed-by: Rajesh Joseph <rjoseph@redhat.com>
Tested-by: Rajesh Joseph <rjoseph@redhat.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
syntax:
gluster snapshot list [volname]
This will list all the snapshots (or) snapshots of a particular volume.
Change-Id: If879e06fe13caf2236f48df345857f833ae83c5b
Signed-off-by: Sachin Pandit <spandit@redhat.com>
Reviewed-on: http://review.gluster.org/7143
Reviewed-by: Rajesh Joseph <rjoseph@redhat.com>
Tested-by: Rajesh Joseph <rjoseph@redhat.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
snapshot info [(snapname | volume <volname>)].
Snapshot info will list all the basic information.
Syntax :
** gluster snapshot info **
This will list all the snap object along with that
it also prints the snaps volume name, UUID and
status.
** gluster snapshot info <snap-name> **
This will list only the mentioned snap object and
also snap volume information along with that
** gluster snapshot info volume <volname> **
This will list all the snaps present in the
mentioned volume.
Change-Id: I1e92774cb08eaebbfe141b9b47d1a887d76916a4
Signed-off-by: Sachin Pandit <spandit@redhat.com>
Reviewed-on: http://review.gluster.org/6996
Reviewed-by: Rajesh Joseph <rjoseph@redhat.com>
Tested-by: Rajesh Joseph <rjoseph@redhat.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Syntax:
gluster snapshot create <snap-name> <vol-names>
[description <description>] [force].
New change:
With the snap driven approach, While creating the snapshot, We have
to mention the snap-name first and then the volumes to be associated
with that. Corresponding changes has been made in CLI,and all the
hyphenated options are replaced by keywords.
Previous Syntax :
snapshot create <volnames> [-n <snap-name/cg-name>] [-d <description>]
Change-Id: I9b4caf9629fdc3195b682190d999db2ecd9ce3e1
Signed-off-by: Sachin Pandit <spandit@redhat.com>
Reviewed-on: http://review.gluster.org/6947
Reviewed-by: Raghavendra Bhat <raghavendra@redhat.com>
Reviewed-by: Rajesh Joseph <rjoseph@redhat.com>
Tested-by: Rajesh Joseph <rjoseph@redhat.com>
|
|
|
|
|
|
|
|
|
|
| |
Change-Id: I6315d5b96ac72f6520037d4e96e29e5862aec346
Signed-off-by: Sachin Pandit <spandit@redhat.com>
Reviewed-on: http://review.gluster.org/6867
Reviewed-by: Raghavendra Bhat <raghavendra@redhat.com>
Reviewed-by: Avra Sengupta <asengupt@redhat.com>
Reviewed-by: Rajesh Joseph <rjoseph@redhat.com>
Tested-by: Rajesh Joseph <rjoseph@redhat.com>
|
|\ |
|
| |
| |
| |
| |
| |
| | |
Change-Id: Ife2395a92997168bb147a7db4bba346d3adc916b
BUG: 1048126
Signed-off-by: Raghavendra Bhat <raghavendra@redhat.com>
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Currently, on deleting snapshot , there is no warning message displayed
to the user.
A Warning must be displayed before the snapshot is deleted as follows:
Deleting snap will erase all information about the snap. Do you want to
continue? (y/n)
Change-Id: I60f4f346da36b6564576c7482f5989a17d4bb5e1
BUG: 1048216
Signed-off-by: Vijaikumar M <vmallika@redhat.com>
|
|\ \ |
|
| |/
| |
| |
| |
| | |
Change-Id: Id98d6e2d0436621486c311889f128077558e59f8
Signed-off-by: Sachin Pandit <spandit@redhat.com>
|
|\ \
| | |
| | |
| | | |
into development
|
| | |
| | |
| | |
| | |
| | | |
Change-Id: I34cf0f2ee42074bb40edda875e0b290069d856ae
Signed-off-by: Raghavendra Bhat <raghavendra@redhat.com>
|
| |/
|/|
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Implemented gluster snapshot restore feature. The restore is done
by replacing the origin volume with the snap volume.
TODO: After the restore the snapshot volume should be deleted. As of
now the deletion work is pending.
Change-Id: Ib137fb6bb84a74030607ffa47f89cd705dc7e1ff
Signed-off-by: Rajesh Joseph <rjoseph@redhat.com>
|
|/
|
|
|
|
|
|
|
|
|
|
|
| |
snap-max-hard-limit.
This patch also prohibits configuration of snap-max-hard-limit
and snap-max-soft-limit for snap volumes. Also displaying the
snapshot configs by reading data only from local node, as all
config data will be in sync across the cluster.
Change-Id: I635b925c02ed5b108cd10c7193b154ad82d5afad
BUG: 1043792
Signed-off-by: Avra Sengupta <asengupt@redhat.com>
|
|\
| |
| |
| | |
commands" into development
|
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Currently "gluster help" only list the volume and peer command family.
With this fix it will also list the usage for snapshot commands.
Change-Id: I75601496e4f027250c2381eff94e4283bb98299a
BUG: 1043472
Signed-off-by: Vijaikumar M <vmallika@redhat.com>
|
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Note: Manually adding this patch again as this patch got missed in
git reset option done on remote development branch
Change-Id: I9e81c5ec003c1e1722d0fcb27dd87c365ee43ff4
Signed-off-by: Avra Sengupta <asengupt@redhat.com>
Signed-off-by: Rajesh Joseph <rjoseph@redhat.com>
|
|/
|
|
|
|
|
|
|
|
|
|
|
| |
CG ID was not getting initiated during snapshot create,
hence there was problem in listing the CG ID and CG Name.
Note: Manually adding this patch again as this patch got missed in
git reset option done on remote development branch
Change-Id: I81951b42292912c98bab5964fc732b630ff66d14
BUG: 1040435
Signed-off-by: Sachin Pandit <spandit@redhat.com>
Signed-off-by: Rajesh Joseph <rjoseph@redhat.com>
|
|
|
|
|
| |
Change-Id: Icdb66c89acdd043d0d6368c48ce2e01b1a40966f
Signed-off-by: Raghavendra Bhat <raghavendra@redhat.com>
|
|
|
|
|
|
|
|
|
| |
This patch fixes the below mentioned issue.
Snapshot list : Listing number of snaps available.
Display proper message if snapshot not present.
Change-Id: Iabfc47430a9c89fb5114e33e9feb7ef21973fc6a
Signed-off-by: Sachin Pandit <spandit@redhat.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Minor changes to the type of few varaibles was required
as comparison between "unsigned int" and "int"
in "snap create parse" was leading to incorrect result.
The default snapshot name should be time stamp,
instead of that "snapshot" was getting assigned
as a snapshot name. This patch also fixes the
default snapshot name problem.
Change-Id: I5b48444059bc400717b35647edec08a444bcfc48
Signed-off-by: Sachin Pandit <spandit@redhat.com>
|
|
|
|
|
| |
Change-Id: I2a0b7e244256f1df82beb3e4815d6cacfee50603
Signed-off-by: Sachin Pandit <spandit@redhat.com>
|
|
|
|
|
|
|
|
|
| |
If user tries to list the snap details of volumes
which does not exist, then corresponding error
message is displayed.
Change-Id: I205738be3dc632ccb074b639a2088cdd44aa35a7
Signed-off-by: Sachin Pandit <spandit@redhat.com>
|
|
|
|
|
| |
Change-Id: I6fd89a98c4a111bb6cd3e4d3c2b3d6f783661c27
Signed-off-by: shishir gowda <sgowda@redhat.com>
|
|
|
|
|
|
|
| |
Also fixes snapshot config output
Change-Id: Ia50d94492009cf73dbb99ba20117b9fa4c41048a
Signed-off-by: Avra Sengupta <asengupt@redhat.com>
|
|
|
|
|
|
|
|
|
|
|
|
| |
GL-31: Ability to restore snapshot
Implemented snapshot restore for thin logical volume. As of now snapshot
restore for CG is not tested. Testing for snapshot restore of a volume
is done by changing the snapshot create process to create a thick snapshot.
This is done because --merge option to restore thin volume is not working in
the latest kernel.
Change-Id: Ia3ded7e6c4da5957a74e269a25ba3200e6fb2d8b
Signed-off-by: Rajesh Joseph <rjoseph@redhat.com>
|
|
|
|
|
|
|
|
|
| |
* Also send the proper error back to cli incase of any failure
* Before taking the snap check whether a snap with the requested name
already exists.
Change-Id: I0830b31b1f095dd1d3d968c4f8b3cf46dc32d259
Signed-off-by: Raghavendra Bhat <raghavendra@redhat.com>
|
|
|
|
|
| |
Change-Id: I16b17ca60b5f9b34b7d238d8a3424a3b7a1dc435
Signed-off-by: shishir gowda <sgowda@redhat.com>
|
|
|
|
|
|
|
|
| |
Also refactored code in glusterd for create command
Additionally, removed brick-op func from mgmt_iniate_all_phases
Change-Id: Iddcc332009c5716adee7f2b04c93b352fb983446
Signed-off-by: shishir gowda <sgowda@redhat.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Change in Naming convention:
"snap_details", "snap_count" and so on
is replaced by "snap-details", "snap-count" so on.
Total snapcount introduced.
Separate check is made for repeated Volume Name
Ex : "gluster snapshot list vol1 vol2 vol1 vol2"
is considered as "gluster snapshot list vol1 vol2"
*This is still a work in progress*
*have to test CG list once CG Store is ready*
Change-Id: I45e2904eb8bdbf78de8665f20ba9605c38320307
Signed-off-by: Sachin Pandit <spandit@redhat.com>
|
|
|
|
|
| |
Change-Id: Iafbd0ec95de0c41455fb79953fb4bb07721334a5
Signed-off-by: shishir gowda <sgowda@redhat.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
$gluster snapshot list
*prints snaps of all volume*
$gluster snapshot list -d
*prints snaps of all volume with details*
$gluster snapshot list vol1
*prints snaps of volume "vol1"*
$gluster snapshot list vol1 -d
*prints snaps of volume "vol1" with details*
$gluster snapshot list vol1 vol2
*prints snaps of volume "vol1" & "vol2"
$gluster snapshot list vol1 vol2 -d
*prints snaps of volume "vol1" & "vol2" with details*
$gluster snapshot list -c cgname
*prints snaps of all volume present in the group "cgname"*
$gluster snapshot list -c cgname -d
*prints snaps of all volume present in the group "cgname" with details*
** As of now you wont be able to see any output as actual snap create is not integrated **
Change-Id: I60eeafc715a51f1c564a270bb4124368038012b1
Signed-off-by: Sachin Pandit <spandit@redhat.com>
|
|
|
|
|
|
|
| |
Also linking snap create command to mgmt_v3
Change-Id: If2ed29be072e10d0b0bd271d53e48eeaa6501ed7
Signed-off-by: Avra Sengupta <asengupt@redhat.com>
|