summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorAshish Pandey <aspandey@redhat.com>2015-06-17 12:40:06 +0530
committerPranith Kumar Karampuri <pkarampu@redhat.com>2015-06-22 23:06:27 -0700
commite8847bd0ba03616bf80f242fda22e104ff2ea0e3 (patch)
tree9d05c98c3f82b10a201b9fb9e56be577630735e2
parentd65a334691fd339b770114a35edd4d14e9db2678 (diff)
ec: Display correct message after successful heal start
Problem : While launching heal, it shows heal launch was unsuccessful. However, internaly it was successfully launched. Solution : Don't reset op_ret to -1 in for loop for every brick. Change-Id: Iff89fdaf6082767ed67523a56430a9e83e6984d3 BUG: 1203089 Signed-off-by: Ashish Pandey <aspandey@redhat.com> Reviewed-on: http://review.gluster.org/11267 Reviewed-by: Xavier Hernandez <xhernandez@datalab.es> Tested-by: NetBSD Build System <jenkins@build.gluster.org>
-rw-r--r--xlators/cluster/ec/src/ec-heald.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/xlators/cluster/ec/src/ec-heald.c b/xlators/cluster/ec/src/ec-heald.c
index a7cf8f7bd30..bfdf9597e0e 100644
--- a/xlators/cluster/ec/src/ec-heald.c
+++ b/xlators/cluster/ec/src/ec-heald.c
@@ -541,10 +541,10 @@ ec_heal_op (xlator_t *this, dict_t *output, gf_xl_afr_op_t op, int xl_id)
ec = this->private;
+ op_ret = -1;
for (i = 0; i < ec->nodes; i++) {
snprintf (key, sizeof (key), "%d-%d-status", xl_id, i);
- op_ret = -1;
if (((ec->xl_up >> i) & 1) == 0) {
ret = dict_set_str (output, key, "Brick is not connected");
} else if (!ec->up) {