core: fedora 30 compiler warnings

warning: ‘%s’ directive argument is null [-Wformat-overflow=]

Change-Id: I69b8d47f0002c58b00d1cc947fac6f1c64e0b295
updates: bz#1193929
Signed-off-by: SheetalPamecha <spamecha@redhat.com>

7 files changed, 10 insertions, 14 deletions

diff --git a/glusterfsd/src/glusterfsd-mgmt.c b/glusterfsd/src/glusterfsd-mgmt.c
index 1d2cd1ae6e1..e1fbe5d7234 100644
--- a/glusterfsd/src/glusterfsd-mgmt.c
+++ b/glusterfsd/src/glusterfsd-mgmt.c
@@ -1336,7 +1336,6 @@ glusterfs_handle_brick_status(rpcsvc_request_t *req)
     xlator_t *brick_xl = NULL;
     dict_t *dict = NULL;
     dict_t *output = NULL;
-    char *xname = NULL;
     uint32_t cmd = 0;
     char *msg = NULL;
     char *brickname = NULL;
@@ -1399,7 +1398,7 @@ glusterfs_handle_brick_status(rpcsvc_request_t *req)
 
     brick_xl = get_xlator_by_name(server_xl, brickname);
     if (!brick_xl) {
-        gf_log(this->name, GF_LOG_ERROR, "xlator %s is not loaded", xname);
+        gf_log(this->name, GF_LOG_ERROR, "xlator is not loaded");
         ret = -1;
         goto out;
     }
@@ -1462,7 +1461,6 @@ out:
         dict_unref(output);
     free(brick_req.input.input_val);
     free(brick_req.name);
-    GF_FREE(xname);
     GF_FREE(msg);
     GF_FREE(rsp.output.output_val);
 
diff --git a/libglusterfs/src/graph.y b/libglusterfs/src/graph.y
index 56cab044266..e63febdc08b 100644
--- a/libglusterfs/src/graph.y
+++ b/libglusterfs/src/graph.y
@@ -123,7 +123,7 @@ new_volume (char *name)
         int          ret = 0;
 
         if (!name) {
-                gf_msg_debug ("parser", 0,"Invalid argument name: '%s'", name);
+                gf_msg_debug ("parser", 0,"Invalid argument name");
                 ret = -1;
                 goto out;
         }
diff --git a/rpc/rpc-transport/rdma/src/rdma.c b/rpc/rpc-transport/rdma/src/rdma.c
index bb36dac67f8..61e6eea1d49 100644
--- a/rpc/rpc-transport/rdma/src/rdma.c
+++ b/rpc/rpc-transport/rdma/src/rdma.c
@@ -4160,7 +4160,7 @@ gf_rdma_handle_failed_send_completion(gf_rdma_peer_t *peer, struct ibv_wc *wc)
            "send work request on `%s' returned error "
            "wc.status = %d, wc.vendor_err = %d, post->buf = %p, "
            "wc.byte_len = %d, post->reused = %d",
-           (device != NULL) ? device->device_name : NULL, wc->status,
+           (device != NULL) ? device->device_name : "", wc->status,
            wc->vendor_err, post->buf, wc->byte_len, post->reused);
 
     if (wc->status == IBV_WC_RETRY_EXC_ERR) {
diff --git a/xlators/features/snapview-server/src/snapview-server.c b/xlators/features/snapview-server/src/snapview-server.c
index 52273c995c7..ad5c2baad12 100644
--- a/xlators/features/snapview-server/src/snapview-server.c
+++ b/xlators/features/snapview-server/src/snapview-server.c
@@ -997,8 +997,8 @@ svs_getxattr(call_frame_t *frame, xlator_t *this, loc_t *loc, const char *name,
                 op_errno = ENOMEM;
                 gf_msg(this->name, GF_LOG_ERROR, op_errno, SVS_MSG_NO_MEMORY,
                        "failed to add xattrs from the list to "
-                       "dict for %s (gfid: %s, key: %s)",
-                       loc->path, uuid_utoa(loc->inode->gfid), name);
+                       "dict for %s (gfid: %s)",
+                       loc->path, uuid_utoa(loc->inode->gfid));
                 goto out;
             }
             GF_FREE(value);
@@ -1179,8 +1179,8 @@ svs_fgetxattr(call_frame_t *frame, xlator_t *this, fd_t *fd, const char *name,
                 op_errno = ENOMEM;
                 gf_msg(this->name, GF_LOG_ERROR, op_errno, SVS_MSG_NO_MEMORY,
                        "failed to add xattrs from the list "
-                       "to dict (gfid: %s, key: %s)",
-                       uuid_utoa(fd->inode->gfid), name);
+                       "to dict (gfid: %s)",
+                       uuid_utoa(fd->inode->gfid));
                 goto out;
             }
             GF_FREE(value);
diff --git a/xlators/mgmt/glusterd/src/glusterd-snapshot.c b/xlators/mgmt/glusterd/src/glusterd-snapshot.c
index ec630d55469..e8e342b6f6c 100644
--- a/xlators/mgmt/glusterd/src/glusterd-snapshot.c
+++ b/xlators/mgmt/glusterd/src/glusterd-snapshot.c
@@ -7709,7 +7709,6 @@ glusterd_snapshot_status_commit(dict_t *dict, char **op_errstr,
     xlator_t *this = NULL;
     int ret = -1;
     glusterd_conf_t *conf = NULL;
-    char *get_buffer = NULL;
     int32_t cmd = -1;
     char *snapname = NULL;
     glusterd_snap_t *snap = NULL;
@@ -7778,8 +7777,7 @@ glusterd_snapshot_status_commit(dict_t *dict, char **op_errstr,
             if (ret) {
                 gf_msg(this->name, GF_LOG_ERROR, 0, GD_MSG_SNAP_STATUS_FAIL,
                        "Unable to "
-                       "get status of snap %s",
-                       get_buffer);
+                       "get status of snap");
                 goto out;
             }
 
diff --git a/xlators/mgmt/glusterd/src/glusterd.c b/xlators/mgmt/glusterd/src/glusterd.c
index 6d7dd4a82d5..131a3c2b7f2 100644
--- a/xlators/mgmt/glusterd/src/glusterd.c
+++ b/xlators/mgmt/glusterd/src/glusterd.c
@@ -1085,7 +1085,7 @@ err:
 
     gf_msg("glusterd", GF_LOG_ERROR, 0, GD_MSG_MOUNT_SPEC_INSTALL_FAIL,
            "adding %smount spec failed: label: %s desc: %s",
-           georep ? GEOREP " " : "", label, pdesc);
+           georep ? GEOREP " " : "", label, pdesc ? pdesc : "");
 
     if (mspec) {
         if (mspec->patterns) {
diff --git a/xlators/storage/posix/src/posix-entry-ops.c b/xlators/storage/posix/src/posix-entry-ops.c
index aab88f0d20a..3c070de3929 100644
--- a/xlators/storage/posix/src/posix-entry-ops.c
+++ b/xlators/storage/posix/src/posix-entry-ops.c
@@ -890,7 +890,7 @@ posix_add_unlink_to_ctx(inode_t *inode, xlator_t *this, char *unlink_path)
 
     if (!unlink_path) {
         gf_msg(this->name, GF_LOG_ERROR, ENOMEM, P_MSG_UNLINK_FAILED,
-               "Creation of unlink entry failed for gfid: %s", unlink_path);
+               "Creation of unlink entry failed");
         ret = -1;
         goto out;
     }