summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorSunny Kumar <sunkumar@redhat.com>2018-08-20 17:54:32 +0530
committerAmar Tumballi <amarts@redhat.com>2018-09-25 17:04:51 +0000
commitc006434c4f6d5762e826bd2ecc414b6d332d66c9 (patch)
tree808c97fdcb88871bf3b0fd8f2c91411e03b107b7
parent62164ac0d242a271f19b0e0bb352af5f7df082ce (diff)
nfs : fix coverity issues
Fixes 1388608 and 1274073. updates: bz#789278 Change-Id: Ibe2b948ae3b02feb938caffe81b2e484b4c7b221 Signed-off-by: Sunny Kumar <sunkumar@redhat.com>
-rw-r--r--xlators/nfs/server/src/nfs-fops.c4
-rw-r--r--xlators/nfs/server/src/nlm4.c6
2 files changed, 7 insertions, 3 deletions
diff --git a/xlators/nfs/server/src/nfs-fops.c b/xlators/nfs/server/src/nfs-fops.c
index 9abb2ac4eeb..e78cef7f0b4 100644
--- a/xlators/nfs/server/src/nfs-fops.c
+++ b/xlators/nfs/server/src/nfs-fops.c
@@ -121,6 +121,10 @@ nfs_fop_local_init(xlator_t *nfsx)
return NULL;
l = mem_get(nfs_fop_mempool(nfsx));
+ if (!l) {
+ gf_msg_nomem(GF_NFS, GF_LOG_ERROR, 4096);
+ return NULL;
+ }
memset(l, 0, sizeof(*l));
return l;
diff --git a/xlators/nfs/server/src/nlm4.c b/xlators/nfs/server/src/nlm4.c
index 873f350a91f..6fd952fd338 100644
--- a/xlators/nfs/server/src/nlm4.c
+++ b/xlators/nfs/server/src/nlm4.c
@@ -1403,8 +1403,8 @@ nlm4svc_lock_cbk(call_frame_t *frame, void *cookie, xlator_t *this,
stat = nlm4_granted;
if (cs->monitor && !nlm_monitor(caller_name)) {
/* FIXME: handle nsm_monitor failure */
- gf_thread_create(&thr, NULL, nsm_monitor, (void *)caller_name,
- "nlmmon");
+ (void)gf_thread_create(&thr, NULL, nsm_monitor, (void *)caller_name,
+ "nlmmon");
}
}
@@ -2699,7 +2699,7 @@ nlm4svc_init(xlator_t *nfsx)
goto err;
}
- gf_thread_create(&thr, NULL, nsm_thread, (void *)NULL, "nfsnsm");
+ (void)gf_thread_create(&thr, NULL, nsm_thread, (void *)NULL, "nfsnsm");
timeout.tv_sec = nlm_grace_period;
timeout.tv_nsec = 0;