summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorRaghavendra Talur <rtalur@redhat.com>2014-04-29 14:28:29 +0530
committerVijay Bellur <vbellur@redhat.com>2014-05-02 20:42:30 -0700
commitf48656b32e328f96bda5aade55070867d5faf333 (patch)
tree461e9d18f3b6f7334cc9c7253307f636ef9e36c1
parentc7838fbd6afd876c922e1ec681bbbcf73be653e5 (diff)
extras/hookscripts: Remove %P from smb share path value.
We had added %P in the value for path in smb share definitions to avoid ctdb errors. However, %P does not work well for windows clients and they fail to access the share. Solution for the original problem: The error messages were being generated by a monitoring script that ctdb runs. The script reads the path value from testparm and tests if it exists in the local machine. This particular check does not hold valid for virtual file system backends like gluster. There is no harm in asking ctdb to not to check the existence of such backend and can be done by setting the following config in ctdb.conf: CTDB_SAMBA_SKIP_SHARE_CHECK=YES. Change-Id: I91627c8a279126a5cc24c6347847f9bfbad53dd5 BUG: 1068776 Signed-off-by: Raghavendra Talur <rtalur@redhat.com> Reviewed-on: http://review.gluster.org/7598 Reviewed-by: Jose A. Rivera <jarrpa@redhat.com> Reviewed-by: Poornima G <pgurusid@redhat.com> Tested-by: Gluster Build System <jenkins@build.gluster.com> Reviewed-by: Harshavardhana <harsha@harshavardhana.net>
-rwxr-xr-xextras/hook-scripts/set/post/S30samba-set.sh2
-rwxr-xr-xextras/hook-scripts/start/post/S30samba-start.sh2
2 files changed, 2 insertions, 2 deletions
diff --git a/extras/hook-scripts/set/post/S30samba-set.sh b/extras/hook-scripts/set/post/S30samba-set.sh
index 88f6e797b40..36858fafb70 100755
--- a/extras/hook-scripts/set/post/S30samba-set.sh
+++ b/extras/hook-scripts/set/post/S30samba-set.sh
@@ -79,7 +79,7 @@ function add_samba_share () {
STRING+="glusterfs:volume = $volname\n"
STRING+="glusterfs:logfile = $LOGFILEBASE/glusterfs-$volname.%%M.log\n"
STRING+="glusterfs:loglevel = 7\n"
- STRING+="path = %%P/\n"
+ STRING+="path = /\n"
STRING+="read only = no\n"
STRING+="guest ok = yes\n"
printf "$STRING" >> ${CONFIGFILE}
diff --git a/extras/hook-scripts/start/post/S30samba-start.sh b/extras/hook-scripts/start/post/S30samba-start.sh
index 529348e25c4..34fde0ef8c0 100755
--- a/extras/hook-scripts/start/post/S30samba-start.sh
+++ b/extras/hook-scripts/start/post/S30samba-start.sh
@@ -65,7 +65,7 @@ function add_samba_share () {
STRING+="glusterfs:volume = $volname\n"
STRING+="glusterfs:logfile = $LOGFILEBASE/glusterfs-$volname.%%M.log\n"
STRING+="glusterfs:loglevel = 7\n"
- STRING+="path = %%P/\n"
+ STRING+="path = /\n"
STRING+="read only = no\n"
STRING+="guest ok = yes\n"
printf "$STRING" >> ${CONFIGFILE}