diff options
| author | Kaleb S KEITHLEY <kkeithle@redhat.com> | 2016-06-13 11:34:51 -0400 |
|---|---|---|
| committer | Jeff Darcy <jdarcy@redhat.com> | 2016-06-14 18:30:21 -0700 |
| commit | e740b700975bdb1014ede99c65731095bdf81a72 (patch) | |
| tree | 781f8da0f91339282c98ea848a264550831fb121 /api/src/glfs.h | |
| parent | 04828f569eede11e11433bf099dbb7cb39c3f3b9 (diff) | |
api: use versioned symbols for minor ABI change
No need to expand the API/ABI. E.g., see how glfs_lookupat
changed between 3.7.0 and 3.7.4 IIRC
(I originally argued against versioning the library. I wanted
to just add new functions as they were needed, as was initially
done for glfs_ipc and glfs_ipc_xd in the master branch for 4.0.
But others strongly wanted versioning.)
Having made the decision to use versioning, I believe we should
continue. At least until we have a public decision that we're
no longer going to use versioning.
Change-Id: I0c3b2c1cbb297ae2b2864b647c224922987d74ad
Signed-off-by: Kaleb S KEITHLEY <kkeithle@redhat.com>
Reviewed-on: http://review.gluster.org/14717
Reviewed-by: Shyamsundar Ranganathan <srangana@redhat.com>
Smoke: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
Diffstat (limited to 'api/src/glfs.h')
| -rw-r--r-- | api/src/glfs.h | 9 |
1 files changed, 3 insertions, 6 deletions
diff --git a/api/src/glfs.h b/api/src/glfs.h index d3bf1b4cdcc..bf6dd6cd566 100644 --- a/api/src/glfs.h +++ b/api/src/glfs.h @@ -72,7 +72,6 @@ __BEGIN_DECLS struct glfs; typedef struct glfs glfs_t; - /* SYNOPSIS @@ -770,12 +769,10 @@ glfs_fd_t *glfs_dup (glfs_fd_t *fd) __THROW GFAPI_PUBLIC(glfs_dup, 3.4.0); /* - * No xdata support for now. Nobody needs this call at all yet except for the - * test script, and that doesn't need xdata. Adding dict_t support and a new - * header-file requirement doesn't seem worth it until the need is greater. + * Nobody needs this call at all yet except for the test script. */ -int glfs_ipc (glfs_fd_t *fd, int cmd) __THROW - GFAPI_PUBLIC(glfs_ipc, 3.7.0); +int glfs_ipc (glfs_fd_t *fd, int cmd, void *xd_in, void **xd_out) __THROW + GFAPI_PUBLIC(glfs_ipc, 4.0.0); __END_DECLS |