diff options
| author | Richard Wareing <rwareing@fb.com> | 2015-11-24 20:45:23 -0800 |
|---|---|---|
| committer | Jeff Darcy <jeff@pl.atyp.us> | 2017-08-28 17:05:09 +0000 |
| commit | ddd37db74fdda99874e9087b43a106a72ec256f8 (patch) | |
| tree | c3f1a23a0b7d8335b19b0f2cf382f5f871e09891 /cli/src/cli-cmd-snapshot.c | |
| parent | af38bab4e6185f97f84fbfe096d85d8ec4727846 (diff) | |
features/locks: Fix crash bug in connection (lock) clean-up flow
Summary:
- Fixes crash bug where bricks can crash when the "clear locks" command is run
(by CLI or by revocation code) and sockets are later cleaned-up
causing bricks to crash. Crash bug is due to use-after-free due to
refs being left to the lock in the client-list. When this list is
later traversed it triggers a crash as pointers are now pointing to
garbage.
Test Plan:
- Ran with monkey-unlock and tested connection clean-ups after lock
revocation
Reviewers: sshreyas, dph, moox
Reviewed By: moox
Differential Revision: https://phabricator.fb.com/D2695087
Tasks: 6207062
Change-Id: Iea26efe4bfbadc26431a3c50a0a8bda218bb5219
Signed-off-by: Jeff Darcy <jdarcy@fb.com>
Reviewed-on: https://review.gluster.org/18122
Smoke: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Jeff Darcy <jeff@pl.atyp.us>
Tested-by: Jeff Darcy <jeff@pl.atyp.us>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Diffstat (limited to 'cli/src/cli-cmd-snapshot.c')
0 files changed, 0 insertions, 0 deletions