summaryrefslogtreecommitdiffstats
path: root/cli
diff options
context:
space:
mode:
authorYaniv Kaul <ykaul@redhat.com>2018-11-15 22:05:32 +0200
committerYaniv Kaul <ykaul@redhat.com>2018-12-30 11:59:27 +0000
commit3ce7b5dbf069e7bf09c3470753c21efe03339291 (patch)
treee0d34b5d352bb342aaa6a1fd6a39f5a66cc0f2ae /cli
parent36883e160e07466929c2fe7d6050403751d25a49 (diff)
libglusterfs/src/mem-types.h: remove unused common enums from mem-types.h
They were not used at all, just taking space. I've also marked all those that are not common really, but used in just one place - they probably should move there (in follow-up patches) As a test, I've removed from the stripe xlator unused private enums and moved one that was in the common list, but only used in the stripe code, to be a private enum. Compile-tested only! updates: bz#1193929 Signed-off-by: Yaniv Kaul <ykaul@redhat.com> Change-Id: I1158dc1d259f1fd3f69904336c46c9d83cea799f
Diffstat (limited to 'cli')
-rw-r--r--cli/src/cli-cmd-volume.c9
1 files changed, 1 insertions, 8 deletions
diff --git a/cli/src/cli-cmd-volume.c b/cli/src/cli-cmd-volume.c
index 11dd0735322..81e49dc5238 100644
--- a/cli/src/cli-cmd-volume.c
+++ b/cli/src/cli-cmd-volume.c
@@ -1557,7 +1557,7 @@ cli_cmd_quota_handle_list_all(const char **words, dict_t *options)
cli_local_t *local = NULL;
call_frame_t *frame = NULL;
dict_t *xdata = NULL;
- char *gfid_str = NULL;
+ char gfid_str[UUID_CANONICAL_FORM_LEN + 1];
char *volname = NULL;
char *volname_dup = NULL;
unsigned char buf[16] = {0};
@@ -1661,12 +1661,6 @@ cli_cmd_quota_handle_list_all(const char **words, dict_t *options)
CLI_LOCAL_INIT(local, words, frame, xdata);
proc = &cli_quotad_clnt.proctable[GF_AGGREGATOR_GETLIMIT];
- gfid_str = GF_CALLOC(1, gf_common_mt_char, 64);
- if (!gfid_str) {
- ret = -1;
- goto out;
- }
-
for (count = 0;; count++) {
ret = quota_conf_read_gfid(fd, buf, &gfid_type, version);
if (ret == 0) {
@@ -1772,7 +1766,6 @@ out:
sys_close(fd);
}
- GF_FREE(gfid_str);
if (ret) {
gf_log("cli", GF_LOG_ERROR,
"Could not fetch and display quota"