summaryrefslogtreecommitdiffstats
path: root/doc/developer-guide/coding-standard.md
diff options
context:
space:
mode:
authorShyam <srangana@redhat.com>2017-04-05 14:22:57 -0400
committerShyamsundar Ranganathan <srangana@redhat.com>2017-04-10 14:59:30 -0400
commit226c841bad19d0348acba22808cc65853c2b15ea (patch)
treee502ec50ce6f7c89b191273847e7d5502c4237dc /doc/developer-guide/coding-standard.md
parent826152055ff732b9c71f7766e0e197263b9fce95 (diff)
scripts: Update rfc.sh to check existance of Change-Id in backports
Addition to this script is a no-op on master. This would need to be backported to active release branches to be effective. This check is not smart proof, in that someone could proceed knowing that the Change-Id differs from master, but this is not expected to catch that, instead it is to serve more as a reminder that we need the same Change-Id across branches. Contributors not using rfc.sh would not see this, but they are few and possibly far in between. Also contributors using gerrit to cherry-pick changes will not see this. For both cases a server side solution to catch any changes are needed. There is a possiblilty that we will follow this up with a check on the gerrit end and add a comment to the reviews, to aid reviewers to quickly check the sanity of the Change-Id when it differs. > BUG: 1428047 > Signed-off-by: Shyam <srangana@redhat.com> > Reviewed-on: https://review.gluster.org/17004 > Smoke: Gluster Build System <jenkins@build.gluster.org> > Reviewed-by: Niels de Vos <ndevos@redhat.com> > NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org> > CentOS-regression: Gluster Build System <jenkins@build.gluster.org> > Reviewed-by: Kaleb KEITHLEY <kkeithle@redhat.com> > Reviewed-by: Amar Tumballi <amarts@redhat.com> Change-Id: I11e371489a4a3cf2ff96d9892256986cd535998b BUG: 1440805 Signed-off-by: Shyam <srangana@redhat.com> Reviewed-on: https://review.gluster.org/17030 Smoke: Gluster Build System <jenkins@build.gluster.org> Reviewed-by: Niels de Vos <ndevos@redhat.com> NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org> CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Diffstat (limited to 'doc/developer-guide/coding-standard.md')
0 files changed, 0 insertions, 0 deletions