summaryrefslogtreecommitdiffstats
path: root/glusterfsd
diff options
context:
space:
mode:
authorMohit Agrawal <moagrawal@redhat.com>2018-11-30 16:07:39 +0530
committerAmar Tumballi <amarts@redhat.com>2019-01-14 04:01:54 +0000
commit211521f039bb5c883ef444577b5962bad9e18be1 (patch)
tree82c748d0a3217ebb7b3bb7ce997b11f6ec0b65d1 /glusterfsd
parent8216ed2171789c8b6c6dc1e44cc171c89b1c063d (diff)
core: Resolve dict_leak at the time of destroying graph
Problem: In gluster code some of the places it call's get_new_dict to create a dictionary without taking reference so at the time of dict_unref it has become a leak Solution: To resolve the same call dict_new instead of get_new_dict updates bz#1650403 Change-Id: I3ccbbf5af07079a4fa09aad2cd0458c8625b2f06 Signed-off-by: Mohit Agrawal <moagrawal@redhat.com>
Diffstat (limited to 'glusterfsd')
-rw-r--r--glusterfsd/src/glusterfsd.c3
1 files changed, 1 insertions, 2 deletions
diff --git a/glusterfsd/src/glusterfsd.c b/glusterfsd/src/glusterfsd.c
index 42731660485..df5b9ed0b31 100644
--- a/glusterfsd/src/glusterfsd.c
+++ b/glusterfsd/src/glusterfsd.c
@@ -725,7 +725,7 @@ create_fuse_mount(glusterfs_ctx_t *ctx)
}
master->ctx = ctx;
- master->options = get_new_dict();
+ master->options = dict_new();
if (!master->options)
goto err;
@@ -2644,7 +2644,6 @@ out:
/* Take dict ref for every graph xlator to avoid dict leak
at the time of graph destroying
*/
- gluster_graph_take_reference(graph->first);
glusterfs_graph_fini(graph);
glusterfs_graph_destroy(graph);
}