diff options
| author | Ashish Pandey <aspandey@redhat.com> | 2016-02-17 15:57:02 +0530 |
|---|---|---|
| committer | Pranith Kumar Karampuri <pkarampu@redhat.com> | 2016-03-30 01:51:11 -0700 |
| commit | 7bbcd6fb692dffc628b723eace8cfcfa466e606f (patch) | |
| tree | bc94cffe889a20851d813de0abb7f54bb1db1b6b /libglusterfs | |
| parent | 207289621f6c5b75bdb80aa14ddaf72efd5eb9b1 (diff) | |
cluster/ec: Rebalance hangs during rename
Problem:
During the rename of a particular file (ec
is holding blocking inodelk on the parent
directory), if the rename of another file
under the same directory comes. EC does not
release the lock and goes ahead and renames
the "new" file with the "already held lock".
That causes rebalance process to be blocked
on a lock which has been acquired by rename.
Solution:
While rename fop comes, ec takes blocking inodelk
on old and new parent of the file. Before releasing,
every lock held by ec, it waits for some "time" to
see if that lock can be reused by the next fop.
If within this "time" some other request comes,
it releases this lock based on condition
"lock count > 1"
To get this "lock count" for rename fop, we have
implemented "pl_rename" in feature/lock. Also,
on ec side, changed the condition to release the lock
based on the type of fop and old and new parent
directories.
Change-Id: I979dbab1185df962e8f305a6074ae1186ffe7db0
Bug: 1304988
Signed-off-by: Ashish Pandey <aspandey@redhat.com>
Reviewed-on: http://review.gluster.org/13460
Smoke: Gluster Build System <jenkins@build.gluster.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
Reviewed-by: Krutika Dhananjay <kdhananj@redhat.com>
Diffstat (limited to 'libglusterfs')
| -rw-r--r-- | libglusterfs/src/glfs-message-id.h | 4 |
1 files changed, 4 insertions, 0 deletions
diff --git a/libglusterfs/src/glfs-message-id.h b/libglusterfs/src/glfs-message-id.h index d002fd57fb7..a521b7be9ec 100644 --- a/libglusterfs/src/glfs-message-id.h +++ b/libglusterfs/src/glfs-message-id.h @@ -166,6 +166,10 @@ GLFS_MSGID_COMP_SYMLINK_CACHE_END #define GLFS_MSGID_COMP_NSR GLFS_MSGID_COMP_SHARD_END #define GLFS_MSGID_COMP_NSR_END (GLFS_MSGID_COMP_SHARD_END+\ GLFS_MSGID_SEGMENT) + +#define GLFS_MSGID_COMP_PL GLFS_MSGID_COMP_NSR_END +#define GLFS_MSGID_COMP_PL_END (GLFS_MSGID_COMP_PL +\ + GLFS_MSGID_SEGMENT) /* --- new segments for messages goes above this line --- */ #endif /* !_GLFS_MESSAGE_ID_H_ */ |