diff options
author | nik-redhat <nladha@redhat.com> | 2020-07-03 17:18:33 +0530 |
---|---|---|
committer | Ravishankar N <ravishankar@redhat.com> | 2020-07-08 05:28:05 +0000 |
commit | 24ea814fe7d5a5d27fa051d20ab85bc18c051bdc (patch) | |
tree | 3cdf25d04bbacf9ed97083b4afe8b6659765e1ee /xlators/cluster/afr/src/afr-self-heal-name.c | |
parent | 0a2de3f7f9aafadf0b20197eae2be96275271b97 (diff) |
afr: null dereference & nagative value
Added a check for NULL before dereferencing
the object as it may be NULL in few cases
inside the funtion. Also, added a check for
the negative value of gfid_idx.
CID: 1430140
CID: 1430145
Change-Id: Ib7d23459b48bbc471dbcccab6d20572261882d11
Updates: #1060
Signed-off-by: nik-redhat <nladha@redhat.com>
Diffstat (limited to 'xlators/cluster/afr/src/afr-self-heal-name.c')
-rw-r--r-- | xlators/cluster/afr/src/afr-self-heal-name.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/xlators/cluster/afr/src/afr-self-heal-name.c b/xlators/cluster/afr/src/afr-self-heal-name.c index dace07131cb..dd40c57ab12 100644 --- a/xlators/cluster/afr/src/afr-self-heal-name.c +++ b/xlators/cluster/afr/src/afr-self-heal-name.c @@ -381,7 +381,7 @@ __afr_selfheal_name_do(call_frame_t *frame, xlator_t *this, inode_t *parent, ret = __afr_selfheal_assign_gfid(this, parent, pargfid, bname, inode, replies, gfid, locked_on, source, sources, is_gfid_absent, &gfid_idx); - if (ret) + if (ret || (gfid_idx < 0)) return ret; ret = __afr_selfheal_name_impunge(frame, this, parent, pargfid, bname, |