diff options
author | Anoop C S <anoopcs@redhat.com> | 2020-06-20 13:26:13 +0530 |
---|---|---|
committer | Amar Tumballi <amar@kadalu.io> | 2020-07-02 03:51:49 +0000 |
commit | 906e208c594f81e660db1a568a7afe010d4a3ee9 (patch) | |
tree | 102bb5f0bc86b879257b4d8d3f8535bd5c11b4fd /xlators/features | |
parent | 3de4627dcf18a3d9654f52fd609f1da90eee706b (diff) |
build: Pass $(LIB_DL) using prog_LDADD or lib_LIBADD
"Program and Library Variables" section from Automake manual suggests
the following:
. . .
_LDADD and _LIBADD are inappropriate for passing program-specific linker
flags (except for -l, -L, -dlopen and -dlpreopen). Use the _LDFLAGS
variable for this purpose.
. . .
Therefore it is reasonable to move $(LIB_DL) additon from _LDFLAGS to
_LDADD and _LIBADD variables for program and library respectively.
Change-Id: Id8b4734c207ab28a08bcce683d316cdc7acb0bcd
Updates: #1000
Signed-off-by: Anoop C S <anoopcs@redhat.com>
Diffstat (limited to 'xlators/features')
-rw-r--r-- | xlators/features/cloudsync/src/Makefile.am | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/xlators/features/cloudsync/src/Makefile.am b/xlators/features/cloudsync/src/Makefile.am index 0c3966c968b..e2a277e372b 100644 --- a/xlators/features/cloudsync/src/Makefile.am +++ b/xlators/features/cloudsync/src/Makefile.am @@ -21,9 +21,9 @@ cloudsync_la_SOURCES = $(cloudsync_sources) $(cloudsynccommon_sources) nodist_cloudsync_la_SOURCES = cloudsync-autogen-fops.c cloudsync-autogen-fops.h BUILT_SOURCES = cloudsync-autogen-fops.h -cloudsync_la_LDFLAGS = $(LIB_DL) -module $(GF_XLATOR_DEFAULT_LDFLAGS) +cloudsync_la_LDFLAGS = -module $(GF_XLATOR_DEFAULT_LDFLAGS) -cloudsync_la_LIBADD = $(top_builddir)/libglusterfs/src/libglusterfs.la +cloudsync_la_LIBADD = $(top_builddir)/libglusterfs/src/libglusterfs.la $(LIB_DL) AM_CPPFLAGS = $(GF_CPPFLAGS) -I$(top_srcdir)/libglusterfs/src -I$(top_srcdir)/rpc/xdr/src -I$(top_builddir)/rpc/xdr/src \ -DCS_PLUGINDIR=\"$(libdir)/glusterfs/$(PACKAGE_VERSION)/cloudsync-plugins\" |