diff options
Diffstat (limited to 'libglusterfs/src/globals.c')
| -rw-r--r-- | libglusterfs/src/globals.c | 651 |
1 files changed, 228 insertions, 423 deletions
diff --git a/libglusterfs/src/globals.c b/libglusterfs/src/globals.c index 3506d482bda..ae06f8be386 100644 --- a/libglusterfs/src/globals.c +++ b/libglusterfs/src/globals.c @@ -10,84 +10,80 @@ #include <pthread.h> -#include "glusterfs.h" -#include "globals.h" -#include "xlator.h" -#include "mem-pool.h" -#include "syncop.h" -#include "libglusterfs-messages.h" -#include "upcall-utils.h" +#include "glusterfs/syncop.h" +#include "glusterfs/libglusterfs-messages.h" const char *gf_fop_list[GF_FOP_MAXVALUE] = { - [GF_FOP_NULL] = "NULL", - [GF_FOP_STAT] = "STAT", - [GF_FOP_READLINK] = "READLINK", - [GF_FOP_MKNOD] = "MKNOD", - [GF_FOP_MKDIR] = "MKDIR", - [GF_FOP_UNLINK] = "UNLINK", - [GF_FOP_RMDIR] = "RMDIR", - [GF_FOP_SYMLINK] = "SYMLINK", - [GF_FOP_RENAME] = "RENAME", - [GF_FOP_LINK] = "LINK", - [GF_FOP_TRUNCATE] = "TRUNCATE", - [GF_FOP_OPEN] = "OPEN", - [GF_FOP_READ] = "READ", - [GF_FOP_WRITE] = "WRITE", - [GF_FOP_STATFS] = "STATFS", - [GF_FOP_FLUSH] = "FLUSH", - [GF_FOP_FSYNC] = "FSYNC", - [GF_FOP_SETXATTR] = "SETXATTR", - [GF_FOP_GETXATTR] = "GETXATTR", - [GF_FOP_REMOVEXATTR] = "REMOVEXATTR", - [GF_FOP_OPENDIR] = "OPENDIR", - [GF_FOP_FSYNCDIR] = "FSYNCDIR", - [GF_FOP_ACCESS] = "ACCESS", - [GF_FOP_CREATE] = "CREATE", - [GF_FOP_FTRUNCATE] = "FTRUNCATE", - [GF_FOP_FSTAT] = "FSTAT", - [GF_FOP_LK] = "LK", - [GF_FOP_LOOKUP] = "LOOKUP", - [GF_FOP_READDIR] = "READDIR", - [GF_FOP_INODELK] = "INODELK", - [GF_FOP_FINODELK] = "FINODELK", - [GF_FOP_ENTRYLK] = "ENTRYLK", - [GF_FOP_FENTRYLK] = "FENTRYLK", - [GF_FOP_XATTROP] = "XATTROP", - [GF_FOP_FXATTROP] = "FXATTROP", - [GF_FOP_FSETXATTR] = "FSETXATTR", - [GF_FOP_FGETXATTR] = "FGETXATTR", - [GF_FOP_RCHECKSUM] = "RCHECKSUM", - [GF_FOP_SETATTR] = "SETATTR", - [GF_FOP_FSETATTR] = "FSETATTR", - [GF_FOP_READDIRP] = "READDIRP", - [GF_FOP_GETSPEC] = "GETSPEC", - [GF_FOP_FORGET] = "FORGET", - [GF_FOP_RELEASE] = "RELEASE", - [GF_FOP_RELEASEDIR] = "RELEASEDIR", - [GF_FOP_FREMOVEXATTR]= "FREMOVEXATTR", - [GF_FOP_FALLOCATE] = "FALLOCATE", - [GF_FOP_DISCARD] = "DISCARD", - [GF_FOP_ZEROFILL] = "ZEROFILL", - [GF_FOP_IPC] = "IPC", - [GF_FOP_SEEK] = "SEEK", - [GF_FOP_LEASE] = "LEASE", - [GF_FOP_COMPOUND] = "COMPOUND", - [GF_FOP_GETACTIVELK] = "GETACTIVELK", - [GF_FOP_SETACTIVELK] = "SETACTIVELK", - [GF_FOP_PUT] = "PUT", - [GF_FOP_ICREATE] = "ICREATE", - [GF_FOP_NAMELINK] = "NAMELINK", + [GF_FOP_NULL] = "NULL", + [GF_FOP_STAT] = "STAT", + [GF_FOP_READLINK] = "READLINK", + [GF_FOP_MKNOD] = "MKNOD", + [GF_FOP_MKDIR] = "MKDIR", + [GF_FOP_UNLINK] = "UNLINK", + [GF_FOP_RMDIR] = "RMDIR", + [GF_FOP_SYMLINK] = "SYMLINK", + [GF_FOP_RENAME] = "RENAME", + [GF_FOP_LINK] = "LINK", + [GF_FOP_TRUNCATE] = "TRUNCATE", + [GF_FOP_OPEN] = "OPEN", + [GF_FOP_READ] = "READ", + [GF_FOP_WRITE] = "WRITE", + [GF_FOP_STATFS] = "STATFS", + [GF_FOP_FLUSH] = "FLUSH", + [GF_FOP_FSYNC] = "FSYNC", + [GF_FOP_SETXATTR] = "SETXATTR", + [GF_FOP_GETXATTR] = "GETXATTR", + [GF_FOP_REMOVEXATTR] = "REMOVEXATTR", + [GF_FOP_OPENDIR] = "OPENDIR", + [GF_FOP_FSYNCDIR] = "FSYNCDIR", + [GF_FOP_ACCESS] = "ACCESS", + [GF_FOP_CREATE] = "CREATE", + [GF_FOP_FTRUNCATE] = "FTRUNCATE", + [GF_FOP_FSTAT] = "FSTAT", + [GF_FOP_LK] = "LK", + [GF_FOP_LOOKUP] = "LOOKUP", + [GF_FOP_READDIR] = "READDIR", + [GF_FOP_INODELK] = "INODELK", + [GF_FOP_FINODELK] = "FINODELK", + [GF_FOP_ENTRYLK] = "ENTRYLK", + [GF_FOP_FENTRYLK] = "FENTRYLK", + [GF_FOP_XATTROP] = "XATTROP", + [GF_FOP_FXATTROP] = "FXATTROP", + [GF_FOP_FSETXATTR] = "FSETXATTR", + [GF_FOP_FGETXATTR] = "FGETXATTR", + [GF_FOP_RCHECKSUM] = "RCHECKSUM", + [GF_FOP_SETATTR] = "SETATTR", + [GF_FOP_FSETATTR] = "FSETATTR", + [GF_FOP_READDIRP] = "READDIRP", + [GF_FOP_GETSPEC] = "GETSPEC", + [GF_FOP_FORGET] = "FORGET", + [GF_FOP_RELEASE] = "RELEASE", + [GF_FOP_RELEASEDIR] = "RELEASEDIR", + [GF_FOP_FREMOVEXATTR] = "FREMOVEXATTR", + [GF_FOP_FALLOCATE] = "FALLOCATE", + [GF_FOP_DISCARD] = "DISCARD", + [GF_FOP_ZEROFILL] = "ZEROFILL", + [GF_FOP_IPC] = "IPC", + [GF_FOP_SEEK] = "SEEK", + [GF_FOP_LEASE] = "LEASE", + [GF_FOP_COMPOUND] = "COMPOUND", + [GF_FOP_GETACTIVELK] = "GETACTIVELK", + [GF_FOP_SETACTIVELK] = "SETACTIVELK", + [GF_FOP_PUT] = "PUT", + [GF_FOP_ICREATE] = "ICREATE", + [GF_FOP_NAMELINK] = "NAMELINK", + [GF_FOP_COPY_FILE_RANGE] = "COPY_FILE_RANGE", }; const char *gf_upcall_list[GF_UPCALL_FLAGS_MAXVALUE] = { - [GF_UPCALL_NULL] = "NULL", - [GF_UPCALL] = "UPCALL", - [GF_UPCALL_CI_STAT] = "CI_IATT", - [GF_UPCALL_CI_XATTR] = "CI_XATTR", - [GF_UPCALL_CI_RENAME] = "CI_RENAME", - [GF_UPCALL_CI_NLINK] = "CI_UNLINK", - [GF_UPCALL_CI_FORGET] = "CI_FORGET", - [GF_UPCALL_LEASE_RECALL] = "LEASE_RECALL", + [GF_UPCALL_NULL] = "NULL", + [GF_UPCALL] = "UPCALL", + [GF_UPCALL_CI_STAT] = "CI_IATT", + [GF_UPCALL_CI_XATTR] = "CI_XATTR", + [GF_UPCALL_CI_RENAME] = "CI_RENAME", + [GF_UPCALL_CI_NLINK] = "CI_UNLINK", + [GF_UPCALL_CI_FORGET] = "CI_FORGET", + [GF_UPCALL_LEASE_RECALL] = "LEASE_RECALL", }; /* THIS */ @@ -98,464 +94,273 @@ const char *gf_upcall_list[GF_UPCALL_FLAGS_MAXVALUE] = { glusterfs_ctx_t *global_ctx = NULL; pthread_mutex_t global_ctx_mutex = PTHREAD_MUTEX_INITIALIZER; xlator_t global_xlator; -static pthread_key_t this_xlator_key; -static pthread_key_t synctask_key; -static pthread_key_t uuid_buf_key; -static char global_uuid_buf[GF_UUID_BUF_SIZE]; -static pthread_key_t lkowner_buf_key; -static char global_lkowner_buf[GF_LKOWNER_BUF_SIZE]; -static pthread_key_t leaseid_buf_key; static int gf_global_mem_acct_enable = 1; static pthread_once_t globals_inited = PTHREAD_ONCE_INIT; +static pthread_key_t free_key; -int -gf_global_mem_acct_enable_get (void) -{ - return gf_global_mem_acct_enable; -} +static __thread xlator_t *thread_xlator = NULL; +static __thread void *thread_synctask = NULL; +static __thread void *thread_leaseid = NULL; +static __thread struct syncopctx thread_syncopctx = {}; +static __thread char thread_uuid_buf[GF_UUID_BUF_SIZE] = {}; +static __thread char thread_lkowner_buf[GF_LKOWNER_BUF_SIZE] = {}; +static __thread char thread_leaseid_buf[GF_LEASE_ID_BUF_SIZE] = {}; int -gf_global_mem_acct_enable_set (int val) +gf_global_mem_acct_enable_get(void) { - gf_global_mem_acct_enable = val; - return 0; + return gf_global_mem_acct_enable; } -void -glusterfs_this_destroy (void *ptr) +int +gf_global_mem_acct_enable_set(int val) { - FREE (ptr); + gf_global_mem_acct_enable = val; + return 0; } static struct xlator_cbks global_cbks = { - .forget = NULL, - .release = NULL, - .releasedir = NULL, - .invalidate = NULL, - .client_destroy = NULL, - .client_disconnect = NULL, - .ictxmerge = NULL, - .ictxsize = NULL, - .fdctxsize = NULL, + .forget = NULL, + .release = NULL, + .releasedir = NULL, + .invalidate = NULL, + .client_destroy = NULL, + .client_disconnect = NULL, + .ictxmerge = NULL, + .ictxsize = NULL, + .fdctxsize = NULL, }; /* This is required to get through the check in graph.c */ -static struct xlator_fops global_fops = { -}; +static struct xlator_fops global_fops = {}; static int -global_xl_reconfigure (xlator_t *this, dict_t *options) +global_xl_reconfigure(xlator_t *this, dict_t *options) { - int ret = -1; - gf_boolean_t bool_opt = _gf_false; + int ret = -1; + gf_boolean_t bool_opt = _gf_false; - /* This is not added in volume dump, hence adding the options in log - would be helpful for debugging later */ - dict_dump_to_log (options); + /* This is not added in volume dump, hence adding the options in log + would be helpful for debugging later */ + dict_dump_to_log(options); - GF_OPTION_RECONF ("measure-latency", bool_opt, options, bool, out); - this->ctx->measure_latency = bool_opt; + GF_OPTION_RECONF("measure-latency", bool_opt, options, bool, out); + this->ctx->measure_latency = bool_opt; - GF_OPTION_RECONF ("metrics-dump-path", this->ctx->config.metrics_dumppath, - options, str, out); + GF_OPTION_RECONF("metrics-dump-path", this->ctx->config.metrics_dumppath, + options, str, out); - /* TODO: add more things here */ - ret = 0; + /* TODO: add more things here */ + ret = 0; out: - return ret; + return ret; } static int -global_xl_init (xlator_t *this) +global_xl_init(xlator_t *this) { - int ret = -1; - gf_boolean_t bool_opt = false; + int ret = -1; + gf_boolean_t bool_opt = false; - GF_OPTION_INIT ("measure-latency", bool_opt, bool, out); - this->ctx->measure_latency = bool_opt; + GF_OPTION_INIT("measure-latency", bool_opt, bool, out); + this->ctx->measure_latency = bool_opt; - GF_OPTION_INIT ("metrics-dump-path", this->ctx->config.metrics_dumppath, - str, out); + GF_OPTION_INIT("metrics-dump-path", this->ctx->config.metrics_dumppath, str, + out); - ret = 0; + ret = 0; out: - return ret; + return ret; } static void -global_xl_fini (xlator_t *this) +global_xl_fini(xlator_t *this) { - return; + return; } struct volume_options global_xl_options[] = { - { .key = {"measure-latency"}, - .type = GF_OPTION_TYPE_BOOL, - .default_value = "no", - .op_version = {GD_OP_VERSION_4_0_0}, - .flags = OPT_FLAG_SETTABLE, - .tags = {"global", "context"}, - .description = "Use this option to toggle measuring latency" - }, - { .key = {"metrics-dump-path"}, - .type = GF_OPTION_TYPE_STR, - .default_value = "{{gluster_workdir}}/metrics", - .op_version = {GD_OP_VERSION_4_0_0}, - .flags = OPT_FLAG_SETTABLE, - .tags = {"global", "context"}, - .description = "Use this option to set the metrics dump path" - }, - - { .key = {NULL},}, + {.key = {"measure-latency"}, + .type = GF_OPTION_TYPE_BOOL, + .default_value = "no", + .op_version = {GD_OP_VERSION_4_0_0}, + .flags = OPT_FLAG_SETTABLE, + .tags = {"global", "context"}, + .description = "Use this option to toggle measuring latency"}, + {.key = {"metrics-dump-path"}, + .type = GF_OPTION_TYPE_STR, + .default_value = "{{gluster_workdir}}/metrics", + .op_version = {GD_OP_VERSION_4_0_0}, + .flags = OPT_FLAG_SETTABLE, + .tags = {"global", "context"}, + .description = "Use this option to set the metrics dump path"}, + + { + .key = {NULL}, + }, }; static volume_opt_list_t global_xl_opt_list; -int -glusterfs_this_init () +void +glusterfs_this_init() { - int ret = 0; - ret = pthread_key_create (&this_xlator_key, glusterfs_this_destroy); - if (ret != 0) { - gf_msg ("", GF_LOG_WARNING, ret, - LG_MSG_PTHREAD_KEY_CREATE_FAILED, "failed to create " - "the pthread key"); - return ret; - } - - global_xlator.name = "glusterfs"; - global_xlator.type = GF_GLOBAL_XLATOR_NAME; - global_xlator.cbks = &global_cbks; - global_xlator.fops = &global_fops; - global_xlator.reconfigure = global_xl_reconfigure; - global_xlator.init = global_xl_init; - global_xlator.fini = global_xl_fini; - - INIT_LIST_HEAD (&global_xlator.volume_options); - INIT_LIST_HEAD (&global_xl_opt_list.list); - global_xl_opt_list.given_opt = global_xl_options; - - list_add_tail (&global_xl_opt_list.list, &global_xlator.volume_options); - - return ret; + global_xlator.name = "glusterfs"; + global_xlator.type = GF_GLOBAL_XLATOR_NAME; + global_xlator.cbks = &global_cbks; + global_xlator.fops = &global_fops; + global_xlator.reconfigure = global_xl_reconfigure; + global_xlator.init = global_xl_init; + global_xlator.fini = global_xl_fini; + + INIT_LIST_HEAD(&global_xlator.volume_options); + INIT_LIST_HEAD(&global_xl_opt_list.list); + global_xl_opt_list.given_opt = global_xl_options; + + list_add_tail(&global_xl_opt_list.list, &global_xlator.volume_options); } - xlator_t ** -__glusterfs_this_location () +__glusterfs_this_location() { - xlator_t **this_location = NULL; - int ret = 0; - - this_location = pthread_getspecific (this_xlator_key); - - if (!this_location) { - this_location = CALLOC (1, sizeof (*this_location)); - if (!this_location) - goto out; - - ret = pthread_setspecific (this_xlator_key, this_location); - if (ret != 0) { - FREE (this_location); - this_location = NULL; - goto out; - } - } -out: - if (this_location) { - if (!*this_location) - *this_location = &global_xlator; - } - return this_location; -} + xlator_t **this_location; + this_location = &thread_xlator; + if (*this_location == NULL) { + thread_xlator = &global_xlator; + } + + return this_location; +} xlator_t * -glusterfs_this_get () +glusterfs_this_get() { - xlator_t **this_location = NULL; - - this_location = __glusterfs_this_location (); - if (!this_location) - return &global_xlator; - - return *this_location; + return *__glusterfs_this_location(); } - -int -glusterfs_this_set (xlator_t *this) +void +glusterfs_this_set(xlator_t *this) { - xlator_t **this_location = NULL; - - this_location = __glusterfs_this_location (); - if (!this_location) - return -ENOMEM; - - *this_location = this; - - return 0; + thread_xlator = this; } /* SYNCOPCTX */ -static pthread_key_t syncopctx_key; - -static void -syncopctx_key_destroy (void *ptr) -{ - struct syncopctx *opctx = ptr; - - if (opctx) { - if (opctx->groups) - GF_FREE (opctx->groups); - - GF_FREE (opctx); - } - - return; -} void * -syncopctx_getctx () +syncopctx_getctx() { - void *opctx = NULL; - - opctx = pthread_getspecific (syncopctx_key); - - return opctx; -} - -int -syncopctx_setctx (void *ctx) -{ - int ret = 0; - - ret = pthread_setspecific (syncopctx_key, ctx); - - return ret; -} - -static int -syncopctx_init (void) -{ - int ret; - - ret = pthread_key_create (&syncopctx_key, syncopctx_key_destroy); - - return ret; + return &thread_syncopctx; } /* SYNCTASK */ -int -synctask_init () -{ - int ret = 0; - - ret = pthread_key_create (&synctask_key, NULL); - - return ret; -} - void * -synctask_get () -{ - void *synctask = NULL; - - synctask = pthread_getspecific (synctask_key); - - return synctask; -} - - -int -synctask_set (void *synctask) +synctask_get() { - int ret = 0; - - pthread_setspecific (synctask_key, synctask); - - return ret; + return thread_synctask; } -//UUID_BUFFER - void -glusterfs_uuid_buf_destroy (void *ptr) +synctask_set(void *synctask) { - FREE (ptr); + thread_synctask = synctask; } -int -glusterfs_uuid_buf_init () -{ - int ret = 0; - - ret = pthread_key_create (&uuid_buf_key, - glusterfs_uuid_buf_destroy); - return ret; -} +// UUID_BUFFER char * -glusterfs_uuid_buf_get () +glusterfs_uuid_buf_get() { - char *buf; - int ret = 0; - - buf = pthread_getspecific (uuid_buf_key); - if(!buf) { - buf = MALLOC (GF_UUID_BUF_SIZE); - ret = pthread_setspecific (uuid_buf_key, (void *) buf); - if (ret) - buf = global_uuid_buf; - } - return buf; + return thread_uuid_buf; } /* LKOWNER_BUFFER */ -void -glusterfs_lkowner_buf_destroy (void *ptr) +char * +glusterfs_lkowner_buf_get() { - FREE (ptr); + return thread_lkowner_buf; } -int -glusterfs_lkowner_buf_init () -{ - int ret = 0; - - ret = pthread_key_create (&lkowner_buf_key, - glusterfs_lkowner_buf_destroy); - return ret; -} +/* Leaseid buffer */ char * -glusterfs_lkowner_buf_get () +glusterfs_leaseid_buf_get() { - char *buf; - int ret = 0; - - buf = pthread_getspecific (lkowner_buf_key); - if(!buf) { - buf = MALLOC (GF_LKOWNER_BUF_SIZE); - ret = pthread_setspecific (lkowner_buf_key, (void *) buf); - if (ret) - buf = global_lkowner_buf; - } - return buf; -} + char *buf = NULL; -/* Leaseid buffer */ -void -glusterfs_leaseid_buf_destroy (void *ptr) -{ - FREE (ptr); + buf = thread_leaseid; + if (buf == NULL) { + buf = thread_leaseid_buf; + thread_leaseid = buf; + } + + return buf; } -int -glusterfs_leaseid_buf_init () +char * +glusterfs_leaseid_exist() { - int ret = 0; - - ret = pthread_key_create (&leaseid_buf_key, - glusterfs_leaseid_buf_destroy); - return ret; + return thread_leaseid; } -char * -glusterfs_leaseid_buf_get () +static void +glusterfs_cleanup(void *ptr) { - char *buf = NULL; - int ret = 0; - - buf = pthread_getspecific (leaseid_buf_key); - if (!buf) { - buf = CALLOC (1, GF_LEASE_ID_BUF_SIZE); - ret = pthread_setspecific (leaseid_buf_key, (void *) buf); - if (ret) { - FREE (buf); - buf = NULL; - } - } - return buf; + if (thread_syncopctx.groups != NULL) { + GF_FREE(thread_syncopctx.groups); + } + + mem_pool_thread_destructor(NULL); } -char * -glusterfs_leaseid_exist () +void +gf_thread_needs_cleanup(void) { - return pthread_getspecific (leaseid_buf_key); + /* The value stored in free_key TLS is not really used for anything, but + * pthread implementation doesn't call the TLS destruction function unless + * it's != NULL. This function must be called whenever something is + * allocated for this thread so that glusterfs_cleanup() will be called + * and resources can be released. */ + (void)pthread_setspecific(free_key, (void *)1); } static void -gf_globals_init_once () +gf_globals_init_once() { - int ret = 0; - - ret = glusterfs_this_init (); - if (ret) { - gf_msg ("", GF_LOG_CRITICAL, 0, LG_MSG_TRANSLATOR_INIT_FAILED, - "ERROR: glusterfs-translator init failed"); - goto out; - } - - ret = glusterfs_uuid_buf_init (); - if(ret) { - gf_msg ("", GF_LOG_CRITICAL, 0, LG_MSG_UUID_BUF_INIT_FAILED, - "ERROR: glusterfs uuid buffer init failed"); - goto out; - } - - ret = glusterfs_lkowner_buf_init (); - if(ret) { - gf_msg ("", GF_LOG_CRITICAL, 0, LG_MSG_LKOWNER_BUF_INIT_FAILED, - "ERROR: glusterfs lkowner buffer init failed"); - goto out; - } - - ret = glusterfs_leaseid_buf_init (); - if (ret) { - gf_msg ("", GF_LOG_CRITICAL, 0, LG_MSG_LEASEID_BUF_INIT_FAILED, - "ERROR: glusterfs leaseid buffer init failed"); - goto out; - } - - ret = synctask_init (); - if (ret) { - gf_msg ("", GF_LOG_CRITICAL, 0, LG_MSG_SYNCTASK_INIT_FAILED, - "ERROR: glusterfs synctask init failed"); - goto out; - } - - ret = syncopctx_init (); - if (ret) { - gf_msg ("", GF_LOG_CRITICAL, 0, LG_MSG_SYNCOPCTX_INIT_FAILED, - "ERROR: glusterfs syncopctx init failed"); - goto out; - } -out: + int ret = 0; + + glusterfs_this_init(); + + /* This is needed only to cleanup the potential allocation of + * thread_syncopctx.groups. */ + ret = pthread_key_create(&free_key, glusterfs_cleanup); + if (ret != 0) { + gf_msg("", GF_LOG_ERROR, ret, LG_MSG_PTHREAD_KEY_CREATE_FAILED, + "failed to create the pthread key"); + + gf_msg("", GF_LOG_CRITICAL, 0, LG_MSG_GLOBAL_INIT_FAILED, + "Exiting as global initialization failed"); - if (ret) { - gf_msg ("", GF_LOG_CRITICAL, 0, LG_MSG_GLOBAL_INIT_FAILED, - "Exiting as global initialization failed"); - exit (ret); - } + exit(ret); + } } int -glusterfs_globals_init (glusterfs_ctx_t *ctx) +glusterfs_globals_init(glusterfs_ctx_t *ctx) { - int ret = 0; + int ret = 0; - gf_log_globals_init (ctx, GF_LOG_INFO); + gf_log_globals_init(ctx, GF_LOG_INFO); - ret = pthread_once (&globals_inited, gf_globals_init_once); + ret = pthread_once(&globals_inited, gf_globals_init_once); - if (ret) - gf_msg ("", GF_LOG_CRITICAL, ret, LG_MSG_PTHREAD_FAILED, - "pthread_once failed"); + if (ret) + gf_msg("", GF_LOG_CRITICAL, ret, LG_MSG_PTHREAD_FAILED, + "pthread_once failed"); - return ret; + return ret; } |