summaryrefslogtreecommitdiffstats
path: root/src/com.gluster.storage.management.server
diff options
context:
space:
mode:
authorselvam <selvam@selvam-Studio-XPS-1340.(none)>2011-06-02 16:14:31 +0530
committerselvam <selvam@selvam-Studio-XPS-1340.(none)>2011-06-02 16:14:31 +0530
commit16459c062096d9dbe5d4c8cfe65882a117dd504c (patch)
treedb504a01182cc5daa7c4e8148bc11ff624115219 /src/com.gluster.storage.management.server
parenta468e753ba0c437bf4fb1bf4250cd1d0e175a08b (diff)
Create volume "create volume options" error is captured and handled in the UI.
Created volume is updated in the UI.
Diffstat (limited to 'src/com.gluster.storage.management.server')
-rw-r--r--src/com.gluster.storage.management.server/src/com/gluster/storage/management/server/resources/VolumesResource.java9
-rw-r--r--src/com.gluster.storage.management.server/src/com/gluster/storage/management/server/utils/GlusterUtil.java8
2 files changed, 6 insertions, 11 deletions
diff --git a/src/com.gluster.storage.management.server/src/com/gluster/storage/management/server/resources/VolumesResource.java b/src/com.gluster.storage.management.server/src/com/gluster/storage/management/server/resources/VolumesResource.java
index 1a95fac5..d16f7678 100644
--- a/src/com.gluster.storage.management.server/src/com/gluster/storage/management/server/resources/VolumesResource.java
+++ b/src/com.gluster.storage.management.server/src/com/gluster/storage/management/server/resources/VolumesResource.java
@@ -156,15 +156,6 @@ public class VolumesResource {
}
status = glusterUtil.createVolume(volume, brickDirectories, onlineServer.getName());
}
-
- if (status.isSuccess()) {
- // volume created. set the options.
- Status optionsStatus = glusterUtil.createOptions(volume, onlineServer.getName());
- if (!optionsStatus.isSuccess()) {
- status.setCode(Status.STATUS_CODE_PART_SUCCESS);
- status.setMessage("Error while setting volume options: " + optionsStatus);
- }
- }
return status;
}
diff --git a/src/com.gluster.storage.management.server/src/com/gluster/storage/management/server/utils/GlusterUtil.java b/src/com.gluster.storage.management.server/src/com/gluster/storage/management/server/utils/GlusterUtil.java
index db0e5f8f..6005f6dd 100644
--- a/src/com.gluster.storage.management.server/src/com/gluster/storage/management/server/utils/GlusterUtil.java
+++ b/src/com.gluster.storage.management.server/src/com/gluster/storage/management/server/utils/GlusterUtil.java
@@ -220,8 +220,12 @@ public class GlusterUtil {
if (!result.isSuccess()) {
return new Status(result);
}
-
- return createOptions(volume, knownServer);
+ Status status = createOptions(volume, knownServer);
+ if (!status.isSuccess()) { // Return partial success if set volume option failed.
+ status.setCode(Status.STATUS_CODE_PART_SUCCESS);
+ status.setMessage("Error while setting volume options: " + status);
+ }
+ return status;
}
private String prepareVolumeCreateCommand(Volume volume, List<String> brickDirectories, int count,