diff options
author | Prashanth Pai <ppai@redhat.com> | 2016-05-30 15:08:48 +0530 |
---|---|---|
committer | Prashanth Pai <ppai@redhat.com> | 2016-06-15 15:02:18 +0530 |
commit | b111d50347076336b3e655178d967f8e5c8c9913 (patch) | |
tree | b4ad1944d0379f560fae379efd27d69e7c12eb65 /gluster/utils.py | |
parent | 759471ddcd76306b952bb2ee28f211afc9e24f3a (diff) |
Add validation decorators
As glfs and glfd are pointers to memory locations, passing invalid
values of glfs and glfd to the libgfapi C library can result in
segfault. This patch introduces decorators that validate glfs
and glfd before calling correspoding C APIs.
Change-Id: I4e86bd8e436e23cd41f75f428d246939c820bb9c
Signed-off-by: Prashanth Pai <ppai@redhat.com>
Diffstat (limited to 'gluster/utils.py')
-rw-r--r-- | gluster/utils.py | 62 |
1 files changed, 62 insertions, 0 deletions
diff --git a/gluster/utils.py b/gluster/utils.py new file mode 100644 index 0000000..833302e --- /dev/null +++ b/gluster/utils.py @@ -0,0 +1,62 @@ +# Copyright (c) 2016 Red Hat, Inc. +# +# Licensed under the Apache License, Version 2.0 (the "License"); +# you may not use this file except in compliance with the License. +# You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or +# implied. +# See the License for the specific language governing permissions and +# limitations under the License. + +import os +import errno +from functools import wraps +from gluster.exceptions import VolumeNotMounted + + +def validate_mount(func): + """ + Decorator to assert that volume is initialized and mounted before any + further I/O calls are invoked by methods. + + :param func: method to be decorated and checked. + """ + def _exception(volname): + raise VolumeNotMounted('Volume "%s" not mounted.' % (volname)) + + @wraps(func) + def wrapper(*args, **kwargs): + self = args[0] + if self.fs and self._mounted: + return func(*args, **kwargs) + else: + return _exception(self.volname) + wrapper.__wrapped__ = func + + return wrapper + + +def validate_glfd(func): + """ + Decorator to assert that glfd is valid. + + :param func: method to be decorated and checked. + """ + def _exception(): + raise OSError(errno.EBADF, os.strerror(errno.EBADF)) + + @wraps(func) + def wrapper(*args, **kwargs): + self = args[0] + if self.fd: + return func(*args, **kwargs) + else: + return _exception() + wrapper.__wrapped__ = func + + return wrapper |