summaryrefslogtreecommitdiffstats
path: root/dvm/763924/testcase
diff options
context:
space:
mode:
authorM S Vishwanath Bhat <vishwanath@gluster.com>2011-12-26 17:02:12 +0530
committerM S Vishwanath Bhat <vishwanath@gluster.com>2012-02-03 14:47:58 +0530
commit7b96d64f4ed1a969d1cb6fd08954369c892b56c8 (patch)
tree332fcf2f7db58ffdb7fa8e6ad0821aedf800bd3a /dvm/763924/testcase
parent060e2ec30d1f38f225bcb9298e23661a1a65d3f5 (diff)
BUG:2721 -- Checks for correct validation message in volume top commands
Change-Id: I90986f41e812de55cd5cf6ee1402a5d580b88ecc BUG: 2721 Signed-off-by: M S Vishwanath Bhat <vishwanath@gluster.com>
Diffstat (limited to 'dvm/763924/testcase')
0 files changed, 0 insertions, 0 deletions
git/tree/?h=v4.1.2&id=0b9af18eade6583299b88b4e685b02114db7834a'>979430bc5675e584c9f9a1e71871025d1f0cb8dc /xlators/cluster parent2f4898de4c3dda7072c02cf2f799d71d349016af (diff)
cluster/dht: Do rename cleanup as root
Problem: Rename linkfile cleanup is done as non-root which may not have priviliges to do the rename so it fails with EACCESS. MKDIR on that name in future will start to hole on this subvolume. It is not easy to hit on fuse mounts because vfs takes care of the permission checks even before rename fop is wound. But with nfs-ganesha mounts it happens. Fix: Do rename cleanup as root BUG: 1409727 Change-Id: I414c1eb6dce76b4516a6c940557b249e6c3f22f4 Signed-off-by: Pranith Kumar K <pkarampu@redhat.com> Reviewed-on: http://review.gluster.org/16317 Smoke: Gluster Build System <jenkins@build.gluster.org> CentOS-regression: Gluster Build System <jenkins@build.gluster.org> Reviewed-by: Raghavendra G <rgowdapp@redhat.com> Reviewed-by: N Balachandran <nbalacha@redhat.com> NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
Diffstat (limited to 'xlators/cluster')
-rw-r--r--xlators/cluster/dht/src/dht-rename.c1
1 files changed, 1 insertions, 0 deletions
diff --git a/xlators/cluster/dht/src/dht-rename.c b/xlators/cluster/dht/src/dht-rename.c
index a9ffd1d9fb5..d955ee411eb 100644
--- a/xlators/cluster/dht/src/dht-rename.c
+++ b/xlators/cluster/dht/src/dht-rename.c
@@ -724,6 +724,7 @@ dht_rename_cleanup (call_frame_t *frame)
DHT_MARKER_DONT_ACCOUNT(xattr_new);
+ FRAME_SU_DO (frame, dht_local_t);
STACK_WIND (frame, dht_rename_unlink_cbk,
dst_hashed, dst_hashed->fops->unlink,
&local->loc, 0, xattr_new);