diff options
| author | Nigel Babu <nigelb@redhat.com> | 2017-02-20 08:27:51 +0530 |
|---|---|---|
| committer | Shyamsundar Ranganathan <srangana@redhat.com> | 2017-02-26 11:29:26 -0500 |
| commit | 688abcc90745515f7e143ef8cf1e938239db597c (patch) | |
| tree | 829941bd832eaf851af0cc2f2c39806c7886d56e /libglusterfs | |
| parent | dc15855cea679affd78d28fd94cbea0c108997f0 (diff) | |
libglusterfs, gfdb, glusterfs: Add missing breaks
A few switches did not have breaks causing fall throughs. Most of them
have been fixed with fall through comments for those that are
intentional.
Change-Id: I84c85726b542f38504b50fefab5eba5dbcd27a07
BUG: 1424894
Signed-off-by: Nigel Babu <nigelb@redhat.com>
Reviewed-on: https://review.gluster.org/16677
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Smoke: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
Reviewed-by: Shyamsundar Ranganathan <srangana@redhat.com>
Diffstat (limited to 'libglusterfs')
| -rw-r--r-- | libglusterfs/src/call-stub.c | 4 | ||||
| -rw-r--r-- | libglusterfs/src/common-utils.c | 2 | ||||
| -rw-r--r-- | libglusterfs/src/gfdb/gfdb_sqlite3.c | 1 |
3 files changed, 7 insertions, 0 deletions
diff --git a/libglusterfs/src/call-stub.c b/libglusterfs/src/call-stub.c index c9c47b56c98..9aa67aab6c2 100644 --- a/libglusterfs/src/call-stub.c +++ b/libglusterfs/src/call-stub.c @@ -2218,11 +2218,13 @@ call_resume_wind (call_stub_t *stub) case GF_FOP_GETACTIVELK: stub->fn.getactivelk (stub->frame, stub->frame->this, &stub->args.loc, stub->args.xdata); + break; case GF_FOP_SETACTIVELK: stub->fn.setactivelk (stub->frame, stub->frame->this, &stub->args.loc, &stub->args.locklist, stub->args.xdata); + break; default: gf_msg_callingfn ("call-stub", GF_LOG_ERROR, EINVAL, @@ -2445,9 +2447,11 @@ call_resume_unwind (call_stub_t *stub) case GF_FOP_GETACTIVELK: STUB_UNWIND (stub, getactivelk, &stub->args_cbk.locklist, stub->args_cbk.xdata); + break; case GF_FOP_SETACTIVELK: STUB_UNWIND (stub, setactivelk, stub->args_cbk.xdata); + break; default: gf_msg_callingfn ("call-stub", GF_LOG_ERROR, EINVAL, diff --git a/libglusterfs/src/common-utils.c b/libglusterfs/src/common-utils.c index 1e77ebe6f29..51f97442fec 100644 --- a/libglusterfs/src/common-utils.c +++ b/libglusterfs/src/common-utils.c @@ -4517,6 +4517,8 @@ fop_enum_to_string (glusterfs_fop_t fop) "IPC", "SEEK", "COMPOUND", + "GETACTIVELK", + "SETACTIVELK", "MAXVALUE"}; if (fop <= GF_FOP_MAXVALUE) return str_map[fop]; diff --git a/libglusterfs/src/gfdb/gfdb_sqlite3.c b/libglusterfs/src/gfdb/gfdb_sqlite3.c index 70e38855fde..16930504742 100644 --- a/libglusterfs/src/gfdb/gfdb_sqlite3.c +++ b/libglusterfs/src/gfdb/gfdb_sqlite3.c @@ -1456,6 +1456,7 @@ gf_sqlite3_vacuum (void *db_conn, gf_boolean_t compact_active, break; case GF_SQL_COMPACT_MANUAL: changing_pragma = _gf_false; + break; default: ret = -1; gf_msg (GFDB_STR_SQLITE3, GF_LOG_ERROR, 0, |